From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F8B5C432BE for ; Tue, 31 Aug 2021 19:32:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A82761053 for ; Tue, 31 Aug 2021 19:32:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9A82761053 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tls.msk.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL9Ul-0003Ua-KR for qemu-devel@archiver.kernel.org; Tue, 31 Aug 2021 15:32:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL9OZ-0006wj-Tx; Tue, 31 Aug 2021 15:26:07 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:53447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL9OW-0000IK-41; Tue, 31 Aug 2021 15:26:07 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id AA95440835; Tue, 31 Aug 2021 22:26:00 +0300 (MSK) Received: from [192.168.177.130] (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 7E53E71; Tue, 31 Aug 2021 22:26:00 +0300 (MSK) Subject: Re: [PATCH] qemu-sockets: fix unix socket path copy (again) To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= References: <20210831182623.1792608-1-mjt@msgid.tls.msk.ru> From: Michael Tokarev Message-ID: Date: Tue, 31 Aug 2021 22:26:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -77 X-Spam_score: -7.8 X-Spam_bar: ------- X-Spam_report: (-7.8 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.932, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , qemu-devel , qemu-stable Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 31.08.2021 22:21, Marc-André Lureau wrote: ... > Seems right to me, however there are some notes in libc bits/socket.h > /* Structure large enough to hold any socket address (with the historical >    exception of AF_UNIX).  */ > > And also this > https://idea.popcount.org/2019-12-06-addressing/#fn:sockaddr_storage > > I must say I feel confused by those comments :) Is it large enough or not?? It was my first thought too when I first saw the prototype of this very function we're patching here: socket_sockaddr_to_address_unix(struct sockaddr_storage *sa, ...) it uses sockaddr_storage and I swear I always thought sockaddr_storage is for sockaddr_in and sockaddr_in6 but NOT for sockaddr_un. If this is the case we're in trouble actually and all this stuff needs serious review. However by fact sockaddr_storage is actually LARGER than sockaddr_un. I dunno how universal it is. /mjt