From mboxrd@z Thu Jan  1 00:00:00 1970
From: Harry Wentland <harry.wentland-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 04/10] amdgpu/dc: allow inlining constant int to fixed a
 lot better.
Date: Fri, 29 Sep 2017 11:13:32 -0400
Message-ID: <b4bb7ba8-c463-525a-cb54-f502c3326da4@amd.com>
References: <20170929071331.18132-1-airlied@gmail.com>
 <20170929071331.18132-4-airlied@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20170929071331.18132-4-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Content-Language: en-US
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Dave Airlie <airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

T24gMjAxNy0wOS0yOSAwMzoxMyBBTSwgRGF2ZSBBaXJsaWUgd3JvdGU6Cj4gRnJvbTogRGF2ZSBB
aXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KPiAKPiBUaGlzIHVzZXMgdHdvIHRoaW5ncyB0aGF0
IG1pZ2h0IGJlIExpbnV4IHNwZWNpZmljLAo+IF9fYnVpbHRpbl9jb25zdGFudF9wIChtaWdodCBi
ZSBnY2MpCj4gYW5kCj4gQlVJTERfQlVHX09OLiAobWF5YmUgb3RoZXIgZG0ncyBjYW4gaGF2ZSBz
b21ldGhpbmcgc2ltaWxpYXIpLgo+IAoKV2UgY2FuIGFsd2F5cyB1c2UgaWZkZWYgaW4gb3VyIGlu
dGVybmFsIHRyZWUgdG8ga2VlcCBMaW51eCBzcGVjaWZpYyBiaXRzCndpdGhvdXQgYWZmZWN0aW5n
IG90aGVyIHVzZXJzIG9mIG91ciBjb2RlLiBBcyBsb25nIGFzIGl0J3Mgbm90IGFsbCBvdmVyCnRo
ZSBwbGFjZSBhbmQgdGhlIHBheW9mZiBpcyB3b3J0aHdoaWxlLCB3aGljaCBpdCBpcyBpbiB0aGlz
IGNhc2UuCgpIYXJyeQoKPiBUaGlzIHNhdmVzIDRrIGluIHRoZSBidyBjYWxjcyBjb2RlLgo+IAo+
IFNpZ25lZC1vZmYtYnk6IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4gLS0tCj4g
IGRyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9id19maXhlZC5jIHwgMzcgKysr
KysrKystLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMv
aW5jL2J3X2ZpeGVkLmggICB8IDI2ICsrKysrKysrKysrKysrKy0tCj4gIDIgZmlsZXMgY2hhbmdl
ZCwgMzUgaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9id19maXhlZC5jIGIvZHJpdmVycy9n
cHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2J3X2ZpeGVkLmMKPiBpbmRleCAwZGU2ZmExLi42
Y2EyODhmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxj
cy9id19maXhlZC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNz
L2J3X2ZpeGVkLmMKPiBAQCAtMjUsMTMgKzI1LDYgQEAKPiAgI2luY2x1ZGUgImRtX3NlcnZpY2Vz
LmgiCj4gICNpbmNsdWRlICJid19maXhlZC5oIgo+ICAKPiAtI2RlZmluZSBCSVRTX1BFUl9GUkFD
VElPTkFMX1BBUlQgMjQKPiAtCj4gLSNkZWZpbmUgTUlOX0kzMiBcCj4gLQkoaW50NjRfdCkoLSgx
TEwgPDwgKDYzIC0gQklUU19QRVJfRlJBQ1RJT05BTF9QQVJUKSkpCj4gLQo+IC0jZGVmaW5lIE1B
WF9JMzIgXAo+IC0JKGludDY0X3QpKCgxVUxMIDw8ICg2MyAtIEJJVFNfUEVSX0ZSQUNUSU9OQUxf
UEFSVCkpIC0gMSkKPiAgCj4gICNkZWZpbmUgTUlOX0k2NCBcCj4gIAkoaW50NjRfdCkoLSgxTEwg
PDwgNjMpKQo+IEBAIC00MCwxMCArMzMsNyBAQAo+ICAJKGludDY0X3QpKCgxVUxMIDw8IDYzKSAt
IDEpCj4gIAo+ICAjZGVmaW5lIEZSQUNUSU9OQUxfUEFSVF9NQVNLIFwKPiAtCSgoMVVMTCA8PCBC
SVRTX1BFUl9GUkFDVElPTkFMX1BBUlQpIC0gMSkKPiAtCj4gLSNkZWZpbmUgR0VUX0lOVEVHRVJf
UEFSVCh4KSBcCj4gLQkoKHgpID4+IEJJVFNfUEVSX0ZSQUNUSU9OQUxfUEFSVCkKPiArCSgoMVVM
TCA8PCBCV19GSVhFRF9CSVRTX1BFUl9GUkFDVElPTkFMX1BBUlQpIC0gMSkKPiAgCj4gICNkZWZp
bmUgR0VUX0ZSQUNUSU9OQUxfUEFSVCh4KSBcCj4gIAkoRlJBQ1RJT05BTF9QQVJUX01BU0sgJiAo
eCkpCj4gQEAgLTU2LDE5ICs0NiwxNCBAQCBzdGF0aWMgdWludDY0X3QgYWJzX2k2NChpbnQ2NF90
IGFyZykKPiAgCQlyZXR1cm4gKHVpbnQ2NF90KSgtYXJnKTsKPiAgfQo+ICAKPiAtc3RydWN0IGJ3
X2ZpeGVkIGJ3X2ludF90b19maXhlZChpbnQ2NF90IHZhbHVlKQo+ICtzdHJ1Y3QgYndfZml4ZWQg
YndfaW50X3RvX2ZpeGVkX25vbmNvbnN0KGludDY0X3QgdmFsdWUpCj4gIHsKPiAgCXN0cnVjdCBi
d19maXhlZCByZXM7Cj4gLQlBU1NFUlQodmFsdWUgPCBNQVhfSTMyICYmIHZhbHVlID4gTUlOX0kz
Mik7Cj4gLQlyZXMudmFsdWUgPSB2YWx1ZSA8PCBCSVRTX1BFUl9GUkFDVElPTkFMX1BBUlQ7Cj4g
KwlBU1NFUlQodmFsdWUgPCBCV19GSVhFRF9NQVhfSTMyICYmIHZhbHVlID4gQldfRklYRURfTUlO
X0kzMik7Cj4gKwlyZXMudmFsdWUgPSB2YWx1ZSA8PCBCV19GSVhFRF9CSVRTX1BFUl9GUkFDVElP
TkFMX1BBUlQ7Cj4gIAlyZXR1cm4gcmVzOwo+ICB9Cj4gIAo+IC1pbnQzMl90IGJ3X2ZpeGVkX3Rv
X2ludChzdHJ1Y3QgYndfZml4ZWQgdmFsdWUpCj4gLXsKPiAtCXJldHVybiBHRVRfSU5URUdFUl9Q
QVJUKHZhbHVlLnZhbHVlKTsKPiAtfQo+IC0KPiAgc3RydWN0IGJ3X2ZpeGVkIGJ3X2ZyY190b19m
aXhlZChpbnQ2NF90IG51bWVyYXRvciwgaW50NjRfdCBkZW5vbWluYXRvcikKPiAgewo+ICAJc3Ry
dWN0IGJ3X2ZpeGVkIHJlczsKPiBAQCAtODcsMTEgKzcyLDExIEBAIHN0cnVjdCBid19maXhlZCBi
d19mcmNfdG9fZml4ZWQoaW50NjRfdCBudW1lcmF0b3IsIGludDY0X3QgZGVub21pbmF0b3IpCj4g
IAlhcmcyX3ZhbHVlID0gYWJzX2k2NChkZW5vbWluYXRvcik7Cj4gIAlyZXNfdmFsdWUgPSBkaXY2
NF91NjRfcmVtKGFyZzFfdmFsdWUsIGFyZzJfdmFsdWUsICZyZW1haW5kZXIpOwo+ICAKPiAtCUFT
U0VSVChyZXNfdmFsdWUgPD0gTUFYX0kzMik7Cj4gKwlBU1NFUlQocmVzX3ZhbHVlIDw9IEJXX0ZJ
WEVEX01BWF9JMzIpOwo+ICAKPiAgCS8qIGRldGVybWluZSBmcmFjdGlvbmFsIHBhcnQgKi8KPiAg
CXsKPiAtCQl1aW50MzJfdCBpID0gQklUU19QRVJfRlJBQ1RJT05BTF9QQVJUOwo+ICsJCXVpbnQz
Ml90IGkgPSBCV19GSVhFRF9CSVRTX1BFUl9GUkFDVElPTkFMX1BBUlQ7Cj4gIAo+ICAJCWRvCj4g
IAkJewo+IEBAIC0xNjQsOCArMTQ5LDggQEAgc3RydWN0IGJ3X2ZpeGVkIGJ3X211bChjb25zdCBz
dHJ1Y3QgYndfZml4ZWQgYXJnMSwgY29uc3Qgc3RydWN0IGJ3X2ZpeGVkIGFyZzIpCj4gIAl1aW50
NjRfdCBhcmcxX3ZhbHVlID0gYWJzX2k2NChhcmcxLnZhbHVlKTsKPiAgCXVpbnQ2NF90IGFyZzJf
dmFsdWUgPSBhYnNfaTY0KGFyZzIudmFsdWUpOwo+ICAKPiAtCXVpbnQ2NF90IGFyZzFfaW50ID0g
R0VUX0lOVEVHRVJfUEFSVChhcmcxX3ZhbHVlKTsKPiAtCXVpbnQ2NF90IGFyZzJfaW50ID0gR0VU
X0lOVEVHRVJfUEFSVChhcmcyX3ZhbHVlKTsKPiArCXVpbnQ2NF90IGFyZzFfaW50ID0gQldfRklY
RURfR0VUX0lOVEVHRVJfUEFSVChhcmcxX3ZhbHVlKTsKPiArCXVpbnQ2NF90IGFyZzJfaW50ID0g
QldfRklYRURfR0VUX0lOVEVHRVJfUEFSVChhcmcyX3ZhbHVlKTsKPiAgCj4gIAl1aW50NjRfdCBh
cmcxX2ZyYSA9IEdFVF9GUkFDVElPTkFMX1BBUlQoYXJnMV92YWx1ZSk7Cj4gIAl1aW50NjRfdCBh
cmcyX2ZyYSA9IEdFVF9GUkFDVElPTkFMX1BBUlQoYXJnMl92YWx1ZSk7Cj4gQEAgLTE3NCw5ICsx
NTksOSBAQCBzdHJ1Y3QgYndfZml4ZWQgYndfbXVsKGNvbnN0IHN0cnVjdCBid19maXhlZCBhcmcx
LCBjb25zdCBzdHJ1Y3QgYndfZml4ZWQgYXJnMikKPiAgCj4gIAlyZXMudmFsdWUgPSBhcmcxX2lu
dCAqIGFyZzJfaW50Owo+ICAKPiAtCUFTU0VSVChyZXMudmFsdWUgPD0gTUFYX0kzMik7Cj4gKwlB
U1NFUlQocmVzLnZhbHVlIDw9IEJXX0ZJWEVEX01BWF9JMzIpOwo+ICAKPiAtCXJlcy52YWx1ZSA8
PD0gQklUU19QRVJfRlJBQ1RJT05BTF9QQVJUOwo+ICsJcmVzLnZhbHVlIDw8PSBCV19GSVhFRF9C
SVRTX1BFUl9GUkFDVElPTkFMX1BBUlQ7Cj4gIAo+ICAJdG1wID0gYXJnMV9pbnQgKiBhcmcyX2Zy
YTsKPiAgCj4gQEAgLTE5Miw3ICsxNzcsNyBAQCBzdHJ1Y3QgYndfZml4ZWQgYndfbXVsKGNvbnN0
IHN0cnVjdCBid19maXhlZCBhcmcxLCBjb25zdCBzdHJ1Y3QgYndfZml4ZWQgYXJnMikKPiAgCj4g
IAl0bXAgPSBhcmcxX2ZyYSAqIGFyZzJfZnJhOwo+ICAKPiAtCXRtcCA9ICh0bXAgPj4gQklUU19Q
RVJfRlJBQ1RJT05BTF9QQVJUKSArCj4gKwl0bXAgPSAodG1wID4+IEJXX0ZJWEVEX0JJVFNfUEVS
X0ZSQUNUSU9OQUxfUEFSVCkgKwo+ICAJCSh0bXAgPj0gKHVpbnQ2NF90KShid19mcmNfdG9fZml4
ZWQoMSwgMikudmFsdWUpKTsKPiAgCj4gIAlBU1NFUlQodG1wIDw9ICh1aW50NjRfdCkoTUFYX0k2
NCAtIHJlcy52YWx1ZSkpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3Bs
YXkvZGMvaW5jL2J3X2ZpeGVkLmggYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvaW5j
L2J3X2ZpeGVkLmgKPiBpbmRleCA0NDc3ZTYyLi4zOWVlOGViYTMgMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2luYy9id19maXhlZC5oCj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2luYy9id19maXhlZC5oCj4gQEAgLTI2LDEwICsyNiwx
OSBAQAo+ICAjaWZuZGVmIEJXX0ZJWEVEX0hfCj4gICNkZWZpbmUgQldfRklYRURfSF8KPiAgCj4g
KyNkZWZpbmUgQldfRklYRURfQklUU19QRVJfRlJBQ1RJT05BTF9QQVJUIDI0Cj4gKwo+ICsjZGVm
aW5lIEJXX0ZJWEVEX0dFVF9JTlRFR0VSX1BBUlQoeCkgKCh4KSA+PiBCV19GSVhFRF9CSVRTX1BF
Ul9GUkFDVElPTkFMX1BBUlQpCj4gIHN0cnVjdCBid19maXhlZCB7Cj4gIAlpbnQ2NF90IHZhbHVl
Owo+ICB9Owo+ICAKPiArI2RlZmluZSBCV19GSVhFRF9NSU5fSTMyIFwKPiArCShpbnQ2NF90KSgt
KDFMTCA8PCAoNjMgLSBCV19GSVhFRF9CSVRTX1BFUl9GUkFDVElPTkFMX1BBUlQpKSkKPiArCj4g
KyNkZWZpbmUgQldfRklYRURfTUFYX0kzMiBcCj4gKwkoaW50NjRfdCkoKDFVTEwgPDwgKDYzIC0g
QldfRklYRURfQklUU19QRVJfRlJBQ1RJT05BTF9QQVJUKSkgLSAxKQo+ICsKPiAgc3RhdGljIGlu
bGluZSBzdHJ1Y3QgYndfZml4ZWQgYndfbWluMihjb25zdCBzdHJ1Y3QgYndfZml4ZWQgYXJnMSwK
PiAgCQkJCSAgICAgIGNvbnN0IHN0cnVjdCBid19maXhlZCBhcmcyKQo+ICB7Cj4gQEAgLTU2LDkg
KzY1LDIyIEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGJ3X2ZpeGVkIGJ3X21heDMoc3RydWN0IGJ3
X2ZpeGVkIHYxLAo+ICAJcmV0dXJuIGJ3X21heDIoYndfbWF4Mih2MSwgdjIpLCB2Myk7Cj4gIH0K
PiAgCj4gLXN0cnVjdCBid19maXhlZCBid19pbnRfdG9fZml4ZWQoaW50NjRfdCB2YWx1ZSk7Cj4g
K3N0cnVjdCBid19maXhlZCBid19pbnRfdG9fZml4ZWRfbm9uY29uc3QoaW50NjRfdCB2YWx1ZSk7
Cj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IGJ3X2ZpeGVkIGJ3X2ludF90b19maXhlZChpbnQ2NF90
IHZhbHVlKQo+ICt7Cj4gKwlpZiAoX19idWlsdGluX2NvbnN0YW50X3AodmFsdWUpKSB7Cj4gKwkJ
c3RydWN0IGJ3X2ZpeGVkIHJlczsKPiArCQlCVUlMRF9CVUdfT04odmFsdWUgPiBCV19GSVhFRF9N
QVhfSTMyIHx8IHZhbHVlIDwgQldfRklYRURfTUlOX0kzMik7Cj4gKwkJcmVzLnZhbHVlID0gdmFs
dWUgPDwgQldfRklYRURfQklUU19QRVJfRlJBQ1RJT05BTF9QQVJUOwo+ICsJCXJldHVybiByZXM7
Cj4gKwl9IGVsc2UKPiArCQlyZXR1cm4gYndfaW50X3RvX2ZpeGVkX25vbmNvbnN0KHZhbHVlKTsK
PiArfQo+ICAKPiAtaW50MzJfdCBid19maXhlZF90b19pbnQoc3RydWN0IGJ3X2ZpeGVkIHZhbHVl
KTsKPiArc3RhdGljIGlubGluZSBpbnQzMl90IGJ3X2ZpeGVkX3RvX2ludChzdHJ1Y3QgYndfZml4
ZWQgdmFsdWUpCj4gK3sKPiArCXJldHVybiBCV19GSVhFRF9HRVRfSU5URUdFUl9QQVJUKHZhbHVl
LnZhbHVlKTsKPiArfQo+ICAKPiAgc3RydWN0IGJ3X2ZpeGVkIGJ3X2ZyY190b19maXhlZChpbnQ2
NF90IG51bSwgaW50NjRfdCBkZW51bSk7Cj4gIAo+IApfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3Rz
LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp
c3RpbmZvL2FtZC1nZngK