From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:38330 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932846AbdCaIFd (ORCPT ); Fri, 31 Mar 2017 04:05:33 -0400 Subject: Re: [PATCHv5 04/11] exynos_hdmi: add CEC notifier support To: Russell King - ARM Linux References: <20170329141543.32935-1-hverkuil@xs4all.nl> <20170329141543.32935-5-hverkuil@xs4all.nl> <20170330223527.GK7909@n2100.armlinux.org.uk> Cc: linux-media@vger.kernel.org, Daniel Vetter , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Inki Dae , Marek Szyprowski , Javier Martinez Canillas , Benjamin Gaignard , Hans Verkuil From: Hans Verkuil Message-ID: Date: Fri, 31 Mar 2017 10:05:25 +0200 MIME-Version: 1.0 In-Reply-To: <20170330223527.GK7909@n2100.armlinux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 31/03/17 00:35, Russell King - ARM Linux wrote: > On Wed, Mar 29, 2017 at 04:15:36PM +0200, Hans Verkuil wrote: >> + cec_notifier_set_phys_addr(hdata->notifier, >> + cec_get_edid_phys_addr(edid)); > > This pattern causes problems - can we have the notifier taking the EDID > please, and stubs in cec-notifier.h to stub that out? > > Maybe something like cec_notifier_set_phys_addr_from_edid(edid) ? Good point. I've added this, and as an extra bonus this allowed me to drop the first cec-edid patch. > > Having converted the tda998x code over to your new notifier, the 0-day > builder reported this tonight: > >>> ERROR: "cec_get_edid_phys_addr" [drivers/gpu/drm/i2c/tda998x.ko] undefined! > > which is caused exactly by this problem. I can add #ifdefs into the > tda998x driver, but as you're already stubbing out > cec_notifier_set_phys_addr() in cec-notifier.h, it would be stupid to > have to resort to #ifdefs in driver code to solve this issue. Will post a new series today. Thanks for pointing this out. A general note: I am considering merging cec-notifier and cec-edid into the CEC module itself. However, I want to get this series in first before I start moving things around. It's been delayed long enough already. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCHv5 04/11] exynos_hdmi: add CEC notifier support Date: Fri, 31 Mar 2017 10:05:25 +0200 Message-ID: References: <20170329141543.32935-1-hverkuil@xs4all.nl> <20170329141543.32935-5-hverkuil@xs4all.nl> <20170330223527.GK7909@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170330223527.GK7909@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Javier Martinez Canillas , Hans Verkuil , dri-devel@lists.freedesktop.org, Daniel Vetter , Marek Szyprowski , linux-media@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org T24gMzEvMDMvMTcgMDA6MzUsIFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCB3cm90ZToKPiBPbiBX ZWQsIE1hciAyOSwgMjAxNyBhdCAwNDoxNTozNlBNICswMjAwLCBIYW5zIFZlcmt1aWwgd3JvdGU6 Cj4+ICsJY2VjX25vdGlmaWVyX3NldF9waHlzX2FkZHIoaGRhdGEtPm5vdGlmaWVyLAo+PiArCQkJ CSAgIGNlY19nZXRfZWRpZF9waHlzX2FkZHIoZWRpZCkpOwo+IAo+IFRoaXMgcGF0dGVybiBjYXVz ZXMgcHJvYmxlbXMgLSBjYW4gd2UgaGF2ZSB0aGUgbm90aWZpZXIgdGFraW5nIHRoZSBFRElECj4g cGxlYXNlLCBhbmQgc3R1YnMgaW4gY2VjLW5vdGlmaWVyLmggdG8gc3R1YiB0aGF0IG91dD8KPiAK PiBNYXliZSBzb21ldGhpbmcgbGlrZSBjZWNfbm90aWZpZXJfc2V0X3BoeXNfYWRkcl9mcm9tX2Vk aWQoZWRpZCkgPwoKR29vZCBwb2ludC4gSSd2ZSBhZGRlZCB0aGlzLCBhbmQgYXMgYW4gZXh0cmEg Ym9udXMgdGhpcyBhbGxvd2VkIG1lIHRvIGRyb3AKdGhlIGZpcnN0IGNlYy1lZGlkIHBhdGNoLgoK PiAKPiBIYXZpbmcgY29udmVydGVkIHRoZSB0ZGE5OTh4IGNvZGUgb3ZlciB0byB5b3VyIG5ldyBu b3RpZmllciwgdGhlIDAtZGF5Cj4gYnVpbGRlciByZXBvcnRlZCB0aGlzIHRvbmlnaHQ6Cj4gCj4+ PiBFUlJPUjogImNlY19nZXRfZWRpZF9waHlzX2FkZHIiIFtkcml2ZXJzL2dwdS9kcm0vaTJjL3Rk YTk5OHgua29dIHVuZGVmaW5lZCEKPiAKPiB3aGljaCBpcyBjYXVzZWQgZXhhY3RseSBieSB0aGlz IHByb2JsZW0uICBJIGNhbiBhZGQgI2lmZGVmcyBpbnRvIHRoZQo+IHRkYTk5OHggZHJpdmVyLCBi dXQgYXMgeW91J3JlIGFscmVhZHkgc3R1YmJpbmcgb3V0Cj4gY2VjX25vdGlmaWVyX3NldF9waHlz X2FkZHIoKSBpbiBjZWMtbm90aWZpZXIuaCwgaXQgd291bGQgYmUgc3R1cGlkIHRvCj4gaGF2ZSB0 byByZXNvcnQgdG8gI2lmZGVmcyBpbiBkcml2ZXIgY29kZSB0byBzb2x2ZSB0aGlzIGlzc3VlLgoK V2lsbCBwb3N0IGEgbmV3IHNlcmllcyB0b2RheS4gVGhhbmtzIGZvciBwb2ludGluZyB0aGlzIG91 dC4KCkEgZ2VuZXJhbCBub3RlOiBJIGFtIGNvbnNpZGVyaW5nIG1lcmdpbmcgY2VjLW5vdGlmaWVy IGFuZCBjZWMtZWRpZCBpbnRvIHRoZQpDRUMgbW9kdWxlIGl0c2VsZi4gSG93ZXZlciwgSSB3YW50 IHRvIGdldCB0aGlzIHNlcmllcyBpbiBmaXJzdCBiZWZvcmUgSSBzdGFydAptb3ZpbmcgdGhpbmdz IGFyb3VuZC4gSXQncyBiZWVuIGRlbGF5ZWQgbG9uZyBlbm91Z2ggYWxyZWFkeS4KClJlZ2FyZHMs CgoJSGFucwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK