From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Stefan Beller <sbeller@google.com>, marmot1123 <marmot.motoki@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH v2] Fix misconversion of gitsubmodule.txt
Date: Wed, 21 Feb 2018 01:06:38 +0530 [thread overview]
Message-ID: <b4e6f89b-fc20-7244-ad23-548697f9764e@gmail.com> (raw)
In-Reply-To: <CAGZ79kajrwqu2X7BRe8w0W_sa0nosXxspfhbrm0d-ASzxCLn-A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 759 bytes --]
Hi,
On Wednesday 21 February 2018 12:20 AM, Stefan Beller wrote:
> Kaartic was the last to touch that file,
> (as found via git log origin/master -- Documentation/gitsubmodules.txt),
> sorry I did not find this in the review.
>
"Non-ASCII characters" made me dig into to this a little deeper as I
generally don't use them particularly for text files.
"git blame" points at d48034551 (submodules: overhaul documentation,
2017-06-22) as the offending comment.
> Thanks for the patch!
Yeah, nice catch!
--
Kaartic
QUOTE
“It is impossible to live without failing at something, unless you live
so cautiously that you might as well not have lived at all – in which
case, you fail by default.”
- J. K. Rowling
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 870 bytes --]
next prev parent reply other threads:[~2018-02-20 19:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 8:51 [PATCH] Fix misconversion of gitsubmodule.txt marmot1123
2018-02-20 10:02 ` Eric Sunshine
2018-02-20 11:30 ` brian m. carlson
2018-02-20 11:48 ` [PATCH v2] " marmot1123
2018-02-20 18:50 ` Stefan Beller
2018-02-20 19:36 ` Kaartic Sivaraam [this message]
2018-02-20 19:44 ` Stefan Beller
2018-02-20 19:38 ` Todd Zullinger
2018-02-20 20:12 ` Junio C Hamano
2018-02-22 8:52 ` [PATCH v3 1/2] " marmot1123
2018-02-22 8:52 ` [PATCH v3 2/2] Replace non-ASCII apostrophes to ASCII single quotes in gitsubmodules.txt marmot1123
2018-02-22 20:30 ` Junio C Hamano
2018-02-22 18:38 ` [PATCH v3 1/2] Fix misconversion of gitsubmodule.txt Stefan Beller
2018-02-22 20:20 ` Junio C Hamano
2018-02-22 20:36 ` Stefan Beller
2018-02-22 20:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4e6f89b-fc20-7244-ad23-548697f9764e@gmail.com \
--to=kaartic.sivaraam@gmail.com \
--cc=git@vger.kernel.org \
--cc=marmot.motoki@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.