From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4A99C433EF for ; Sat, 23 Apr 2022 20:09:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0FF7E83DA7; Sat, 23 Apr 2022 22:09:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="etwErsb9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0D56683DA7; Sat, 23 Apr 2022 22:08:58 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8920183953 for ; Sat, 23 Apr 2022 22:08:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1650744527; bh=XlHWZ/nGBalmD7E4JfppN+YyWotm+FfT+zRv+CN9qEk=; h=X-UI-Sender-Class:Date:Subject:To:References:Cc:From:In-Reply-To; b=etwErsb9OhbIhOg8J5lsOhpjNG12qCEv2Pr+qVd58PeG9yI6F1fiK4iRUtCwGUjqC NLsCFtsw/0BtaZDm/lasLlK78aCU8/0x1Jk94JkroJd01O8Rbpfd0Hkenn7r1N8P6c a1gEy5WTiDF59fjau2TCa3GNU0UwmAUF+Hq44i6M= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.94] ([88.152.144.107]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MCbIn-1naPyn3w9b-009elK; Sat, 23 Apr 2022 22:08:47 +0200 Message-ID: Date: Sat, 23 Apr 2022 22:08:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 6/7] efi_loader: disk: compile efi_disk when CONFIG_BLK Content-Language: en-US To: AKASHI Takahiro References: <20220419010158.47034-1-takahiro.akashi@linaro.org> <20220419010158.47034-7-takahiro.akashi@linaro.org> <238f2357-34da-eca0-071d-7cec914fabda@gmx.de> <20220421003055.GA7584@laputa> Cc: u-boot@lists.denx.de, trini@konsulko.com, sjg@chromium.org From: Heinrich Schuchardt In-Reply-To: <20220421003055.GA7584@laputa> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Vrn2Z8Biz+bFEdlhnEV7ZfRu/90R2RpFIcqWOJsQzW3/gboto9l Fl4pzIswA8z+HPZUT9BxpVHh6nitD1L7AGOnGPjGVF+qSRu0Sn+2omWFOFFMpzMir0BBAMb hXjug6TTOuCm6FpJntKbPCPigrV1BE5Nbp7U0CHN/U13qICSKBWpHTtbmP14rBwqKy5yCo9 /D0OWPcT0zCspT38eOSIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:AOdkiKG4a74=:EDLI2M93+K8Yvb0RrzfERv ndm684wr/m3i+oVVeJn13e3Fd5MMvtbUjGnlLDhBzFfXzZ7rabQ7l2yoMhDMLE/PYGX355mcC tnyn6F2XEKfKl7th11Ywe+KGr3NaIyG5prAFmK6J+lgdmZMYyBa0QMUyrjnb/Sg7ni3ILwu/B 8QoP5vAVmzaaem5/fO1pMuT65uBsz2zgT+EL3uEvnQoe9aoh+GXgp1x8wHPBJCgivL9IW0SfG 9UvEbfpnAtIPXeebuot6nSY2bgCXvW5nT3LmYUe97M/Cn+pcJNAGZVMYCQlhK4eCQweQNViUI VK2dTBYUIsCzjTumCSwZLNNWB9tLC2/ez+HdfyIoXzQhbtEfZO/uuh4DofhYC9ZTNX13i1Ecx izyEaYuXDgmEytquIWNKd9JC2x2JgsU6Vwv+akiIXZmQw17uLEQcw5ff9S0J+bNwm4uic2tMC 3SZs1hV+AnKHwmyGIRT2UUmiKQ5pFb+2pciXgaRd2brATUYIffwGLZd8KfXFPl532mU4XIC3S MPZEExZVUAxuonBDjGWT9v/9dvHXwGs+bk0bl+6q21avRfgpbhzBDVHCsZyiax+GejO24DEVm Mm8LQw4Papx1ZV8+8Uwy5Ls860zLUWS3QpZP0WF/C3j4XhhADi17Y1MvzwZIwux0Pl+3DVAtF 8gpLOeHc62aYZ/yT3o9+Gub/DtJSEquBM7oTg03GxEnWLFaUh+HLCu5XZFs5/bJQND/tsiECB phZ33OAfSKj9cD2p3EVP6J19IuA37HlcztdZkEYNUtBFFk3GbMp18G7andnOEpcoNleN7LRva rLWIksHs1/t8ODqFutUN8GXMHtiN1lK1Im+62YAfg3HOdYIW9F/vh1N06P0abM1d8wOPwcs3/ +OQD10lAC8RE/bJySrct4tF4ZgXkZza3dNhlnIsDaxxup2vBCMlrGT6ygVR9X/KfjR/CJwP6g DPXrZ69g6UQ/hpPGAAW6OpOReqjsfkIUu0tmj+gZgUyLgGA6h1LmPhzyvIfks3f6Y14M/ruhE 3w15MzvQOdLY+tpBHPsnETD9iK6rC/BstyjreIhLjSwBxviqxWK2JOqOZIMoUXjCr6zqdmCO7 tpU8JtR5jH7gB8= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/21/22 02:30, AKASHI Takahiro wrote: > On Wed, Apr 20, 2022 at 09:42:00AM +0200, Heinrich Schuchardt wrote: >> On 4/19/22 03:01, AKASHI Takahiro wrote: >>> Now we can build efi_loader with block device support (CONFIG_BLK) and >>> without CONFIG_PARTITIONS. >>> So change Makefile. >>> >>> Signed-off-by: AKASHI Takahiro >>> --- >>> lib/efi_loader/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile >>> index 034d26cf0109..aaaa25cefe01 100644 >>> --- a/lib/efi_loader/Makefile >>> +++ b/lib/efi_loader/Makefile >>> @@ -68,7 +68,7 @@ obj-y +=3D efi_watchdog.o >>> obj-$(CONFIG_EFI_ESRT) +=3D efi_esrt.o >>> obj-$(CONFIG_LCD) +=3D efi_gop.o >>> obj-$(CONFIG_DM_VIDEO) +=3D efi_gop.o >>> -obj-$(CONFIG_PARTITIONS) +=3D efi_disk.o >>> +obj-$(CONFIG_BLK) +=3D efi_disk.o >> >> Why do we need efi_disk.o if CONFIG_PARTITIONS=3Dn? > > Why do you think so? > As you admitted in your comment at: > https://lists.denx.de/pipermail/u-boot/2022-April/481546.html > > GPT(EFI_PARTITION) is optional under the current implementation > ("EFI_LOADER should imply EFI_PARTITION" in your words). > As a matter of fact, EFI_LOADER (and efi_disk.o) can be compiled in > even without any partition table types. > > If you don't agree, please drop this patch. > I don't care because it won't help reducing SPL code size anyway. Without this patch db-88f6720_defconfig does not build after applying the rest of the series: arm-linux-gnueabi-ld.bfd: lib/efi_loader/efi_file.o: in function `efi_file_from_path': lib/efi_loader/efi_file.c:1095: undefined reference to `efi_fs_from_path' arm-linux-gnueabi-ld.bfd: lib/efi_loader/efi_var_file.o: in function `efi_set_blk_dev_to_system_partition': lib/efi_loader/efi_var_file.c:54: undefined reference to `efi_system_partition' Best regards Heinrich > > -Takahiro Akashi > >> How can we be UEFI compliant without partition support? >> >> Best regards >> >> Heinrich >> >>> obj-$(CONFIG_NET) +=3D efi_net.o >>> obj-$(CONFIG_GENERATE_ACPI_TABLE) +=3D efi_acpi.o >>> obj-$(CONFIG_GENERATE_SMBIOS_TABLE) +=3D efi_smbios.o >>