Re: [oe] [meta-python][PATCH 2/4] python3-patchelf: New recipe

["Böszörményi Zoltán" <zboszor@gmail.com>]

2023. 03. 15. 15:18 keltezéssel, Zoltan Boszormenyi via lists.openembedded.org írta:
> 2023. 03. 15. 13:42 keltezéssel, Ross Burton írta:
>> On 15 Mar 2023, at 08:04, Zoltan Boszormenyi via lists.openembedded.org 
>> <zboszor=gmail.com@lists.openembedded.org> wrote:
>>> +++ b/meta-python/recipes-devtools/python/python3-patchelf_0.17.2.1.bb
>>> @@ -0,0 +1,31 @@
>>> +# This is a dummy package needed by python3-meson-python
>> I note the words “dummy package”
>
> See the sources of https://pypi.org/project/patchelf/
> There is none, only the build system.
>
> The build system would have just built patchelf, and
> installed into ${bindir} which would conflict with the
> existing patchelf recipe.
>
>>> +DEPENDS = "python3-scikit-build-native"
>> Where is this dependency from?
>
> From its build system.

Actually, it's in mesonpy/__init__.py:

class _depstr:
     """Namespace that holds the requirement strings for dependencies we *might*
     need at runtime. Having them in one place makes it easier to update.
     """
     patchelf = 'patchelf >= 0.11.0'
     ninja = f'ninja >= {_NINJA_REQUIRED_VERSION}'

> The meta build complains.

meson-python uses itself as the build backend to built itself,
so the build really does complain if the patchelf dummy
module is not present. ¯\_(ツ)_/¯

> The scikit-build recipe I previously sent was already merged,
> so it may be used.
>
>>> +PYPI_PACKAGE = "patchelf"
>>> +PYPI_ARCHIVE_NAME_PREFIX = "pypi-"
>>> +
>>> +inherit pypi python_setuptools_build_meta
>> Why is it downloading stuff?
>>
>> Why is any of this needed?  Can’t we just comment out the requirement for patchelf, or 
>> write a proper stub package?
>
> It means less patching in modules depending on this
> particular module, like meson-python.
>
> Do you prefer patching out this dependency from meson-python
> and any other that may depend on it?
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#101562): https://lists.openembedded.org/g/openembedded-devel/message/101562
> Mute This Topic: https://lists.openembedded.org/mt/97622994/3617728
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [zboszor@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>