From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq3vX-0005xV-4U for qemu-devel@nongnu.org; Fri, 30 Sep 2016 15:57:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bq3vR-0004R2-6o for qemu-devel@nongnu.org; Fri, 30 Sep 2016 15:56:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq3vQ-0004Qo-TN for qemu-devel@nongnu.org; Fri, 30 Sep 2016 15:56:53 -0400 References: <1475261386-20211-1-git-send-email-ehabkost@redhat.com> <1475261386-20211-5-git-send-email-ehabkost@redhat.com> From: Eric Blake Message-ID: Date: Fri, 30 Sep 2016 14:56:42 -0500 MIME-Version: 1.0 In-Reply-To: <1475261386-20211-5-git-send-email-ehabkost@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="arb46vThFSGXaCVoHeF663L4xcNdaXcTx" Subject: Re: [Qemu-devel] [libvirt] [PATCH v5 04/12] target-i386: Register aliases for feature names with underscores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: libvir-list@redhat.com, dahi@linux.vnet.ibm.com, Paolo Bonzini , Igor Mammedov , Jiri Denemark , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --arb46vThFSGXaCVoHeF663L4xcNdaXcTx From: Eric Blake To: Eduardo Habkost , qemu-devel@nongnu.org Cc: libvir-list@redhat.com, dahi@linux.vnet.ibm.com, Paolo Bonzini , Igor Mammedov , Jiri Denemark , Richard Henderson Message-ID: Subject: Re: [libvirt] [PATCH v5 04/12] target-i386: Register aliases for feature names with underscores References: <1475261386-20211-1-git-send-email-ehabkost@redhat.com> <1475261386-20211-5-git-send-email-ehabkost@redhat.com> In-Reply-To: <1475261386-20211-5-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/30/2016 01:49 PM, Eduardo Habkost wrote: > Registering the actual names containing underscores as aliases > will allow management software to be aware that the old > compatibility names are suported, and will make feat2prop() calls s/suported/supported/ > unnecessary when using feature names. >=20 > Also, this will help us avoid making the code support underscores > on feature names that never had them in the first place. e.g. > "+tsc_deadline" was never supported and doesn't need to be > translated to "+tsc-deadline". >=20 > In other word: this will require less magic translation of > strings, and simple 1:1 match between the config options and > actual QOM properties. >=20 > Note that the underscores are still present in the > FeatureWordInfo::feat_names arrays, because > add_flagname_to_bitmaps() needs them to be kept. The next patches > will remove add_flagname_to_bitmaps() and will allow us to > finally remove the aliases from feat_names. >=20 > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --arb46vThFSGXaCVoHeF663L4xcNdaXcTx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX7sN6AAoJEKeha0olJ0NqIvgH/jSSdEtUz3jfxaulRMwLkDQE Kak0ZAp9yiQsLmlk938TMIjsISIHUD19GL0DGJKTaKbdbXEm+2MywCiqTL/VB4D9 NH8z8ExJ19DiMtWyRXVUCC/7yVNa10ssY2Wf54Fd9Ay7x/SA9uBp6fsgEO3vXLrF NGmagMlCh4WXhYpccZiTupX/htrR29Y1P9zA1regywRxrFUfYbuFOwDfy99BE+SL NjGTnMGTn71UrJW1LAuz6GhNT/RC6yirfCA0CF1dQNqIBZEgxt7G7pBMD/1Xhkid +nbjJhqqj32aXC2x8e9Bq6Kebz9LSY4Z0jxzjpIVnDY2QKn6UgEgNvip9HYi4Ew= =otDA -----END PGP SIGNATURE----- --arb46vThFSGXaCVoHeF663L4xcNdaXcTx--