All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Mike Snitzer <snitzer@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] use regular gendisk registration in device mapper
Date: Thu, 29 Jul 2021 17:01:37 +0200	[thread overview]
Message-ID: <b51ac16f-bede-15df-ac8c-b219e06f9060@gmail.com> (raw)
In-Reply-To: <20210728112430.GA22101@lst.de>

On 28/07/2021 13:24, Christoph Hellwig wrote:
> On Wed, Jul 28, 2021 at 10:37:41AM +0200, Milan Broz wrote:
>> very specific hw attributes. So you have one emulated device compiled-in?
> 
> Yes.
> 
>> Or there is another way how to configure scsi_debug if compiled-in? (we use module parameters, I think it is
>> the same was how util-linux testsute works with scsi_debug).
> 
> Can can add hosts using the add_host sysfs file.  I thought that was the
> way to go generally, never thought of reloading the module just to
> add/delete hosts.

Heh, I just thought the opposite -that using kernel parameters is the way how to use it :-)

> 
>> (BTW could you send me output of the failed test run? I run it over Linus' tree and ti works so it is perhaps another
>> assumption that should be fixed.)
> 
> Output with everything from the README installed (a lot less failures now):

We cannot run some tests without scsi_debug as module, so I at least added detection for compiled-in scsi_debug
and some module error noise removal. (There is still a lot of operations tested without this.)

For the kernel dependencies:
For cryptsetup project and testsuite is good to have also enabled userspace crypto API interface (CONFIG_CRYPTO_USER)
and keyring (CONFIG_KEYS) but we should be able to run without it.
(The rest is specific crypto algs used in test images, but these are skipped if not available.)

Thanks,
Milan

WARNING: multiple messages have this Message-ID (diff)
From: Milan Broz <gmazyland@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	Mike Snitzer <snitzer@redhat.com>
Subject: Re: [dm-devel] use regular gendisk registration in device mapper
Date: Thu, 29 Jul 2021 17:01:37 +0200	[thread overview]
Message-ID: <b51ac16f-bede-15df-ac8c-b219e06f9060@gmail.com> (raw)
In-Reply-To: <20210728112430.GA22101@lst.de>

On 28/07/2021 13:24, Christoph Hellwig wrote:
> On Wed, Jul 28, 2021 at 10:37:41AM +0200, Milan Broz wrote:
>> very specific hw attributes. So you have one emulated device compiled-in?
> 
> Yes.
> 
>> Or there is another way how to configure scsi_debug if compiled-in? (we use module parameters, I think it is
>> the same was how util-linux testsute works with scsi_debug).
> 
> Can can add hosts using the add_host sysfs file.  I thought that was the
> way to go generally, never thought of reloading the module just to
> add/delete hosts.

Heh, I just thought the opposite -that using kernel parameters is the way how to use it :-)

> 
>> (BTW could you send me output of the failed test run? I run it over Linus' tree and ti works so it is perhaps another
>> assumption that should be fixed.)
> 
> Output with everything from the README installed (a lot less failures now):

We cannot run some tests without scsi_debug as module, so I at least added detection for compiled-in scsi_debug
and some module error noise removal. (There is still a lot of operations tested without this.)

For the kernel dependencies:
For cryptsetup project and testsuite is good to have also enabled userspace crypto API interface (CONFIG_CRYPTO_USER)
and keyring (CONFIG_KEYS) but we should be able to run without it.
(The rest is specific crypto algs used in test images, but these are skipped if not available.)

Thanks,
Milan

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-07-29 15:01 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25  5:54 use regular gendisk registration in device mapper Christoph Hellwig
2021-07-25  5:54 ` [dm-devel] " Christoph Hellwig
2021-07-25  5:54 ` [PATCH 1/8] block: make the block holder code optional Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:25   ` Mike Snitzer
2021-07-29 16:25     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 2/8] block: remove the extra kobject reference in bd_link_disk_holder Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:27   ` Mike Snitzer
2021-07-29 16:27     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 3/8] block: look up holders by bdev Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-25  5:54 ` [PATCH 4/8] block: support delayed holder registration Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-27 16:06   ` Mike Snitzer
2021-07-27 16:06     ` [dm-devel] " Mike Snitzer
2021-07-28  6:54     ` Christoph Hellwig
2021-07-28  6:54       ` [dm-devel] " Christoph Hellwig
2021-07-29 16:32   ` Mike Snitzer
2021-07-29 16:32     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 5/8] dm: cleanup cleanup_mapped_device Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:33   ` Mike Snitzer
2021-07-29 16:33     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 6/8] dm: move setting md->type into dm_setup_md_queue Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:34   ` Mike Snitzer
2021-07-29 16:34     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 7/8] dm: delay registering the gendisk Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:36   ` Mike Snitzer
2021-07-29 16:36     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 8/8] block: remove support for delayed queue registrations Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:37   ` Mike Snitzer
2021-07-29 16:37     ` [dm-devel] " Mike Snitzer
2021-07-27 15:58 ` use regular gendisk registration in device mapper Mike Snitzer
2021-07-27 15:58   ` [dm-devel] " Mike Snitzer
2021-07-27 16:02   ` Christoph Hellwig
2021-07-27 16:02     ` [dm-devel] " Christoph Hellwig
2021-07-27 16:18     ` Mike Snitzer
2021-07-27 16:18       ` [dm-devel] " Mike Snitzer
2021-07-27 20:38       ` Milan Broz
2021-07-27 20:38         ` Milan Broz
2021-07-28  7:06         ` Christoph Hellwig
2021-07-28  7:06           ` Christoph Hellwig
2021-07-28  8:37           ` Milan Broz
2021-07-28  8:37             ` Milan Broz
2021-07-28 11:24             ` Christoph Hellwig
2021-07-28 11:24               ` Christoph Hellwig
2021-07-29 15:01               ` Milan Broz [this message]
2021-07-29 15:01                 ` Milan Broz
2021-07-28 16:17         ` Mike Snitzer
2021-07-28 16:17           ` [dm-devel] " Mike Snitzer
2021-07-29  7:50           ` Milan Broz
2021-07-29  7:50             ` [dm-devel] " Milan Broz
2021-07-27 22:52       ` Mike Snitzer
2021-07-27 22:52         ` [dm-devel] " Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b51ac16f-bede-15df-ac8c-b219e06f9060@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.