Re: [PATCH 2/2] target/arm: Fix compile error.

[Kaige Li <likaige@loongson.cn>]

On 07/30/2020 07:21 PM, Peter Maydell wrote:

> On Thu, 30 Jul 2020 at 12:19, Kaige Li <likaige@loongson.cn> wrote:
>> On 07/30/2020 04:44 PM, Peter Maydell wrote:
>>
>>> On Thu, 30 Jul 2020 at 02:56, Kaige Li <likaige@loongson.cn> wrote:
>>>> When I compile qemu with such as:
>>>>
>>>> git clone https://git.qemu.org/git/qemu.git
>>>> cd qemu
>>>> git submodule init
>>>> git submodule update --recursive
>>>> ./configure
>>>> make
>>>>
>>>> There is error log:
>>>>
>>>> /home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’:
>>>> /home/LiKaige/qemu/target/arm/translate-a64.c:3392:5: error: ‘fn’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>>>        fn(cpu_reg(s, rt), clean_addr, tcg_rs, get_mem_index(s),
>>>>        ^
>>>> /home/LiKaige/qemu/target/arm/translate-a64.c:3318:22: note: ‘fn’ was declared here
>>>>        AtomicThreeOpFn *fn;
>>>>                         ^
>>>> cc1: all warnings being treated as errors
>>>>
>>>> So, add an initiallization value for fn to fix this.
>>>>
>>>> Signed-off-by: Kaige Li <likaige@loongson.cn>
>>> What compiler version is this ?
>> It's the latest version: v5.1.0-rc2, but VERSION shows that is 5.0.92.
>> Commit id is 5772f2b1fc5d00e7e04e01fa28e9081d6550440a
> I asked for the compiler version, not the QEMU version :-)
> Clang, gcc, OSX clang, something else, and which version number?
Sorry for that. Gcc version is 4.9.4.
> -- PMM