From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EEFDC433EF for ; Tue, 16 Nov 2021 14:07:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4430B61B48 for ; Tue, 16 Nov 2021 14:07:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4430B61B48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4023B8392C; Tue, 16 Nov 2021 15:07:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="noh3J2X1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8CECB838F7; Tue, 16 Nov 2021 15:07:50 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B8EAD8392C for ; Tue, 16 Nov 2021 15:07:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id 58F1B1F45714 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1637071666; bh=7n5IXSJHZnXkbW5fbVu4vkF7fYzg7yuun3KZPBVwhms=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=noh3J2X1rXCjXZWTcd5Xdp0G64UODJaIKFhbQGTFgLHTNcR8iZF8zPMeZppswNqIN BoGohPlTxsoPCzmkhuc+HRMTfmRXAYaGSQPaWpy8yofXOeaHdk5fwE8SC4FqGS/VkA f908Pj+OeYAClT2R5yuD+wFyXbWTnRueGTOy8Gsr3PdCtFcseEhTVlamrkRJieajgr GrdEsQa5kfmE/uhnT/NWHfMOs/CQCYnwa/5sl0U66x2MsuG7Ce1J8sjcjcQo5ZmKxw EFEeBEN6PUkRRYr6o1MW1Gg14239QN2w5RVtAzOHcLEPyuLDf2hUytfWCOxTOcvuNc 5noTFGIriZk9g== Subject: Re: [PATCH v3 1/1] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board To: Fabio Estevam Cc: U-Boot-Denx , dl-uboot-imx , Adam Ford , Andre Przywara , ZHIZHIKIN Andrey , Christian Hewitt , Heiko Schocher , Ilko Iliev , Jagan Teki , Marcel Ziswiler , Neil Armstrong , Patrick Delaunay , Peter Robinson , Peng Fan , Rick Chen , Stefano Babic , Sean Anderson , Simon Glass , Teresa Remmet , Tim Harvey , Tom Rini References: <20211116035055.1194673-1-ariel.dalessandro@collabora.com> <20211116035055.1194673-2-ariel.dalessandro@collabora.com> From: Ariel D'Alessandro Message-ID: Date: Tue, 16 Nov 2021 11:07:35 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Fabio, On 11/16/21 8:37 AM, Fabio Estevam wrote: > Hi Ariel, > > The patch looks good. Only some minor comments: > > On Tue, Nov 16, 2021 at 12:51 AM Ariel D'Alessandro > wrote: >> >> Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for: >> >> - 1GiB DDR4 RAM >> - 16 GiB eMMC >> - SD card >> - Gigabit ethernet >> - USBOTG1 peripheral - fastboot >> >> Signed-off-by: Ariel D'Alessandro > > It would be nice to have a README file so that the users can know how > to build and flash mainline > U-Boot in this board. Added that to doc/board/variscite/imx8mn_var_som.rst Will submit in v4. > >> +#define PHYS_SDRAM 0x40000000 >> +#define PHYS_SDRAM_SIZE SZ_1G /* 1GB DDR */ >> + >> +#define CONFIG_BAUDRATE 115200 > > This is the default. No need to be specified here. Ack. > >> +#define CONFIG_MXC_UART_BASE UART4_BASE_ADDR >> + >> +/* Monitor Command Prompt */ >> +#define CONFIG_SYS_CBSIZE SZ_2K >> +#define CONFIG_SYS_MAXARGS 64 >> +#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE >> +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ >> + sizeof(CONFIG_SYS_PROMPT) + 16) >> + >> +/* USDHC */ >> +#define CONFIG_FSL_USDHC > > This should be placed in defconfig. Done. > >> +#define CONFIG_SYS_FSL_USDHC_NUM 2 > > This is not used. Please remove it. Done. Thanks a lot, Ariel