From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAC1C433EF for ; Fri, 8 Jul 2022 03:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236869AbiGHDNx (ORCPT ); Thu, 7 Jul 2022 23:13:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236938AbiGHDNt (ORCPT ); Thu, 7 Jul 2022 23:13:49 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4024C74790 for ; Thu, 7 Jul 2022 20:13:48 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id m14so15293136plg.5 for ; Thu, 07 Jul 2022 20:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TGIKBjKJBY8/kMNlD/sj4PFUQud2Ij5fYjoIm5xQg+k=; b=BZBSm3XKcCB5MlYwxVGxOfvNI6Wlc/jCHNo9MwhscgxXdUh5B+qLRYZoGeZdh0I75n HbLVl5+t8/W/X9dd1nrrb79es2fxskCmaBP5euvE/MoGTXJT7LoTjVFRJjTpzmKjzGU3 e8YEiU4DuRNiGVyL5KknSXccjMGhFMKsjAKcvYmPffvYA/TESbFg1pKVlHlHKQMH+OiQ EWo+Ryn+5OWUbQKobV10qWxULOXY4hIhMjHIKtCf1JJX/ZorXN+IAhe/kXxa+PRjOtH5 ChD9rCa564h/IsGIFizUsDDR1EfpJt+XguL7fP5O2c9Tdy+gzXIKxGBymdooTd/L14rH O4aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TGIKBjKJBY8/kMNlD/sj4PFUQud2Ij5fYjoIm5xQg+k=; b=CuAuaSB2sAC0xY1dLGP9ck+1BL27coEqd7mvhq6LCHgjR5HicKWOMsKL4vFy6kWiDD LNRQv1mC80noeiPo0dDGc/c+H/y21zpEr9WxFg8/9ZKtFRRGVyJX1oLaOTnGD4+zPR99 NDJVwGfJcB7d5QoeKbtRFAEdxWJStL8cGBF6+3pw7P7APJC0pICt11TxfMpdbRwkYyOn T6Cto7ISrd1rsqVL4XPLnMPTxIBlIzVKRRY2pnoBwRvCsB392rmhcMsqpS7FkAYyUolm 6RPhlAvL88NmfQUuoENkXUFkDZ5Hhkv4JXcsLCuHD9JjokfR3BsJ70vbwfn3L2GfaVKO +iWg== X-Gm-Message-State: AJIora+bvxLsPQOWfynfta1LUw0oMmxo61aYGrR318tUdZ0oCQH5cyRM H7b3YdC7PYDFhrediE8G3rqyS+fUpEmBZQ== X-Google-Smtp-Source: AGRyM1vZH/C+rF9c8VLQlyXtH1D98ngJMfORSNnw/Yf7FcQJA7ubNUyXg3Blm2QKYyakOE+Bsy6/Bg== X-Received: by 2002:a17:902:e84f:b0:16b:8a74:d572 with SMTP id t15-20020a170902e84f00b0016b8a74d572mr1478266plg.146.1657250027747; Thu, 07 Jul 2022 20:13:47 -0700 (PDT) Received: from [10.4.255.21] ([139.177.225.235]) by smtp.gmail.com with ESMTPSA id e2-20020a17090ae4c200b001ef8a6836e3sm319394pju.55.2022.07.07.20.13.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 20:13:46 -0700 (PDT) Message-ID: Date: Fri, 8 Jul 2022 11:13:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [RFC PATCH 2/2] arm64: support HAVE_IRQ_EXIT_ON_IRQ_STACK Content-Language: en-US To: Arnd Bergmann Cc: Catalin Marinas , Will Deacon , Linux ARM , Linux Kernel Mailing List References: <20220707110511.52129-1-zhengqi.arch@bytedance.com> <20220707110511.52129-3-zhengqi.arch@bytedance.com> <42bfd82c-b3fb-c942-d6f2-ae5adec90a26@bytedance.com> <33a63e76-fb71-2b9e-3b3c-cc6f7a675cf3@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/8 04:55, Arnd Bergmann wrote: > On Thu, Jul 7, 2022 at 5:00 PM Qi Zheng wrote: >> On 2022/7/7 22:41, Arnd Bergmann wrote: >>> On Thu, Jul 7, 2022 at 3:38 PM Qi Zheng wrote: >>>> On 2022/7/7 20:49, Arnd Bergmann wrote: >>> >>> -asmlinkage void noinstr el1h_64_fiq_handler(struct pt_regs *regs) >>> +asmlinkage void noinstr el1h_64_irq_handler(struct pt_regs *regs) >>> +{ >>> + if (on_thread_stack()) >>> + call_on_irq_stack(regs, el1_irq); >> >> IMO, this can't work. Because el1_interrupt() will invoke >> arm64_preempt_schedule_irq(), which will cause scheduling on the >> IRQ stack. > > Ah, too bad. I spent some more time looking for a simpler approach, > but couldn't find one I'm happy with. One idea might be to have > callback functions for each combinations of irq/fiq with irq/pnmi > to avoid the nested callback pointers. Not sure if that helps. Maybe nested callback pointers are not always a wild beast. ;) This method does not change much, and we can also conveniently stuff all kinds of things in do_handler() that we want to run on the IRQ stack in addition to the handler(). Thanks, Qi > > Arnd -- Thanks, Qi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F8F2C43334 for ; Fri, 8 Jul 2022 03:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2UOWMA0GtWSqiwECA35ghCbM4krbWjVCUDRryyK+8T4=; b=VgjtVTFPrLASZT 4B9vV9mPUM+xurNKNu2gv/MiadUakFaDKENHiSL3/EI3MbN61VqJEl+yFggyxKDtlVbDY/C+h3CD/ y0BlVkVF2xnwdIc61yfmZEZSFCvl4WfF+JwYZRCEK2WE/S67uYJlc4QbicM8VwJGQQYaXBLqV4Tu7 bR/0U4/8Og30ayxYRBcgtZNJp82pDNZPWVWscKWHKLh8PFdAwbVl8sUl7G0hjCYOmY0HoieOCIYjj OAH9v2DJmU+xESAHzvNrbl83s63zHeNlQZnYJ5ihrxMkxatIUA9O4inMQ9/X6Y9+bxVuEpruyBAxq 1roI018kKi33xXvYCEOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9eRF-001VjU-3N; Fri, 08 Jul 2022 03:13:53 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9eRB-001ViM-Uz for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 03:13:51 +0000 Received: by mail-pj1-x102e.google.com with SMTP id y14-20020a17090a644e00b001ef775f7118so674646pjm.2 for ; Thu, 07 Jul 2022 20:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=TGIKBjKJBY8/kMNlD/sj4PFUQud2Ij5fYjoIm5xQg+k=; b=BZBSm3XKcCB5MlYwxVGxOfvNI6Wlc/jCHNo9MwhscgxXdUh5B+qLRYZoGeZdh0I75n HbLVl5+t8/W/X9dd1nrrb79es2fxskCmaBP5euvE/MoGTXJT7LoTjVFRJjTpzmKjzGU3 e8YEiU4DuRNiGVyL5KknSXccjMGhFMKsjAKcvYmPffvYA/TESbFg1pKVlHlHKQMH+OiQ EWo+Ryn+5OWUbQKobV10qWxULOXY4hIhMjHIKtCf1JJX/ZorXN+IAhe/kXxa+PRjOtH5 ChD9rCa564h/IsGIFizUsDDR1EfpJt+XguL7fP5O2c9Tdy+gzXIKxGBymdooTd/L14rH O4aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=TGIKBjKJBY8/kMNlD/sj4PFUQud2Ij5fYjoIm5xQg+k=; b=cX5eKzXuu5NImFE9s/6VzQ5+w2AGtPqu/62U6epR5DmkvB369fmUwzy9VouMUgLXao ViUxAy7EqGG71jjtnfxvCChdpdgdAJK7OBaAYPiR8Kg3sitBScJi/IEjf+Wdo/62aLNj 6/sj729QECI8u6NAyUQobkQOMxmXAUjDCW4Qmz370klewxkdIBuA1OdOu9qKdiOlCFml 3Cnzx1zWv0E1JjU7zt9P8QRh6MNpnzq34ysyBjnWCswA7Z1ZM+zbRuZuuUAXnSuMbWav 7P5mnqfGFlrkQoo4xg2FGHc9UnDAQ2WBdFAUxmef3Rs0bL0j/BTdtM5k2694ynPUgpCV 6UDw== X-Gm-Message-State: AJIora89udIundofRHSALeaXblzyDeEHN8z1XDhc4ps6LR7ysJtcVUH7 e4Qvcjsw4XxSg/r+1IxqkDnYMg== X-Google-Smtp-Source: AGRyM1vZH/C+rF9c8VLQlyXtH1D98ngJMfORSNnw/Yf7FcQJA7ubNUyXg3Blm2QKYyakOE+Bsy6/Bg== X-Received: by 2002:a17:902:e84f:b0:16b:8a74:d572 with SMTP id t15-20020a170902e84f00b0016b8a74d572mr1478266plg.146.1657250027747; Thu, 07 Jul 2022 20:13:47 -0700 (PDT) Received: from [10.4.255.21] ([139.177.225.235]) by smtp.gmail.com with ESMTPSA id e2-20020a17090ae4c200b001ef8a6836e3sm319394pju.55.2022.07.07.20.13.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 20:13:46 -0700 (PDT) Message-ID: Date: Fri, 8 Jul 2022 11:13:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [RFC PATCH 2/2] arm64: support HAVE_IRQ_EXIT_ON_IRQ_STACK Content-Language: en-US To: Arnd Bergmann Cc: Catalin Marinas , Will Deacon , Linux ARM , Linux Kernel Mailing List References: <20220707110511.52129-1-zhengqi.arch@bytedance.com> <20220707110511.52129-3-zhengqi.arch@bytedance.com> <42bfd82c-b3fb-c942-d6f2-ae5adec90a26@bytedance.com> <33a63e76-fb71-2b9e-3b3c-cc6f7a675cf3@bytedance.com> From: Qi Zheng In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220707_201350_267733_446ECA6F X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/7/8 04:55, Arnd Bergmann wrote: > On Thu, Jul 7, 2022 at 5:00 PM Qi Zheng wrote: >> On 2022/7/7 22:41, Arnd Bergmann wrote: >>> On Thu, Jul 7, 2022 at 3:38 PM Qi Zheng wrote: >>>> On 2022/7/7 20:49, Arnd Bergmann wrote: >>> >>> -asmlinkage void noinstr el1h_64_fiq_handler(struct pt_regs *regs) >>> +asmlinkage void noinstr el1h_64_irq_handler(struct pt_regs *regs) >>> +{ >>> + if (on_thread_stack()) >>> + call_on_irq_stack(regs, el1_irq); >> >> IMO, this can't work. Because el1_interrupt() will invoke >> arm64_preempt_schedule_irq(), which will cause scheduling on the >> IRQ stack. > > Ah, too bad. I spent some more time looking for a simpler approach, > but couldn't find one I'm happy with. One idea might be to have > callback functions for each combinations of irq/fiq with irq/pnmi > to avoid the nested callback pointers. Not sure if that helps. Maybe nested callback pointers are not always a wild beast. ;) This method does not change much, and we can also conveniently stuff all kinds of things in do_handler() that we want to run on the IRQ stack in addition to the handler(). Thanks, Qi > > Arnd -- Thanks, Qi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel