From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename()
Date: Mon, 6 Nov 2017 11:04:37 -0600 [thread overview]
Message-ID: <b5564704-1cc2-cad7-de54-105b4a72d085@redhat.com> (raw)
In-Reply-To: <20171106165500.30278-1-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
On 11/06/2017 10:55 AM, Kevin Wolf wrote:
> error_setg_errno() takes a positive errno code.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
Worth mentioning Coverity in the commit message?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-11-06 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 16:55 [Qemu-devel] [PATCH] block: Fix error path in bdrv_backing_update_filename() Kevin Wolf
2017-11-06 17:04 ` Eric Blake [this message]
2017-11-06 20:18 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-11-09 11:24 ` [Qemu-devel] " Stefan Hajnoczi
2017-11-15 19:41 ` Peter Maydell
2017-11-16 11:59 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5564704-1cc2-cad7-de54-105b4a72d085@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.