From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC30DC04FF3 for ; Sat, 22 May 2021 02:45:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40876613AD for ; Sat, 22 May 2021 02:45:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40876613AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 41AE682D57; Sat, 22 May 2021 04:45:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 81FFD82D57; Sat, 22 May 2021 04:45:45 +0200 (CEST) Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.70.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B588882D57 for ; Sat, 22 May 2021 04:45:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=kever.yang@rock-chips.com Received: from localhost (unknown [192.168.167.16]) by regular1.263xmail.com (Postfix) with ESMTP id 21FC81E29; Sat, 22 May 2021 10:45:36 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from [172.16.12.120] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P32529T140357083842304S1621651533478870_; Sat, 22 May 2021 10:45:35 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <9d9ac40f73217f0bc39154cfe7ff2610> X-RL-SENDER: kever.yang@rock-chips.com X-SENDER: yk@rock-chips.com X-LOGIN-NAME: kever.yang@rock-chips.com X-FST-TO: tharvey@gateworks.com X-RCPT-COUNT: 19 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 Subject: Re: [PATCH u-boot v4 29/36] ARM: fix LTO for rockchip and samsung To: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de, Simon Glass , Heiko Schocher , Patrick Delaunay , Patrice CHOTARD , Miquel Raynal , Tom Rini , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Stefan Roese , Heinrich Schuchardt , Alexander Graf , Marek Vasut , Neil Armstrong , Ryder Lee , Adam Ford , Bin Meng , Harald Seiler , Tim Harvey References: <20210520112425.25166-1-marek.behun@nic.cz> <20210520112425.25166-30-marek.behun@nic.cz> From: Kever Yang Message-ID: Date: Sat, 22 May 2021 10:45:32 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210520112425.25166-30-marek.behun@nic.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 2021/5/20 下午7:24, Marek Behún wrote: > When building with LTO, the compiler complains about type mismatch of > function usb_gadget_handle_interrupts(). This function is defined > without parameters in files > arch/arm/mach-rockchip/board.c > board/samsung/common/exynos5-dt.c > but it should have one parameter, int index. > > Fix this. > > Signed-off-by: Marek Behún > Reviewed-by: Bin Meng Reviewed-by: Kever Yang Thanks, - Kever > --- > arch/arm/mach-rockchip/board.c | 2 +- > board/samsung/common/exynos5-dt.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c > index c386b52987..5304eb055c 100644 > --- a/arch/arm/mach-rockchip/board.c > +++ b/arch/arm/mach-rockchip/board.c > @@ -139,7 +139,7 @@ static struct dwc3_device dwc3_device_data = { > .hsphy_mode = USBPHY_INTERFACE_MODE_UTMIW, > }; > > -int usb_gadget_handle_interrupts(void) > +int usb_gadget_handle_interrupts(int index) > { > dwc3_uboot_handle_interrupt(0); > return 0; > diff --git a/board/samsung/common/exynos5-dt.c b/board/samsung/common/exynos5-dt.c > index 4463cdcb87..1318ea716a 100644 > --- a/board/samsung/common/exynos5-dt.c > +++ b/board/samsung/common/exynos5-dt.c > @@ -126,7 +126,7 @@ static struct dwc3_device dwc3_device_data = { > .index = 0, > }; > > -int usb_gadget_handle_interrupts(void) > +int usb_gadget_handle_interrupts(int index) > { > dwc3_uboot_handle_interrupt(0); > return 0;