From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ff11V-0001F2-Ka for qemu-devel@nongnu.org; Mon, 16 Jul 2018 06:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ff11S-0000nI-8T for qemu-devel@nongnu.org; Mon, 16 Jul 2018 06:46:33 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:41315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ff11R-0000mw-Vk for qemu-devel@nongnu.org; Mon, 16 Jul 2018 06:46:30 -0400 Received: by mail-wr1-x434.google.com with SMTP id j5-v6so24856596wrr.8 for ; Mon, 16 Jul 2018 03:46:29 -0700 (PDT) References: <20180716074038.3364-1-yuval.shaia@oracle.com> <20180716074038.3364-11-yuval.shaia@oracle.com> From: Marcel Apfelbaum Message-ID: Date: Mon, 16 Jul 2018 13:46:26 +0300 MIME-Version: 1.0 In-Reply-To: <20180716074038.3364-11-yuval.shaia@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Qemu-devel] [PATCH 10/13] hw/rdma: Cosmetic change - move to generic function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuval Shaia , qemu-devel@nongnu.org On 07/16/2018 10:40 AM, Yuval Shaia wrote: > To ease maintenance of struct comp_thread move all related code to > dedicated function. > > Signed-off-by: Yuval Shaia > --- > hw/rdma/rdma_backend.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c > index 52981d652d..d29acc505b 100644 > --- a/hw/rdma/rdma_backend.c > +++ b/hw/rdma/rdma_backend.c > @@ -146,10 +146,10 @@ static void *comp_handler_thread(void *arg) > return NULL; > } > > -static void stop_comp_thread(RdmaBackendDev *backend_dev) > +static void stop_backend_thread(RdmaBackendThread *thread) > { > - backend_dev->comp_thread.run = false; > - while (backend_dev->comp_thread.is_running) { > + thread->run = false; > + while (thread->is_running) { > pr_dbg("Waiting for thread to complete\n"); > sleep(THR_POLL_TO / SCALE_US / 2); > } > @@ -159,7 +159,7 @@ static void start_comp_thread(RdmaBackendDev *backend_dev) > { > char thread_name[THR_NAME_LEN] = {0}; > > - stop_comp_thread(backend_dev); > + stop_backend_thread(&backend_dev->comp_thread); > > snprintf(thread_name, sizeof(thread_name), "rdma_comp_%s", > ibv_get_device_name(backend_dev->ib_dev)); > @@ -876,7 +876,7 @@ void rdma_backend_start(RdmaBackendDev *backend_dev) > void rdma_backend_stop(RdmaBackendDev *backend_dev) > { > pr_dbg("Stopping rdma_backend\n"); > - stop_comp_thread(backend_dev); > + stop_backend_thread(&backend_dev->comp_thread); > } > > void rdma_backend_fini(RdmaBackendDev *backend_dev) Reviewed-by: Marcel Apfelbaum Thanks, Marcel