pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a corresponding decrement is needed on the error handling path to keep the counter balanced. Fix this by adding the missed function call. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c index a6abb701bfc6..3665a0a2038f 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c @@ -358,6 +358,7 @@ int sun8i_ce_cipher_init(struct crypto_tfm *tfm) return 0; error_pm: + pm_runtime_put_noidle(op->ce->dev); crypto_free_sync_skcipher(op->fallback_tfm); return err; } -- 2.17.1
> Fix this by … Please replace the beginning of this sentence with the tag “Fixes”. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 Regards, Markus
On Mon, Jun 22, 2020 at 07:50:08PM +0200, Markus Elfring wrote:
> > Fix this by …
>
> Please replace the beginning of this sentence with the tag “Fixes”.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
No, not really. The comment you (partially) quoted explains how the
issue is fixed, your suggestion explains what commit introduced the fix
in the first place. They are both beneficial, but there's strictly no
reason to remove the former for the latter.
Maxime
>>> Fix this by …
>>
>> Please replace the beginning of this sentence with the tag “Fixes”.
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
>
> No, not really. The comment you (partially) quoted explains how the
> issue is fixed, your suggestion explains what commit introduced the fix
> in the first place. They are both beneficial, but there's strictly no
> reason to remove the former for the latter.
Do you care to improve this change description another bit?
Regards,
Markus
>>> Fix this by … >> >> Please replace the beginning of this sentence with the tag “Fixes”. >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 > > No, not really. The comment you (partially) quoted explains how the > issue is fixed, your suggestion explains what commit introduced the fix > in the first place. They are both beneficial, but there's strictly no > reason to remove the former for the latter. Do you care to improve this change description another bit? Regards, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Jun 23, 2020 at 05:00:32PM +0200, Markus Elfring wrote:
> >>> Fix this by …
> >>
> >> Please replace the beginning of this sentence with the tag “Fixes”.
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183
> >
> > No, not really. The comment you (partially) quoted explains how the
> > issue is fixed, your suggestion explains what commit introduced the fix
> > in the first place. They are both beneficial, but there's strictly no
> > reason to remove the former for the latter.
>
> Do you care to improve this change description another bit?
I'm not sure which change description you're talking about?
Maxime
On Tue, Jun 23, 2020 at 05:00:32PM +0200, Markus Elfring wrote: > >>> Fix this by … > >> > >> Please replace the beginning of this sentence with the tag “Fixes”. > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 > > > > No, not really. The comment you (partially) quoted explains how the > > issue is fixed, your suggestion explains what commit introduced the fix > > in the first place. They are both beneficial, but there's strictly no > > reason to remove the former for the latter. > > Do you care to improve this change description another bit? I'm not sure which change description you're talking about? Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>>>> Fix this by … >>>> >>>> Please replace the beginning of this sentence with the tag “Fixes”. >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 >>> >>> No, not really. The comment you (partially) quoted explains how the >>> issue is fixed, your suggestion explains what commit introduced the fix >>> in the first place. They are both beneficial, but there's strictly no >>> reason to remove the former for the latter. >> >> Do you care to improve this change description another bit? > > I'm not sure which change description you're talking about? Repetition: https://lore.kernel.org/patchwork/patch/1260551/ https://lore.kernel.org/linux-crypto/20200622024014.11347-1-dinghao.liu@zju.edu.cn/ pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a corresponding decrement is needed on the error handling path to keep the counter balanced. Fix this by adding the missed function call. How do you think about to avoid a wording weakness there (for example) besides other possible adjustments? Regards, Markus
>>>>> Fix this by … >>>> >>>> Please replace the beginning of this sentence with the tag “Fixes”. >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 >>> >>> No, not really. The comment you (partially) quoted explains how the >>> issue is fixed, your suggestion explains what commit introduced the fix >>> in the first place. They are both beneficial, but there's strictly no >>> reason to remove the former for the latter. >> >> Do you care to improve this change description another bit? > > I'm not sure which change description you're talking about? Repetition: https://lore.kernel.org/patchwork/patch/1260551/ https://lore.kernel.org/linux-crypto/20200622024014.11347-1-dinghao.liu@zju.edu.cn/ pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a corresponding decrement is needed on the error handling path to keep the counter balanced. Fix this by adding the missed function call. How do you think about to avoid a wording weakness there (for example) besides other possible adjustments? Regards, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Mon, Jun 22, 2020 at 10:40:08AM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a corresponding decrement is > needed on the error handling path to keep the counter balanced. > > Fix this by adding the missed function call. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Mon, Jun 22, 2020 at 10:40:08AM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a corresponding decrement is > needed on the error handling path to keep the counter balanced. > > Fix this by adding the missed function call. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel