From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B6AC3A5A0 for ; Mon, 20 Apr 2020 12:13:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74834206D6 for ; Mon, 20 Apr 2020 12:13:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="D/SKxKYy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74834206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQVIr-0000yX-Gb; Mon, 20 Apr 2020 12:13:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQVIq-0000yP-5g for xen-devel@lists.xenproject.org; Mon, 20 Apr 2020 12:13:32 +0000 X-Inumbo-ID: 59bd5dda-8300-11ea-9e09-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 59bd5dda-8300-11ea-9e09-bc764e2007e4; Mon, 20 Apr 2020 12:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L9TqMVZQYqMWHi2FhTfEDDZifUufm8YPzvfzEYDISAg=; b=D/SKxKYy1pAYXMH0qsUbgF7zcq piQZ8o2FbcB1cJr4Cq3WcJRRtMKgMW4B/lMqW5Ps/E7AiZyroUeYMcroR8hNEYG7m6EcbkDKpF4fI 6RXNs9oAw6gDuWIvWb2yghLXXbGDYFGyxn753B7UUl8QS7BAZwYCvvOSPyBILzxaoKhU=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jQVIj-0003gw-RP; Mon, 20 Apr 2020 12:13:25 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jQVIj-0000yk-KO; Mon, 20 Apr 2020 12:13:25 +0000 Subject: Re: [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string To: Christian Lindig , "xen-devel@lists.xenproject.org" , David Scott References: <20200330192157.1335-1-julien@xen.org> <67d3370c-779a-7007-e5fa-98d957a85ce9@xen.org> <1587043532025.36720@citrix.com> From: Julien Grall Message-ID: Date: Mon, 20 Apr 2020 13:13:22 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1587043532025.36720@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , George Dunlap , "dfaggioli@suse.com" , Jan Beulich , Ian Jackson , Volodymyr Babchuk , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi Christian, On 16/04/2020 14:25, Christian Lindig wrote: > > The changes in the OCaml C stubs look good to me. They don't really touch the interface but are mostly concerned with types on the C side by adding casts, const, and so on. The extended error handling is an improvement. Thank you for the review! I will commit the rest of the series. As an aside, the acked-by was adding as part of the signature. Not sure whether this is intentional but some e-mail clients are hiding the signature so the acked-by can be easily missed. Cheers, -- Julien Grall