Re: [PATCH 5/5] station: handle EAP_COMPLETE event

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

Hi James,

On 4/8/21 10:46 AM, James Prestwood wrote:
> Notify netdev via netdev_handshake_set_pmk that EAP has finished.
> ---
>   src/station.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/src/station.c b/src/station.c
> index 064872c6..8dda113d 100644
> --- a/src/station.c
> +++ b/src/station.c
> @@ -740,6 +740,10 @@ static void station_handshake_event(struct handshake_state *hs,
>   		l_warn("Unable to securely rekey on this hw/kernel...");
>   		station_reconnect(station);
>   		break;
> +	case HANDSHAKE_EVENT_EAP_COMPLETE:
> +		l_debug("EAP complete");
> +		netdev_handshake_set_pmk(hs);
> +		break;

Why not handle PMK setting just like ptk/gtk/igtk/rekey offload bits?  So maybe 
add __eapol_set_install_pmk_func() and inside the netdev implementation check 
whether the current connection type is OFFLOAD_8021X.  That would cut out 
station as a middle-man completely.

>   	case HANDSHAKE_EVENT_COMPLETE:
>   	case HANDSHAKE_EVENT_SETTING_KEYS_FAILED:
>   	case HANDSHAKE_EVENT_EAP_NOTIFY:
> 

Regards,
-Denis