From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kumar, Mahesh" Subject: Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback Date: Tue, 10 Jul 2018 17:31:38 +0530 Message-ID: References: <20180702110729.8171-1-mahesh1.kumar@intel.com> <20180702110729.8171-3-mahesh1.kumar@intel.com> <16830133.3PzqpUzUj4@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <16830133.3PzqpUzUj4@avalon> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGksCgp0aGFua3MgZm9yIHRoZSByZXZpZXcuCk9uIDcvMTAvMjAxOCA0OjUyIFBNLCBMYXVyZW50 IFBpbmNoYXJ0IHdyb3RlOgo+IEhpIE1haGVzaCwKPgo+IFRoYW5rIHlvdSBmb3IgdGhlIHBhdGNo Lgo+Cj4gT24gTW9uZGF5LCAyIEp1bHkgMjAxOCAxNDowNzoyMSBFRVNUIE1haGVzaCBLdW1hciB3 cm90ZToKPj4gVGhpcyBwYXRjaCBpbnRyb2R1Y2UgYSBjYWxsYmFjayBmdW5jdGlvbiAiZ2V0X2Ny Y19zb3VyY2VzIiB3aGljaAo+PiB3aWxsIGJlIGNhbGxlZCBkdXJpbmcgcmVhZCBvZiBjb250cm9s IG5vZGUuIEl0IGlzIGFuIG9wdGlvbmFsCj4+IGNhbGxiYWNrIGZ1bmN0aW9uIGFuZCBpZiBkcml2 ZXIgaW1wbGVtZW50cyB0aGlzIGNhbGxiYWNrLCBkcml2ZXIKPj4gc2hvdWxkIHByaW50IGxpc3Qg b2YgYXZhaWxhYmxlIENSQyBzb3VyY2VzIGluIHNlcV9maWxlIHByaXZpZGVkCj4+IGFzIGFuIGlu cHV0IHRvIHRoZSBjYWxsYmFjay4KPiBUaGUgY29tbWl0IG1lc3NhZ2Ugc2VlbXMgdG8gYmUgb3V0 ZGF0ZWQsIHRoZSBjYWxsYmFjayBkb2Vzbid0IHRha2UgYSBzZXFfZmlsZQo+IGFueW1vcmUuCm9w cywgd2lsbCB1cGRhdGUuCj4KPj4gQ2hhbmdlcyBTaW5jZSBWMTogKERhbmllbCkKPj4gICAtIHJl dHVybiBjb25zdCBwb2ludGVyIHRvIGFuIGFycmF5IG9mIGNyYyBzb3VyY2VzIGxpc3QKPj4gICAt IGRvIHZhbGlkYXRpb24gb2Ygc291cmNlcyBpbiBDUkMtY29yZQo+Pgo+PiBTaWduZWQtb2ZmLWJ5 OiBNYWhlc2ggS3VtYXIgPG1haGVzaDEua3VtYXJAaW50ZWwuY29tPgo+PiBDYzogZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBSZXZpZXdlZC1ieTogTWFhcnRlbiBMYW5raG9yc3Qg PG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVycy9n cHUvZHJtL2RybV9kZWJ1Z2ZzX2NyYy5jIHwgMjAgKysrKysrKysrKysrKysrKysrKy0KPj4gICBp bmNsdWRlL2RybS9kcm1fY3J0Yy5oICAgICAgICAgICAgfCAxNiArKysrKysrKysrKysrKysrCj4+ ICAgMiBmaWxlcyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+Cj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RlYnVnZnNfY3JjLmMKPj4gYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2RlYnVnZnNfY3JjLmMgaW5kZXggYzZhNzI1Yjc5YWM2Li5mNGQ3NjUy OGQyNGMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMuYwo+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2RlYnVnZnNfY3JjLmMKPj4gQEAgLTY3LDkgKzY3 LDI3IEBACj4+ICAgc3RhdGljIGludCBjcmNfY29udHJvbF9zaG93KHN0cnVjdCBzZXFfZmlsZSAq bSwgdm9pZCAqZGF0YSkKPj4gICB7Cj4+ICAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IG0tPnBy aXZhdGU7Cj4+ICsJc2l6ZV90IGNvdW50Owo+IENvdW50IGl0IG9ubHkgdXNlZCB3aXRoaW4gdGhl IGlmICgpIHt9IGJsb2NrLCB5b3UgY2FuIGRlY2xhcmUgaXQgdGhlcmUuCmFncmVlLgo+Cj4+ICsK Pj4gKwlpZiAoY3J0Yy0+ZnVuY3MtPmdldF9jcmNfc291cmNlcykgewo+PiArCQljb25zdCBjaGFy ICpjb25zdCAqc291cmNlcyA9IGNydGMtPmZ1bmNzLT5nZXRfY3JjX3NvdXJjZXMoY3J0YywKPj4g KwkJCQkJCQkJCSZjb3VudCk7Cj4+ICsJCXNpemVfdCB2YWx1ZXNfY250Owo+PiArCQlpbnQgaTsK PiBJIG9ubHkgdGFrZXMgcG9zaXRpdmUgdmFsdWVzLCBpdCBjYW4gYmUgYW4gdW5zaWduZWQgaW50 Lgpvawo+Cj4+ICsKPj4gKwkJaWYgKGNvdW50IDw9IDAgfHwgIXNvdXJjZXMpCj4gY291bnQgaXMg YSBzaXplX3QsIGl0IGNhbid0IGJlIG5lZ2F0aXZlLgo+Cj4gVGhlIC5nZXRfY3JjX3NvdXJjZXMo KSBkb2N1bWVudGF0aW9uIGRvZXNuJ3QgY2xlYXJseSBzcGVjaWZ5IHdoZXRoZXIgc291cmNlcwo+ IHNob3VsZCBhbHdheXMgYmUgTlVMTCB3aGVuIGNvdW50IGlzIHplcm8uIEkgYWR2aXNlIHVwZGF0 aW5nIHRoZSBkb2N1bWVudGF0aW9uLAo+IGFuZCBwb3NzaWJseSB1cGRhdGluZyB0aGlzIGNoZWNr IGFjY29yZGluZ2x5LgpvayB3aWxsIHVwZGF0ZS4KPgo+PiArCQkJZ290byBvdXQ7Cj4+ICsKPj4g KwkJc2VxX3B1dHMobSwgIlsiKTsKPj4gKwkJZm9yIChpID0gMDsgaSA8IGNvdW50OyBpKyspCj4+ ICsJCQlpZiAoIWNydGMtPmZ1bmNzLT52ZXJpZnlfY3JjX3NvdXJjZShjcnRjLCBzb3VyY2VzW2ld LAo+PiArCQkJCQkJCSAgICAmdmFsdWVzX2NudCkpCj4gSSBhc3N1bWUgdGhhdCB5b3UgdmVyaWZ5 IHNvdXJjZXMgb25lIGJ5IG9uZSBoZXJlIHRvIGF2b2lkIGhhdmluZyB0byBjcmVhdGUgYQo+IGxp c3Qgb2Ygc291cmNlcyBkeW5hbWljYWxseSBpbiB0aGUgLmdldF9jcmNfc291cmNlcygpIGNhbGxi YWNrID8gSWYgc28sIEkKPiB0aGluayB0aGUgLmdldF9jcmNfc291cmNlcygpIGNhbGxiYWNrIHNo b3VsZCBkb2N1bWVudCB0aGF0Lgo+Cj4gWW91IHNob3VsZCBhbHNvIGRvY3VtZW50IHRoYXQgLnZl cmlmeV9jcmNfc291cmNlKCkgaXMgcmVxdWlyZWQgd2hlbgo+IGdldF9jcmNfc291cmNlcygpIGlz IHByb3ZpZGVkLgpvayBzdXJlLgo+Cj4+ICsJCQkJc2VxX3ByaW50ZihtLCAiJXMgIiwgc291cmNl c1tpXSk7Cj4+ICsJCXNlcV9wdXRzKG0sICJdICIpOwo+IFRoaXMgYXNzdW1lcyB0aGF0IHNvdXJj ZSBuYW1lcyBjYW4ndCBpbmNsdWRlIGEgc3BhY2UuIElzbid0IHRoYXQgdG9vCj4gcmVzdHJpY3Rp dmUgPyBTaG91bGRuJ3QgYSBkaWZmZXJlbnQgc2VwYXJhdG9yIGJlIHVzZWQgPyBIb3cgYWJvdXQg b25lIHNvdXJjZQo+IG5hbWUgcGVyIGxpbmUgPwp3aGF0IGFib3V0IGNvbW1hIHNlcGFyYXRlZCBh cyBJJ20gcHV0dGluZyBuYW1lcyBpbnNpZGUgc3F1YXJlLWJyYWNrZXRzPwo+Cj4gQWRkaXRpb25h bGx5LCBzaG91bGRuJ3QgdGhlIGFjdGl2ZSBzb3VyY2UgYmUgbWFya2VkID8KYWN0aXZlIHNvdXJj ZSBpcyBhZ2FpbiBwcmludGVkIGJ5IHRoZSBjb2RlIGluIG5leHQgZmV3IGxpbmVzLiBvdXRwdXQg CndpbGwgYmUgb2YgZm9sbG93aW5nIGZvcm1hdC4KW3NwYWNlIHNlcGFyYXRlZCBsaXN0IG9mIHZh bGlkIHNvdXJjZXNdIGFjdGl2ZV9zb3VyY2UKCi1NYWhlc2gKPgo+PiArCX0KPj4KPj4gK291dDoK Pj4gICAJc2VxX3ByaW50ZihtLCAiJXNcbiIsIGNydGMtPmNyYy5zb3VyY2UpOwo+PiAtCj4+ICAg CXJldHVybiAwOwo+PiAgIH0KPj4KPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRj LmggYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4+IGluZGV4IDFhNmRjYmY5MTc0NC4uZmZhZWMx MzhhZWVlIDEwMDY0NAo+PiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4+ICsrKyBiL2lu Y2x1ZGUvZHJtL2RybV9jcnRjLmgKPj4gQEAgLTY3Niw2ICs2NzYsMjIgQEAgc3RydWN0IGRybV9j cnRjX2Z1bmNzIHsKPj4gICAJICovCj4+ICAgCWludCAoKnZlcmlmeV9jcmNfc291cmNlKShzdHJ1 Y3QgZHJtX2NydGMgKmNydGMsIGNvbnN0IGNoYXIgKnNvdXJjZSwKPj4gICAJCQkJIHNpemVfdCAq dmFsdWVzX2NudCk7Cj4+ICsJLyoqCj4+ICsJICogQGdldF9jcmNfc291cmNlczoKPj4gKwkgKgo+ PiArCSAqIERyaXZlciBjYWxsYmFjayBmb3IgZ2V0dGluZyBhIGxpc3Qgb2YgYWxsIHRoZSBhdmFp bGFibGUgc291cmNlcyBmb3IKPj4gKwkgKiBDUkMgZ2VuZXJhdGlvbi4KPj4gKwkgKgo+PiArCSAq IFRoaXMgY2FsbGJhY2sgaXMgb3B0aW9uYWwgaWYgdGhlIGRyaXZlciBkb2VzIG5vdCBzdXBwb3J0 IGV4cG9ydGluZyBvZgo+PiArCSAqIHBvc3NpYmxlIENSQyBzb3VyY2VzIGxpc3QuIENSQy1jb3Jl IGRvZXMgdGhlIHZlcmlmaWNhdGlvbiBvZiBzb3VyY2VzLgo+PiArCSAqCj4+ICsJICogUkVUVVJO UzoKPj4gKwkgKgo+PiArCSAqIGEgY29uc3RhbnQgY2hhcmFjdGVyIHBvaW50ZXIgdG8gdGhlIGxp c3Qgb2YgYWxsIHRoZSBhdmFpbGFibGUgQ1JDCj4+ICsJICogc291cmNlcwo+PiArCSAqLwo+PiAr CWNvbnN0IGNoYXIgKmNvbnN0ICooKmdldF9jcmNfc291cmNlcykoc3RydWN0IGRybV9jcnRjICpj cnRjLAo+PiArCQkJCQkgICAgICBzaXplX3QgKmNvdW50KTsKPj4KPj4gICAJLyoqCj4+ICAgCSAq IEBhdG9taWNfcHJpbnRfc3RhdGU6CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK