From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 529FDC28CC6 for ; Wed, 5 Jun 2019 10:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BE1820717 for ; Wed, 5 Jun 2019 10:49:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="ZHiWZLHH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727207AbfFEKtj (ORCPT ); Wed, 5 Jun 2019 06:49:39 -0400 Received: from mout.gmx.net ([212.227.15.15]:37749 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727076AbfFEKtj (ORCPT ); Wed, 5 Jun 2019 06:49:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1559731760; bh=v/j4Z2eD2GD0zhfPgdWBU+2pAksyhmUHHesaJHOcPaE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ZHiWZLHHyxs88AT8AMdw01q3xTaXgiAve8Y2VyJolxMQ9Wab/woTcgutxaXQ9rydX R5atdDl5Q6WImQ8mjSTLSGwxSjXd/aLjkT/4EHQslHbc2ksCXeQD9/opLGZBRrNwj+ XD6WOUExB2+WBhkZgM9AFzRx9/zdwVC7eJcc9m2w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.160]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MhhwJ-1hBhZU3L4V-00MtYC; Wed, 05 Jun 2019 12:49:19 +0200 Subject: Re: [PATCH 1/4] clk: bcm2835: remove pllb To: Nicolas Saenz Julienne , Eric Anholt , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com Cc: linux-arm-kernel@lists.infradead.org, ptesarik@suse.com, sboyd@kernel.org, viresh.kumar@linaro.org, mturquette@baylibre.com, linux-pm@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mbrugger@suse.de, ssuloev@orpaltech.com References: <20190604173223.4229-1-nsaenzjulienne@suse.de> <20190604173223.4229-2-nsaenzjulienne@suse.de> From: Stefan Wahren Message-ID: Date: Wed, 5 Jun 2019 12:49:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190604173223.4229-2-nsaenzjulienne@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Provags-ID: V03:K1:q8hji9dsXrh1VvUv+Ij0VE8pGv10bixoURYgbVqiiyW6VNg1c3H uzsDyRSLniYuAR79+VWAGy3LAZ6TxbkjdbMIVBCR72yyzT4LmXgYetMVMzshusahVERQ/G/ GNCzfEdHdKAqyT84AfMp49VTuGtWbw1x0mB0DQoPcPloIN0hzbqOqGDdd8XMcbkA5CVbCYy neVdpYuk6bP2BuD/kpG5g== X-UI-Out-Filterresults: notjunk:1;V03:K0:q/sl8JaOVvU=:XZ0LNFl/HcVox4CcPVZBtn oncvuIZLNyw6OVvwgAaL7yKjeOOTz7+hOcFhhqfbIjCU8tVZhkNatbOZ6IoGgC3AZm4rEAJ8d bYD5v/lXmPk/RLQVdN+FeWIgjyhVupsWYoUdazFjYzygYpToKWUsGI6gGoZHTcqDNGfr4gwYi v+pvRR/FDN1HXD84TtKKlSCsm7T5fVBNPoe/VqwD8wVEEthM6fOi6CTAb/vJ6rltJ7L3jvztK Z7roAs4ZjsfzzqjMIw13xwuQgAzeDG36VuW6tAUpSevh7PCT9pQBM0cgYZjqR1vGOVwDxqB/u vvu0Wvg2sJHSk8l4n3eGpkbL1ZYY78A/+xid7ECTWfnAtyboluVJxB13R1EkRx2C0U8Rfkiii PA7By/H6LdQymoRJIBZMxlTKEN8cPKh4HviYHzPbPwBgsPjovnSQtDPWPsxfy682DcL+96/a2 uOyjlPPU1NtDzvZsbJlthbDqjiAinxLOYZbqLLZJa3OdtSGE2hrT1nWzWgG9cQnwbIXZZ8GY2 hydmKeAO9XfMGyzWRFkuMSicxKlj4SXV5lvkxbGsuck6wg9piexaEmhuUexm5kKzilhd6zkJb gOOSBahC5NcVPemuDSrX28iYaZ7ImBY385Jk3OkoAR+PomvZfrrTcmpNIcUFgU8H/LnypX+fy zYdSK0fIEkJ2wfUWDs4p+YFWq/lV22d+RBu4zskSSx79HaeQmdDp1HtAQ4cUIl/qBpRna7xuV EqbylGUNEJ2Nw+1medUtMH1L4zSI98qJphLTkwBNPOLPylOHekYfVVVDNfIndwL6xHx1l/MRg W0FyCtJF+U7hvMwN7GhBhai60PSpmWH8kG3GmGCoESQwNfbsJoMgXIzlV87MHMCxdo+YbcURp 7F+SLdhWad0CcwOvcdi2ypAi8UM7WszHogSEJB1B++++DPGVV2QVOvze/gm7ppQ3TBg+C0S0M 9+p6cmVLNpSKWeUbUZSDpzOmL5hwTIEka6PeOj9V5t8ShFr7mYD1XYKMMwzpjWh1cJYhiuIvx yw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 04.06.19 um 19:32 schrieb Nicolas Saenz Julienne: > Raspberry Pi's firmware controls this pll, we should use the firmware > interface to access it. > > Signed-off-by: Nicolas Saenz Julienne > --- > drivers/clk/bcm/clk-bcm2835.c | 25 ------------------------- > 1 file changed, 25 deletions(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835= .c > index 770bb01f523e..ccb0319fc2e9 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1651,31 +1651,6 @@ static const struct bcm2835_clk_desc clk_desc_arr= ay[] =3D { > .fixed_divider =3D 1, > .flags =3D CLK_SET_RATE_PARENT), > > - /* PLLB is used for the ARM's clock. */ How about leaving a short comment, that these clocks are now handled by a different driver? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 745BCC28CC6 for ; Wed, 5 Jun 2019 10:49:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EBD320717 for ; Wed, 5 Jun 2019 10:49:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sNMORPju"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="ZHiWZLHH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EBD320717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PlLFmUBBVIrLilRfzg6iTqr9xdOe3HuEsLRL2PDqfz8=; b=sNMORPju/YCOQu H4lOK9sEgFuAGD16O5fa2ynM43e9n9n4okyOPq58YlnNg6uOfQbh/9M7DWfNBvvp8WXPOEMPGJGRA z4PK+mzwpRDJdawbcDPpe01c2hT2Z1e5I69PIOJ/YVGR+zmpBuAQPOtsL7626VTiog/QvYyKTaJfY IfTi/HzTlL4Fi9WZXSZtMktlikZR0kxNCSkBeCigZkGNSIEExeE9TDi9xKZdcEu/o7Zix5BczIgNv XOhK1ZNzNhQk46Cup8JawyncC2Ye7KsZtC1L//rI1pxBvZz8CW09iSQJViboRJFapXIKe6M+8m27i k0zcmYCVw2z5jF3eb4Ng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYTU9-000838-B8; Wed, 05 Jun 2019 10:49:37 +0000 Received: from mout.gmx.net ([212.227.15.15]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYTU5-00082g-O0; Wed, 05 Jun 2019 10:49:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1559731760; bh=v/j4Z2eD2GD0zhfPgdWBU+2pAksyhmUHHesaJHOcPaE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ZHiWZLHHyxs88AT8AMdw01q3xTaXgiAve8Y2VyJolxMQ9Wab/woTcgutxaXQ9rydX R5atdDl5Q6WImQ8mjSTLSGwxSjXd/aLjkT/4EHQslHbc2ksCXeQD9/opLGZBRrNwj+ XD6WOUExB2+WBhkZgM9AFzRx9/zdwVC7eJcc9m2w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.160]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MhhwJ-1hBhZU3L4V-00MtYC; Wed, 05 Jun 2019 12:49:19 +0200 Subject: Re: [PATCH 1/4] clk: bcm2835: remove pllb To: Nicolas Saenz Julienne , Eric Anholt , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com References: <20190604173223.4229-1-nsaenzjulienne@suse.de> <20190604173223.4229-2-nsaenzjulienne@suse.de> From: Stefan Wahren Message-ID: Date: Wed, 5 Jun 2019 12:49:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190604173223.4229-2-nsaenzjulienne@suse.de> Content-Language: en-US X-Provags-ID: V03:K1:q8hji9dsXrh1VvUv+Ij0VE8pGv10bixoURYgbVqiiyW6VNg1c3H uzsDyRSLniYuAR79+VWAGy3LAZ6TxbkjdbMIVBCR72yyzT4LmXgYetMVMzshusahVERQ/G/ GNCzfEdHdKAqyT84AfMp49VTuGtWbw1x0mB0DQoPcPloIN0hzbqOqGDdd8XMcbkA5CVbCYy neVdpYuk6bP2BuD/kpG5g== X-UI-Out-Filterresults: notjunk:1;V03:K0:q/sl8JaOVvU=:XZ0LNFl/HcVox4CcPVZBtn oncvuIZLNyw6OVvwgAaL7yKjeOOTz7+hOcFhhqfbIjCU8tVZhkNatbOZ6IoGgC3AZm4rEAJ8d bYD5v/lXmPk/RLQVdN+FeWIgjyhVupsWYoUdazFjYzygYpToKWUsGI6gGoZHTcqDNGfr4gwYi v+pvRR/FDN1HXD84TtKKlSCsm7T5fVBNPoe/VqwD8wVEEthM6fOi6CTAb/vJ6rltJ7L3jvztK Z7roAs4ZjsfzzqjMIw13xwuQgAzeDG36VuW6tAUpSevh7PCT9pQBM0cgYZjqR1vGOVwDxqB/u vvu0Wvg2sJHSk8l4n3eGpkbL1ZYY78A/+xid7ECTWfnAtyboluVJxB13R1EkRx2C0U8Rfkiii PA7By/H6LdQymoRJIBZMxlTKEN8cPKh4HviYHzPbPwBgsPjovnSQtDPWPsxfy682DcL+96/a2 uOyjlPPU1NtDzvZsbJlthbDqjiAinxLOYZbqLLZJa3OdtSGE2hrT1nWzWgG9cQnwbIXZZ8GY2 hydmKeAO9XfMGyzWRFkuMSicxKlj4SXV5lvkxbGsuck6wg9piexaEmhuUexm5kKzilhd6zkJb gOOSBahC5NcVPemuDSrX28iYaZ7ImBY385Jk3OkoAR+PomvZfrrTcmpNIcUFgU8H/LnypX+fy zYdSK0fIEkJ2wfUWDs4p+YFWq/lV22d+RBu4zskSSx79HaeQmdDp1HtAQ4cUIl/qBpRna7xuV EqbylGUNEJ2Nw+1medUtMH1L4zSI98qJphLTkwBNPOLPylOHekYfVVVDNfIndwL6xHx1l/MRg W0FyCtJF+U7hvMwN7GhBhai60PSpmWH8kG3GmGCoESQwNfbsJoMgXIzlV87MHMCxdo+YbcURp 7F+SLdhWad0CcwOvcdi2ypAi8UM7WszHogSEJB1B++++DPGVV2QVOvze/gm7ppQ3TBg+C0S0M 9+p6cmVLNpSKWeUbUZSDpzOmL5hwTIEka6PeOj9V5t8ShFr7mYD1XYKMMwzpjWh1cJYhiuIvx yw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190605_034934_070465_3BD5919A X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, sboyd@kernel.org, viresh.kumar@linaro.org, mturquette@baylibre.com, ptesarik@suse.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, mbrugger@suse.de, linux-rpi-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ssuloev@orpaltech.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 04.06.19 um 19:32 schrieb Nicolas Saenz Julienne: > Raspberry Pi's firmware controls this pll, we should use the firmware > interface to access it. > > Signed-off-by: Nicolas Saenz Julienne > --- > drivers/clk/bcm/clk-bcm2835.c | 25 ------------------------- > 1 file changed, 25 deletions(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index 770bb01f523e..ccb0319fc2e9 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1651,31 +1651,6 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { > .fixed_divider = 1, > .flags = CLK_SET_RATE_PARENT), > > - /* PLLB is used for the ARM's clock. */ How about leaving a short comment, that these clocks are now handled by a different driver? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel