All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrej Valek <andrej.valek@siemens.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native
Date: Tue, 31 Jul 2018 12:24:26 +0200	[thread overview]
Message-ID: <b5b31110-b182-fc03-e648-bd5d90f025ef@siemens.com> (raw)
In-Reply-To: <b9a00beb06723da9bdd5f32923057d31ccbc0941.camel@linuxfoundation.org>

This program is required for "oe_runmake depend" command. It runs
command in MAKEDEPPROG variable, which is set to makedepend. Makedepend
consists from makedepend-native package.

Cheers,
Andrej

On 07/31/18 12:08, Richard Purdie wrote:
> On Mon, 2018-07-30 at 18:28 -0700, Andre McCurdy wrote:
>> The openssl Configure script will only select standalone makedepend
>> (vs running "$CC -M") when building with gcc < 3.x or with an Apple
>> Xcode version which predates the switch to clang (in approx 2010?).
>> Neither of these cases are possible when building under OE, therefore
>> the dependency on makedepend-native can be dropped (ie align the
>> openssl 1.0 recipe with the 1.1 recipe, which has dropped the
>> makedepend-native dependency already).
>>
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  meta/recipes-connectivity/openssl/openssl_1.0.2o.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb
>> b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb
>> index f5d3274..78c8552 100644
>> --- a/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb
>> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2o.bb
>> @@ -8,7 +8,7 @@ SECTION = "libs/network"
>>  LICENSE = "openssl"
>>  LIC_FILES_CHKSUM =
>> "file://LICENSE;md5=f475368924827d06d4b416111c8bdb77"
>>  
>> -DEPENDS = "makedepend-native hostperl-runtime-native"
>> +DEPENDS = "hostperl-runtime-native"
>>  DEPENDS_append_class-target = " openssl-native"
>>  
>>  PROVIDES += "openssl10"
> 
> This was added quite 'recently' in:
> 
> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=50c23e6c26a64b0c04e99abacb61ec00d1abace9
> 
> I've cc'd Andrej in case he can tell us why that was needed?
> 
> Cheers,
> 
> Richard
> 


  reply	other threads:[~2018-07-31 10:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31  1:28 [PATCH] openssl_1.0: drop unnecessary dependency on makedepend-native Andre McCurdy
2018-07-31 10:08 ` Richard Purdie
2018-07-31 10:24   ` Andrej Valek [this message]
2018-07-31 13:34     ` Andre McCurdy
2018-08-01  7:44       ` Andrej Valek
2018-08-01 21:11         ` Andre McCurdy
2018-08-02  7:54           ` Andrej Valek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5b31110-b182-fc03-e648-bd5d90f025ef@siemens.com \
    --to=andrej.valek@siemens.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.