From: Jiri Slaby <jirislaby@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
llvm@lists.linux.dev, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v2 1/2] linux/types.h: Remove unnecessary __bitwise__
Date: Wed, 25 May 2022 08:51:29 +0200 [thread overview]
Message-ID: <b5c0a68d-8387-4909-beea-f70ab9e6e3d5@kernel.org> (raw)
In-Reply-To: <20220315153048.621328-2-helgaas@kernel.org>
On 15. 03. 22, 16:30, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> There are no users of "__bitwise__" except the definition of "__bitwise".
> Remove __bitwise__ and define __bitwise directly.
>
> This is a follow-up to 05de97003c77 ("linux/types.h: enable endian checks
> for all sparse builds").
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/uapi/linux/types.h | 5 ++---
> tools/include/linux/types.h | 5 ++---
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/include/uapi/linux/types.h b/include/uapi/linux/types.h
> index f6d2f83cbe29..71696f424ac8 100644
> --- a/include/uapi/linux/types.h
> +++ b/include/uapi/linux/types.h
> @@ -20,11 +20,10 @@
> */
>
> #ifdef __CHECKER__
> -#define __bitwise__ __attribute__((bitwise))
> +#define __bitwise __attribute__((bitwise))
> #else
> -#define __bitwise__
> +#define __bitwise
> #endif
> -#define __bitwise __bitwise__
Hi,
this broke userspace, like open-iscsi:
> [ 34s] In file included from session_info.h:9,
> [ 34s] from iscsi_util.c:38:
> [ 34s] ../include/iscsi_proto.h:66:30: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'itt_t'
> [ 34s] 66 | typedef uint32_t __bitwise__ itt_t;
> [ 34s] | ^~~~~
It looks like we need __bitwise__ back.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-05-25 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 15:30 [PATCH v2 0/2] linux/types.h: Tidy __bitwise, add __CHECKER__ hints Bjorn Helgaas
2022-03-15 15:30 ` [PATCH v2 1/2] linux/types.h: Remove unnecessary __bitwise__ Bjorn Helgaas
2022-03-15 17:03 ` Michael S. Tsirkin
2022-05-25 6:51 ` Jiri Slaby [this message]
2022-05-25 14:34 ` Bjorn Helgaas
2022-03-15 15:30 ` [PATCH v2 2/2] Documentation/sparse: Add hints about __CHECKER__ Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5c0a68d-8387-4909-beea-f70ab9e6e3d5@kernel.org \
--to=jirislaby@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mst@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.