From mboxrd@z Thu Jan 1 00:00:00 1970 From: vnkgutta@codeaurora.org Subject: Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs Date: Mon, 10 Sep 2018 15:45:58 -0700 Message-ID: References: <1536103345-1919-1-git-send-email-vnkgutta@codeaurora.org> <1536103345-1919-4-git-send-email-vnkgutta@codeaurora.org> <105f8339-61bc-072e-0498-ed44470a5fb8@codeaurora.org> <5d8f92b480e1b53e7e04da965d44f7ea@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sai Prakash Ranjan Cc: Borislav Petkov , evgreen@chromium.org, robh@kernel.org, mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, tsoni@codeaurora.org, ckadabi@codeaurora.org, rishabhb@codeaurora.org, swboyd@chromium.org, bjorn.andersson@linaro.org List-Id: linux-arm-msm@vger.kernel.org On 2018-09-06 22:02, Sai Prakash Ranjan wrote: > On 9/7/2018 4:01 AM, vnkgutta@codeaurora.org wrote: >> On 2018-09-06 05:38, Sai Prakash Ranjan wrote: >>> On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: >>>> +static const struct of_device_id qcom_llcc_edac_match_table[] = { >>>> +    { .compatible = "qcom,llcc-edac" }, >>>> +    { }, >>>> +}; >>>> + >>>> >>> Hi Venkata, >>> >>> Devicetree binding for llcc is updated, but what about this >>> compatible? >> >> Does it need documentation too? I was not sure if I should add >> documentation for this or not! >> > > It does not require a separate binding, what I meant was to add this > compatible in the llcc binding itself, maybe as a subnode if it is > correct. Hi, We aren't really using this of_device_id structure, as this driver is being registered from LLCC through platform_register_device_data(...). This structure initialization is just dead code as this driver won't be probed based on the DT entries. Hence removing this compatible property and the corresponding struct in the next patchset. So, this doesn't need an extra binding/documentation. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,3/4] drivers: edac: Add EDAC driver support for QCOM SoCs From: Venkata Narendra Kumar Gutta Message-Id: Date: Mon, 10 Sep 2018 15:45:58 -0700 To: Sai Prakash Ranjan Cc: Borislav Petkov , evgreen@chromium.org, robh@kernel.org, mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, tsoni@codeaurora.org, ckadabi@codeaurora.org, rishabhb@codeaurora.org, swboyd@chromium.org, bjorn.andersson@linaro.org List-ID: T24gMjAxOC0wOS0wNiAyMjowMiwgU2FpIFByYWthc2ggUmFuamFuIHdyb3RlOgo+IE9uIDkvNy8y MDE4IDQ6MDEgQU0sIHZua2d1dHRhQGNvZGVhdXJvcmEub3JnIHdyb3RlOgo+PiBPbiAyMDE4LTA5 LTA2IDA1OjM4LCBTYWkgUHJha2FzaCBSYW5qYW4gd3JvdGU6Cj4+PiBPbiA5LzUvMjAxOCA0OjUy IEFNLCBWZW5rYXRhIE5hcmVuZHJhIEt1bWFyIEd1dHRhIHdyb3RlOgo+Pj4+ICtzdGF0aWMgY29u c3Qgc3RydWN0IG9mX2RldmljZV9pZCBxY29tX2xsY2NfZWRhY19tYXRjaF90YWJsZVtdID0gewo+ Pj4+ICvCoMKgwqAgeyAuY29tcGF0aWJsZSA9ICJxY29tLGxsY2MtZWRhYyIgfSwKPj4+PiArwqDC oMKgIHsgfSwKPj4+PiArfTsKPj4+PiArCj4+Pj4gCj4+PiBIaSBWZW5rYXRhLAo+Pj4gCj4+PiBE ZXZpY2V0cmVlIGJpbmRpbmcgZm9yIGxsY2MgaXMgdXBkYXRlZCwgYnV0IHdoYXQgYWJvdXQgdGhp cyAKPj4+IGNvbXBhdGlibGU/Cj4+IAo+PiBEb2VzIGl0IG5lZWQgZG9jdW1lbnRhdGlvbiB0b28/ IEkgd2FzIG5vdCBzdXJlIGlmIEkgc2hvdWxkIGFkZCAKPj4gZG9jdW1lbnRhdGlvbiBmb3IgdGhp cyBvciBub3QhCj4+IAo+IAo+IEl0IGRvZXMgbm90IHJlcXVpcmUgYSBzZXBhcmF0ZSBiaW5kaW5n LCB3aGF0IEkgbWVhbnQgd2FzIHRvIGFkZCB0aGlzCj4gY29tcGF0aWJsZSBpbiB0aGUgbGxjYyBi aW5kaW5nIGl0c2VsZiwgbWF5YmUgYXMgYSBzdWJub2RlIGlmIGl0IGlzCj4gY29ycmVjdC4KCkhp LAoKV2UgYXJlbid0IHJlYWxseSB1c2luZyB0aGlzIG9mX2RldmljZV9pZCBzdHJ1Y3R1cmUsIGFz IHRoaXMgZHJpdmVyIGlzIApiZWluZyByZWdpc3RlcmVkIGZyb20gTExDQyB0aHJvdWdoCnBsYXRm b3JtX3JlZ2lzdGVyX2RldmljZV9kYXRhKC4uLikuIFRoaXMgc3RydWN0dXJlIGluaXRpYWxpemF0 aW9uIGlzIApqdXN0IGRlYWQgY29kZSBhcyB0aGlzIGRyaXZlciB3b24ndCBiZSBwcm9iZWQgYmFz ZWQgb24gdGhlIERUIGVudHJpZXMuCgpIZW5jZSByZW1vdmluZyB0aGlzIGNvbXBhdGlibGUgcHJv cGVydHkgYW5kIHRoZSBjb3JyZXNwb25kaW5nIHN0cnVjdCBpbiAKdGhlIG5leHQgcGF0Y2hzZXQu CgpTbywgdGhpcyBkb2Vzbid0IG5lZWQgYW4gZXh0cmEgYmluZGluZy9kb2N1bWVudGF0aW9uLgo=