From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F2BC2D0E4 for ; Fri, 27 Nov 2020 11:26:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2849C21534 for ; Fri, 27 Nov 2020 11:26:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2849C21534 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kibt9-0005dK-NM for qemu-devel@archiver.kernel.org; Fri, 27 Nov 2020 06:26:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kibpm-00037Y-Pf for qemu-devel@nongnu.org; Fri, 27 Nov 2020 06:22:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:46484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kibpl-00052c-5y for qemu-devel@nongnu.org; Fri, 27 Nov 2020 06:22:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5D251ABD7; Fri, 27 Nov 2020 11:22:35 +0000 (UTC) Subject: Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass From: Claudio Fontana To: Paolo Bonzini , Thomas Huth , Richard Henderson , Stefano Stabellini , Wenchao Wang , Roman Bolshakov , Sunil Muthuswamy , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20201126223218.31480-1-cfontana@suse.de> <20201126223218.31480-11-cfontana@suse.de> <6cbd508c-b24b-3219-3302-196dfefaa8f7@redhat.com> Message-ID: Date: Fri, 27 Nov 2020 12:22:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Eduardo Habkost , Paul Durrant , Jason Wang , Marcelo Tosatti , qemu-devel@nongnu.org, Peter Xu , Dario Faggioli , "Emilio G . Cota" , haxm-team@intel.com, Cameron Esfahani , Anthony Perard , Bruce Rogers , Olaf Hering , Colin Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/27/20 9:59 AM, Claudio Fontana wrote: > On 11/27/20 7:21 AM, Paolo Bonzini wrote: >> On 26/11/20 23:32, Claudio Fontana wrote: >>> + if (acc) { >>> + object_class_foreach(accel_init_cpu_int_aux, cpu_type, false, acc); >>> + } >> >> Any reason to do it for cpu_type only, rather than for all subclasses of >> CPU_RESOLVING_TYPE? This would remove the cpu_type argument to >> accel_init_cpu_interfaces and accel_init_interfaces. >> >> Otherwise I haven't done a careful review yet but it looks very nice, >> thanks! >> >> Paolo >> > > Hi Paolo, > > yes, I thought to pass cpu_type in order to set the interface only for the cpu that is actually used, > instead of looping over all cpu models, just to be a bit quicker, but both things should work. > > Ciao, > > Claudio > Note that this actually creates a bug that is caught _ONLY_ by acceptance-system-centos. The gist of it is that cpu_type (or current_machine->default_cpu_type) is _not_ guaranteed to be set, the code there is a bit misleading I think. I'll look into it, but just wanted to warn early about it. Ciao, Claudio