All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] xenomai: Add config for enabling/disabling SMP
Date: Mon, 10 Apr 2017 15:42:07 +0200	[thread overview]
Message-ID: <b5ddf492-ad58-cdf0-ac7b-5f26799fceb0@mind.be> (raw)
In-Reply-To: <20170410124412.4526-1-sikor6@gmail.com>



On 10-04-17 14:44, Pawel Sikora wrote:
> Add a config option for enabling/disabling SMP
> in Xenomai userspace in version 3.x
> 
> Enabled by default.
> 
> Signed-off-by: Pawel Sikora <sikor6@gmail.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 One small detail: your two patches are conflicting with each other, which makes
life difficult for the maintainers. You should keep them together in a patch
series where they are kept in the correct order.


 Regards,
 Arnout

> ---
> Changes v2 -> v3:
>  - Corrections in help (Arnout V.)
> 
>  package/xenomai/Config.in  | 17 +++++++++++++++++
>  package/xenomai/xenomai.mk |  6 ++++++
>  2 files changed, 23 insertions(+)
> 
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index b548ee810..8bf9c4ae1 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -51,6 +51,23 @@ config BR2_PACKAGE_XENOMAI_VERSION
>  	  BR2_LINUX_KERNEL_EXT_XENOMAI_ADEOS_PATCH, in the Linux
>  	  Kernel -> Linux Kernel Extensions menu.
>  
> +config BR2_PACKAGE_XENOMAI_ENABLE_SMP
> +	bool "Enable SMP"
> +	default y
> +	help
> +	  This option enables SMP support in Xenomai userspace.
> +
> +	  If this option is turned on while no SMP support is enabled
> +	  in the kernel, things will still work. However, if SMP is
> +	  enabled in the kernel but this option is not turned on,
> +	  Xenomai applications will complain with 'feature mismatch:
> +	  missing="smp/nosmp'.
> +
> +	  Please refer to this troubleshooting guide for more
> +	  information:
> +
> +	  http://xenomai.org/troubleshooting-a-dual-kernel-configuration/#feature_mismatch_missing8221smpnosmp8221
> +
>  config BR2_PACKAGE_XENOMAI_TESTSUITE
>  	bool "Install testsuite"
>  	help
> diff --git a/package/xenomai/xenomai.mk b/package/xenomai/xenomai.mk
> index c9e810e05..04880e69a 100644
> --- a/package/xenomai/xenomai.mk
> +++ b/package/xenomai/xenomai.mk
> @@ -23,6 +23,12 @@ XENOMAI_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-user
>  
>  XENOMAI_CONF_OPTS += --includedir=/usr/include/xenomai/ --disable-doc-install
>  
> +ifeq ($(BR2_PACKAGE_XENOMAI_ENABLE_SMP),y)
> +XENOMAI_CONF_OPTS += --enable-smp
> +else
> +XENOMAI_CONF_OPTS += --disable-smp
> +endif
> +
>  define XENOMAI_REMOVE_DEVFILES
>  	for i in xeno-config xeno-info wrap-link.sh ; do \
>  		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

      reply	other threads:[~2017-04-10 13:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 23:46 [Buildroot] [PATCH 1/1] xenomai: Add config for enabling SMP for 3.x Pawel Sikora
2017-04-07 11:22 ` Arnout Vandecappelle
2017-04-09 23:07   ` Pawel Sikora
2017-04-10  9:10     ` Arnout Vandecappelle
2017-04-10  0:17 ` [Buildroot] [PATCH v2] xenomai: Add config for enabling/disabling SMP Pawel Sikora
2017-04-10 11:56   ` Arnout Vandecappelle
2017-04-10 12:46     ` Pawel Sikora
2017-04-10 12:44   ` [Buildroot] [PATCH v3] " Pawel Sikora
2017-04-10 13:42     ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5ddf492-ad58-cdf0-ac7b-5f26799fceb0@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.