From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD321C4320E for ; Thu, 26 Aug 2021 02:45:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB32C61052 for ; Thu, 26 Aug 2021 02:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237521AbhHZCqO (ORCPT ); Wed, 25 Aug 2021 22:46:14 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:14322 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232441AbhHZCqM (ORCPT ); Wed, 25 Aug 2021 22:46:12 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Gw6db6Pf1z89TW; Thu, 26 Aug 2021 10:45:07 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 10:45:23 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 10:45:22 +0800 Subject: Re: [PATCH 3/3] amba: Properly handle device probe without IRQ domain To: Saravana Kannan CC: Rob Herring , "linux-kernel@vger.kernel.org" , Frank Rowand , , Russell King , "Linus Walleij" , linux-arm-kernel , Ruizhe Lin References: <20210816074619.177383-1-wangkefeng.wang@huawei.com> <20210816074619.177383-4-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: Date: Thu, 26 Aug 2021 10:45:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/25 16:04, Saravana Kannan wrote: > On Tue, Aug 24, 2021 at 9:05 PM Kefeng Wang wrote: >> >> On 2021/8/25 4:08, Saravana Kannan wrote: >>> On Tue, Aug 24, 2021 at 1:05 PM Rob Herring wrote: >>>> +Saravana >>>> >>>> Saravana mentioned to me there may be some issues with this one... >>>> >>>> >>>> On Mon, Aug 16, 2021 at 2:43 AM Kefeng Wang wrote: >>>>> of_amba_device_create() uses irq_of_parse_and_map() to translate >>>>> a DT interrupt specification into a Linux virtual interrupt number. >>>>> >>>>> But it doesn't properly handle the case where the interrupt controller >>>>> is not yet available, eg, when pl011 interrupt is connected to MBIGEN >>>>> interrupt controller, because the mbigen initialization is too late, >>>>> which will lead to no IRQ due to no IRQ domain found, log is shown below, >>>>> "irq: no irq domain found for uart0 !" >>>>> >>>>> use of_irq_get() to return -EPROBE_DEFER as above, and in the function >>>>> amba_device_try_add()/amba_device_add(), it will properly handle in such >>>>> case, also return 0 in other fail cases to be consistent as before. >>>>> >>>>> Cc: Russell King >>>>> Cc: Rob Herring >>>>> Cc: Frank Rowand >>>>> Reported-by: Ruizhe Lin >>>>> Signed-off-by: Kefeng Wang >>>>> --- >>>>> drivers/amba/bus.c | 27 +++++++++++++++++++++++++++ >>>>> drivers/of/platform.c | 6 +----- >>>>> 2 files changed, 28 insertions(+), 5 deletions(-) >>>>> >>>>> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c >>>>> index 36f2f42c8014..720aa6cdd402 100644 >>>>> --- a/drivers/amba/bus.c >>>>> +++ b/drivers/amba/bus.c >>>>> @@ -19,6 +19,7 @@ >>>>> #include >>>>> #include >>>>> #include >>>>> +#include >>>>> >>>>> #include >>>>> >>>>> @@ -371,12 +372,38 @@ static void amba_device_release(struct device *dev) >>>>> kfree(d); >>>>> } >>>>> >>>>> +static int of_amba_device_decode_irq(struct amba_device *dev) >>>>> +{ >>>>> + struct device_node *node = dev->dev.of_node; >>>>> + int i, irq = 0; >>>>> + >>>>> + if (IS_ENABLED(CONFIG_OF_IRQ) && node) { >>>>> + /* Decode the IRQs and address ranges */ >>>>> + for (i = 0; i < AMBA_NR_IRQS; i++) { >>>>> + irq = of_irq_get(node, i); >>>>> + if (irq < 0) { >>>>> + if (irq == -EPROBE_DEFER) >>>>> + return irq; >>>>> + irq = 0; >>>>> + } >>>>> + >>>>> + dev->irq[i] = irq; >>>>> + } >>>>> + } >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> static int amba_device_try_add(struct amba_device *dev, struct resource *parent) >>>>> { >>>>> u32 size; >>>>> void __iomem *tmp; >>>>> int i, ret; >>>>> >>>>> + ret = of_amba_device_decode_irq(dev); >>>>> + if (ret) >>>>> + goto err_out; >>>>> + >>> Similar to other resources the AMBA bus "gets" for the device, I think >>> this should be moved into amba_probe() and not here. There's no reason >>> to delay the addition of the device (and loading its module) because >>> the IRQ isn't ready yet. >> The following code in the amba_device_try_add() will be called, it uses irq[0] >> and irq[1], so I put of_amba_device_decode_irq() into amba_device_try_add(). >> >> 470 if (dev->irq[0]) >> 471 ret = device_create_file(&dev->dev, &dev_attr_irq0); >> 472 if (ret == 0 && dev->irq[1]) >> 473 ret = device_create_file(&dev->dev, &dev_attr_irq1); >> 474 if (ret == 0) >> 475 return ret; >> >> of_amba_device_decode_irq() in amba_device_try_add() won't lead to issue, >> only delay the device add, right? > But delaying the device add is the issue. For example, adding a device > could trigger the loading of the corresponding module using uevents. > But now this change would delay that step. That can have other > unintended consequences -- slowing down boot, what if the driver was > working fine without the IRQ, etc. > >> If make it into amba_probe(), the above code should be moved too, could we >> make a new patch to move both of them, or don't move them? > I'd say move them both. If Russell hasn't already picked this up, then > I'd say redo your Patch 3/3. I will resend with put it into amba_probe. > > Btw, I've been working on [1] cleaning up the one-off deferred probe > solution that we have for amba devices. That causes a bunch of other > headaches. Your patch 3/3 takes us further in the wrong direction by > adding more reasons for delaying the addition of the device. Got it,  and I could resend all combine your patch(due to context conflict when changing same function) if you no object. > > -Saravana > > [1] - https://lore.kernel.org/lkml/CAGETcx8b228nDUho3cX9AAQ-pXOfZTMv8cj2vhdx9yc_pk8q+A@mail.gmail.com/ > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA17DC432BE for ; Thu, 26 Aug 2021 02:48:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A2F060EE4 for ; Thu, 26 Aug 2021 02:48:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9A2F060EE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZYHj4Jyp3iQcaxeeNoK5x6GGuitmcw5rZDVRiY3j4eE=; b=4Ia58o5D0A+D708as5O9OlzLHZ u6dz20pmht/qSavSkjwSgZTj2gXsbkViMq6FaQbgtpIxE7fOzl8IWie9Glrru7yNhq0mK5o9+5vbV J5Z+A/IoHSz/mMHJP5iOg43QhsTXfL9p0wH7peI5HWYfvuW0ktyn9PGYz13MCk3MeAiXt9feMwRAL cVOawfmhgs/j1HF4Wcqxu/zYUjhjN/vdcKyLkc8xTdN2t4C/YnQAZIinQ2raEoQpCqjbzb0p4gz+V BNJV+b2RgIHB1QJWxL4Nrc3tz7WbvGYHWR9QN2e7iozDcCilXzcpntz1vvOtlvi860kHK/Q6G1Jtc GcbYHWHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJ5OY-008xIU-FB; Thu, 26 Aug 2021 02:45:34 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJ5OU-008xHj-DY for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 02:45:33 +0000 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Gw6db6Pf1z89TW; Thu, 26 Aug 2021 10:45:07 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 10:45:23 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 26 Aug 2021 10:45:22 +0800 Subject: Re: [PATCH 3/3] amba: Properly handle device probe without IRQ domain To: Saravana Kannan CC: Rob Herring , "linux-kernel@vger.kernel.org" , Frank Rowand , , Russell King , "Linus Walleij" , linux-arm-kernel , Ruizhe Lin References: <20210816074619.177383-1-wangkefeng.wang@huawei.com> <20210816074619.177383-4-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: Date: Thu, 26 Aug 2021 10:45:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_194530_856125_BB0C286A X-CRM114-Status: GOOD ( 33.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjEvOC8yNSAxNjowNCwgU2FyYXZhbmEgS2FubmFuIHdyb3RlOgo+IE9uIFR1ZSwgQXVn IDI0LCAyMDIxIGF0IDk6MDUgUE0gS2VmZW5nIFdhbmcgPHdhbmdrZWZlbmcud2FuZ0BodWF3ZWku Y29tPiB3cm90ZToKPj4KPj4gT24gMjAyMS84LzI1IDQ6MDgsIFNhcmF2YW5hIEthbm5hbiB3cm90 ZToKPj4+IE9uIFR1ZSwgQXVnIDI0LCAyMDIxIGF0IDE6MDUgUE0gUm9iIEhlcnJpbmcgPHJvYmgr ZHRAa2VybmVsLm9yZz4gd3JvdGU6Cj4+Pj4gK1NhcmF2YW5hCj4+Pj4KPj4+PiBTYXJhdmFuYSBt ZW50aW9uZWQgdG8gbWUgdGhlcmUgbWF5IGJlIHNvbWUgaXNzdWVzIHdpdGggdGhpcyBvbmUuLi4K Pj4+Pgo+Pj4+Cj4+Pj4gT24gTW9uLCBBdWcgMTYsIDIwMjEgYXQgMjo0MyBBTSBLZWZlbmcgV2Fu ZyA8d2FuZ2tlZmVuZy53YW5nQGh1YXdlaS5jb20+IHdyb3RlOgo+Pj4+PiBvZl9hbWJhX2Rldmlj ZV9jcmVhdGUoKSB1c2VzIGlycV9vZl9wYXJzZV9hbmRfbWFwKCkgdG8gdHJhbnNsYXRlCj4+Pj4+ IGEgRFQgaW50ZXJydXB0IHNwZWNpZmljYXRpb24gaW50byBhIExpbnV4IHZpcnR1YWwgaW50ZXJy dXB0IG51bWJlci4KPj4+Pj4KPj4+Pj4gQnV0IGl0IGRvZXNuJ3QgcHJvcGVybHkgaGFuZGxlIHRo ZSBjYXNlIHdoZXJlIHRoZSBpbnRlcnJ1cHQgY29udHJvbGxlcgo+Pj4+PiBpcyBub3QgeWV0IGF2 YWlsYWJsZSwgZWcsIHdoZW4gcGwwMTEgaW50ZXJydXB0IGlzIGNvbm5lY3RlZCB0byBNQklHRU4K Pj4+Pj4gaW50ZXJydXB0IGNvbnRyb2xsZXIsIGJlY2F1c2UgdGhlIG1iaWdlbiBpbml0aWFsaXph dGlvbiBpcyB0b28gbGF0ZSwKPj4+Pj4gd2hpY2ggd2lsbCBsZWFkIHRvIG5vIElSUSBkdWUgdG8g bm8gSVJRIGRvbWFpbiBmb3VuZCwgbG9nIGlzIHNob3duIGJlbG93LAo+Pj4+PiAgICAgImlycTog bm8gaXJxIGRvbWFpbiBmb3VuZCBmb3IgdWFydDAgISIKPj4+Pj4KPj4+Pj4gdXNlIG9mX2lycV9n ZXQoKSB0byByZXR1cm4gLUVQUk9CRV9ERUZFUiBhcyBhYm92ZSwgYW5kIGluIHRoZSBmdW5jdGlv bgo+Pj4+PiBhbWJhX2RldmljZV90cnlfYWRkKCkvYW1iYV9kZXZpY2VfYWRkKCksIGl0IHdpbGwg cHJvcGVybHkgaGFuZGxlIGluIHN1Y2gKPj4+Pj4gY2FzZSwgYWxzbyByZXR1cm4gMCBpbiBvdGhl ciBmYWlsIGNhc2VzIHRvIGJlIGNvbnNpc3RlbnQgYXMgYmVmb3JlLgo+Pj4+Pgo+Pj4+PiBDYzog UnVzc2VsbCBLaW5nIDxsaW51eEBhcm1saW51eC5vcmcudWs+Cj4+Pj4+IENjOiBSb2IgSGVycmlu ZyA8cm9iaCtkdEBrZXJuZWwub3JnPgo+Pj4+PiBDYzogRnJhbmsgUm93YW5kIDxmcm93YW5kLmxp c3RAZ21haWwuY29tPgo+Pj4+PiBSZXBvcnRlZC1ieTogUnVpemhlIExpbiA8bGlucnVpemhlQGh1 YXdlaS5jb20+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEtlZmVuZyBXYW5nIDx3YW5na2VmZW5nLndh bmdAaHVhd2VpLmNvbT4KPj4+Pj4gLS0tCj4+Pj4+ICAgIGRyaXZlcnMvYW1iYS9idXMuYyAgICB8 IDI3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKwo+Pj4+PiAgICBkcml2ZXJzL29mL3BsYXRm b3JtLmMgfCAgNiArLS0tLS0KPj4+Pj4gICAgMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25z KCspLCA1IGRlbGV0aW9ucygtKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hbWJh L2J1cy5jIGIvZHJpdmVycy9hbWJhL2J1cy5jCj4+Pj4+IGluZGV4IDM2ZjJmNDJjODAxNC4uNzIw YWE2Y2RkNDAyIDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2FtYmEvYnVzLmMKPj4+Pj4gKysr IGIvZHJpdmVycy9hbWJhL2J1cy5jCj4+Pj4+IEBAIC0xOSw2ICsxOSw3IEBACj4+Pj4+ICAgICNp bmNsdWRlIDxsaW51eC9jbGsvY2xrLWNvbmYuaD4KPj4+Pj4gICAgI2luY2x1ZGUgPGxpbnV4L3Bs YXRmb3JtX2RldmljZS5oPgo+Pj4+PiAgICAjaW5jbHVkZSA8bGludXgvcmVzZXQuaD4KPj4+Pj4g KyNpbmNsdWRlIDxsaW51eC9vZl9pcnEuaD4KPj4+Pj4KPj4+Pj4gICAgI2luY2x1ZGUgPGFzbS9p cnEuaD4KPj4+Pj4KPj4+Pj4gQEAgLTM3MSwxMiArMzcyLDM4IEBAIHN0YXRpYyB2b2lkIGFtYmFf ZGV2aWNlX3JlbGVhc2Uoc3RydWN0IGRldmljZSAqZGV2KQo+Pj4+PiAgICAgICAgICAga2ZyZWUo ZCk7Cj4+Pj4+ICAgIH0KPj4+Pj4KPj4+Pj4gK3N0YXRpYyBpbnQgb2ZfYW1iYV9kZXZpY2VfZGVj b2RlX2lycShzdHJ1Y3QgYW1iYV9kZXZpY2UgKmRldikKPj4+Pj4gK3sKPj4+Pj4gKyAgICAgICBz dHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUgPSBkZXYtPmRldi5vZl9ub2RlOwo+Pj4+PiArICAgICAg IGludCBpLCBpcnEgPSAwOwo+Pj4+PiArCj4+Pj4+ICsgICAgICAgaWYgKElTX0VOQUJMRUQoQ09O RklHX09GX0lSUSkgJiYgbm9kZSkgewo+Pj4+PiArICAgICAgICAgICAgICAgLyogRGVjb2RlIHRo ZSBJUlFzIGFuZCBhZGRyZXNzIHJhbmdlcyAqLwo+Pj4+PiArICAgICAgICAgICAgICAgZm9yIChp ID0gMDsgaSA8IEFNQkFfTlJfSVJRUzsgaSsrKSB7Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIGlycSA9IG9mX2lycV9nZXQobm9kZSwgaSk7Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIGlmIChpcnEgPCAwKSB7Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aWYgKGlycSA9PSAtRVBST0JFX0RFRkVSKQo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmV0dXJuIGlycTsKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpcnEgPSAwOwo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICB9Cj4+Pj4+ICsK Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgZGV2LT5pcnFbaV0gPSBpcnE7Cj4+Pj4+ICsg ICAgICAgICAgICAgICB9Cj4+Pj4+ICsgICAgICAgfQo+Pj4+PiArCj4+Pj4+ICsgICAgICAgcmV0 dXJuIDA7Cj4+Pj4+ICt9Cj4+Pj4+ICsKPj4+Pj4gICAgc3RhdGljIGludCBhbWJhX2RldmljZV90 cnlfYWRkKHN0cnVjdCBhbWJhX2RldmljZSAqZGV2LCBzdHJ1Y3QgcmVzb3VyY2UgKnBhcmVudCkK Pj4+Pj4gICAgewo+Pj4+PiAgICAgICAgICAgdTMyIHNpemU7Cj4+Pj4+ICAgICAgICAgICB2b2lk IF9faW9tZW0gKnRtcDsKPj4+Pj4gICAgICAgICAgIGludCBpLCByZXQ7Cj4+Pj4+Cj4+Pj4+ICsg ICAgICAgcmV0ID0gb2ZfYW1iYV9kZXZpY2VfZGVjb2RlX2lycShkZXYpOwo+Pj4+PiArICAgICAg IGlmIChyZXQpCj4+Pj4+ICsgICAgICAgICAgICAgICBnb3RvIGVycl9vdXQ7Cj4+Pj4+ICsKPj4+ IFNpbWlsYXIgdG8gb3RoZXIgcmVzb3VyY2VzIHRoZSBBTUJBIGJ1cyAiZ2V0cyIgZm9yIHRoZSBk ZXZpY2UsIEkgdGhpbmsKPj4+IHRoaXMgc2hvdWxkIGJlIG1vdmVkIGludG8gYW1iYV9wcm9iZSgp IGFuZCBub3QgaGVyZS4gVGhlcmUncyBubyByZWFzb24KPj4+IHRvIGRlbGF5IHRoZSBhZGRpdGlv biBvZiB0aGUgZGV2aWNlIChhbmQgbG9hZGluZyBpdHMgbW9kdWxlKSBiZWNhdXNlCj4+PiB0aGUg SVJRIGlzbid0IHJlYWR5IHlldC4KPj4gVGhlIGZvbGxvd2luZyBjb2RlIGluIHRoZSBhbWJhX2Rl dmljZV90cnlfYWRkKCkgd2lsbCBiZSBjYWxsZWQsIGl0IHVzZXMgaXJxWzBdCj4+IGFuZCBpcnFb MV0sIHNvIEkgcHV0IG9mX2FtYmFfZGV2aWNlX2RlY29kZV9pcnEoKSBpbnRvIGFtYmFfZGV2aWNl X3RyeV9hZGQoKS4KPj4KPj4gNDcwICAgICAgICAgaWYgKGRldi0+aXJxWzBdKQo+PiA0NzEgICAg ICAgICAgICAgICAgIHJldCA9IGRldmljZV9jcmVhdGVfZmlsZSgmZGV2LT5kZXYsICZkZXZfYXR0 cl9pcnEwKTsKPj4gNDcyICAgICAgICAgaWYgKHJldCA9PSAwICYmIGRldi0+aXJxWzFdKQo+PiA0 NzMgICAgICAgICAgICAgICAgIHJldCA9IGRldmljZV9jcmVhdGVfZmlsZSgmZGV2LT5kZXYsICZk ZXZfYXR0cl9pcnExKTsKPj4gNDc0ICAgICAgICAgaWYgKHJldCA9PSAwKQo+PiA0NzUgICAgICAg ICAgICAgICAgIHJldHVybiByZXQ7Cj4+Cj4+IG9mX2FtYmFfZGV2aWNlX2RlY29kZV9pcnEoKSBp biBhbWJhX2RldmljZV90cnlfYWRkKCkgd29uJ3QgbGVhZCB0byBpc3N1ZSwKPj4gb25seSBkZWxh eSB0aGUgZGV2aWNlIGFkZCwgcmlnaHQ/Cj4gQnV0IGRlbGF5aW5nIHRoZSBkZXZpY2UgYWRkIGlz IHRoZSBpc3N1ZS4gRm9yIGV4YW1wbGUsIGFkZGluZyBhIGRldmljZQo+IGNvdWxkIHRyaWdnZXIg dGhlIGxvYWRpbmcgb2YgdGhlIGNvcnJlc3BvbmRpbmcgbW9kdWxlIHVzaW5nIHVldmVudHMuCj4g QnV0IG5vdyB0aGlzIGNoYW5nZSB3b3VsZCBkZWxheSB0aGF0IHN0ZXAuIFRoYXQgY2FuIGhhdmUg b3RoZXIKPiB1bmludGVuZGVkIGNvbnNlcXVlbmNlcyAtLSBzbG93aW5nIGRvd24gYm9vdCwgd2hh dCBpZiB0aGUgZHJpdmVyIHdhcwo+IHdvcmtpbmcgZmluZSB3aXRob3V0IHRoZSBJUlEsIGV0Yy4K Pgo+PiBJZiBtYWtlIGl0IGludG8gYW1iYV9wcm9iZSgpLCB0aGUgYWJvdmUgY29kZSBzaG91bGQg YmUgbW92ZWQgdG9vLCBjb3VsZCB3ZQo+PiBtYWtlIGEgbmV3IHBhdGNoIHRvIG1vdmUgYm90aCBv ZiB0aGVtLCBvciBkb24ndCBtb3ZlIHRoZW0/Cj4gSSdkIHNheSBtb3ZlIHRoZW0gYm90aC4gSWYg UnVzc2VsbCBoYXNuJ3QgYWxyZWFkeSBwaWNrZWQgdGhpcyB1cCwgdGhlbgo+IEknZCBzYXkgcmVk byB5b3VyIFBhdGNoIDMvMy4KSSB3aWxsIHJlc2VuZCB3aXRoIHB1dCBpdCBpbnRvIGFtYmFfcHJv YmUuCj4KPiBCdHcsIEkndmUgYmVlbiB3b3JraW5nIG9uIFsxXSBjbGVhbmluZyB1cCB0aGUgb25l LW9mZiBkZWZlcnJlZCBwcm9iZQo+IHNvbHV0aW9uIHRoYXQgd2UgaGF2ZSBmb3IgYW1iYSBkZXZp Y2VzLiBUaGF0IGNhdXNlcyBhIGJ1bmNoIG9mIG90aGVyCj4gaGVhZGFjaGVzLiBZb3VyIHBhdGNo IDMvMyB0YWtlcyB1cyBmdXJ0aGVyIGluIHRoZSB3cm9uZyBkaXJlY3Rpb24gYnkKPiBhZGRpbmcg bW9yZSByZWFzb25zIGZvciBkZWxheWluZyB0aGUgYWRkaXRpb24gb2YgdGhlIGRldmljZS4KCkdv dCBpdCzCoCBhbmQgSSBjb3VsZCByZXNlbmQgYWxsIGNvbWJpbmUgeW91ciBwYXRjaChkdWUgdG8g Y29udGV4dCBjb25mbGljdAoKd2hlbiBjaGFuZ2luZyBzYW1lIGZ1bmN0aW9uKSBpZiB5b3Ugbm8g b2JqZWN0LgoKCj4KPiAtU2FyYXZhbmEKPgo+IFsxXSAtIGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L2xrbWwvQ0FHRVRjeDhiMjI4bkRVaG8zY1g5QUFRLXBYT2ZaVE12OGNqMnZoZHg5eWNfcGs4cStB QG1haWwuZ21haWwuY29tLwo+IC4KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=