All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/14] env: Rename env_driver_lookup_default and env_get_default_location
Date: Tue, 28 Nov 2017 11:24:37 +0100	[thread overview]
Message-ID: <b5f21eb17308421d673659a8e74d609777f85b5a.1511864667.git-series.maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <cover.f8d15c19daa14158145260d790deac55f3c66fb3.1511864667.git-series.maxime.ripard@free-electrons.com>

The env_driver_lookup_default and env_get_default_location functions are
about to get refactored to support loading from multiple environment.

The name is therefore not really well suited anymore. Drop the default
part to be a bit more relevant.

Reviewed-by: Lukasz Majewski <lukma@denx.de>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 env/env.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/env/env.c b/env/env.c
index 094538ff5b62..97ada5b5a6fd 100644
--- a/env/env.c
+++ b/env/env.c
@@ -10,7 +10,7 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-static struct env_driver *env_driver_lookup(enum env_location loc)
+static struct env_driver *_env_driver_lookup(enum env_location loc)
 {
 	struct env_driver *drv;
 	const int n_ents = ll_entry_count(struct env_driver, env_driver);
@@ -26,7 +26,7 @@ static struct env_driver *env_driver_lookup(enum env_location loc)
 	return NULL;
 }
 
-static enum env_location env_get_default_location(void)
+static enum env_location env_get_location(void)
 {
 	if IS_ENABLED(CONFIG_ENV_IS_IN_EEPROM)
 		return ENVL_EEPROM;
@@ -52,12 +52,12 @@ static enum env_location env_get_default_location(void)
 		return ENVL_UNKNOWN;
 }
 
-static struct env_driver *env_driver_lookup_default(void)
+static struct env_driver *env_driver_lookup(void)
 {
-	enum env_location loc = env_get_default_location();
+	enum env_location loc = env_get_location();
 	struct env_driver *drv;
 
-	drv = env_driver_lookup(loc);
+	drv = _env_driver_lookup(loc);
 	if (!drv) {
 		debug("%s: No environment driver for location %d\n", __func__,
 		      loc);
@@ -69,7 +69,7 @@ static struct env_driver *env_driver_lookup_default(void)
 
 int env_get_char(int index)
 {
-	struct env_driver *drv = env_driver_lookup_default();
+	struct env_driver *drv = env_driver_lookup();
 	int ret;
 
 	if (gd->env_valid == ENV_INVALID)
@@ -89,7 +89,7 @@ int env_get_char(int index)
 
 int env_load(void)
 {
-	struct env_driver *drv = env_driver_lookup_default();
+	struct env_driver *drv = env_driver_lookup();
 	int ret = 0;
 
 	if (!drv)
@@ -108,7 +108,7 @@ int env_load(void)
 
 int env_save(void)
 {
-	struct env_driver *drv = env_driver_lookup_default();
+	struct env_driver *drv = env_driver_lookup();
 	int ret;
 
 	if (!drv)
@@ -129,7 +129,7 @@ int env_save(void)
 
 int env_init(void)
 {
-	struct env_driver *drv = env_driver_lookup_default();
+	struct env_driver *drv = env_driver_lookup();
 	int ret = -ENOENT;
 
 	if (!drv)
-- 
git-series 0.9.1

  parent reply	other threads:[~2017-11-28 10:24 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 10:24 [U-Boot] [PATCH 00/14] env: Multiple env support and env transition for sunxi Maxime Ripard
2017-11-28 10:24 ` [U-Boot] [PATCH 01/14] cmd: nvedit: Get rid of the env lookup Maxime Ripard
2017-12-05 10:08   ` Andre Przywara
2017-12-29  3:13   ` Simon Glass
2017-11-28 10:24 ` Maxime Ripard [this message]
2017-12-05 10:08   ` [U-Boot] [PATCH 02/14] env: Rename env_driver_lookup_default and env_get_default_location Andre Przywara
2017-12-29  3:13   ` Simon Glass
2017-11-28 10:24 ` [U-Boot] [PATCH 03/14] env: Pass additional parameters to the env lookup function Maxime Ripard
2017-12-05 10:09   ` Andre Przywara
2017-12-08  8:25     ` Maxime Ripard
2017-12-29  3:13   ` Simon Glass
2018-01-05  9:27     ` Maxime Ripard
2017-11-28 10:24 ` [U-Boot] [PATCH 04/14] env: Make the env save message a bit more explicit Maxime Ripard
2017-12-05 10:09   ` Andre Przywara
2017-12-29  3:13   ` Simon Glass
2017-11-28 10:24 ` [U-Boot] [PATCH 05/14] env: Make it explicit where we're loading our environment from Maxime Ripard
2017-12-05 10:09   ` Andre Przywara
2017-12-29  3:13     ` Simon Glass
2017-11-28 10:24 ` [U-Boot] [PATCH 06/14] env: fat: Make the debug messages play a little nicer Maxime Ripard
2017-12-05 10:10   ` Andre Przywara
2017-11-28 10:24 ` [U-Boot] [PATCH 07/14] env: mmc: " Maxime Ripard
2017-12-05 10:10   ` Andre Przywara
2017-11-28 10:24 ` [U-Boot] [PATCH 08/14] env: common: " Maxime Ripard
2017-12-05 10:10   ` Andre Przywara
2017-11-28 10:24 ` [U-Boot] [PATCH 09/14] env: Support multiple environments Maxime Ripard
2017-12-05 10:10   ` Andre Przywara
2017-12-29  3:13   ` Simon Glass
2017-11-28 10:24 ` [U-Boot] [PATCH 10/14] env: Initialise all the environments Maxime Ripard
2017-11-28 12:24   ` Quentin Schulz
2017-11-28 12:29     ` Maxime Ripard
2017-12-05 10:11   ` Andre Przywara
2017-12-29  3:13   ` Simon Glass
2017-11-28 10:24 ` [U-Boot] [PATCH 11/14] env: Allow to build multiple environments in Kconfig Maxime Ripard
2017-12-05 10:11   ` Andre Przywara
2017-12-29  3:13   ` Simon Glass
2017-11-28 10:24 ` [U-Boot] [PATCH 12/14] env: Mark env_get_location as weak Maxime Ripard
2017-12-05 10:14   ` Andre Przywara
2017-12-29  3:13   ` Simon Glass
2018-01-05  9:29     ` Maxime Ripard
2018-01-08  4:52       ` Simon Glass
2018-01-09 13:10         ` Maxime Ripard
2018-01-09 16:05           ` Tom Rini
2018-01-11 15:35             ` Maxime Ripard
2017-11-28 10:24 ` [U-Boot] [PATCH 13/14] sunxi: Transition from the MMC to a FAT-based environment Maxime Ripard
2017-12-05 10:28   ` Andre Przywara
2017-12-08  8:42     ` Maxime Ripard
2017-12-19 13:12     ` [U-Boot] ARM64 Allwinner Binary Size Maxime Ripard
2017-12-19 13:15       ` Tom Rini
2017-12-19 13:26         ` Maxime Ripard
2017-12-19 13:30           ` Tom Rini
2017-12-19 14:09             ` Maxime Ripard
2017-12-19 14:16               ` Emmanuel Vadot
2017-12-19 14:20               ` Tom Rini
2017-12-19 14:22                 ` Andre Przywara
2017-12-19 14:24                   ` Tom Rini
2017-12-19 13:28       ` Alexander Graf
2017-12-19 13:31         ` Tom Rini
2017-12-19 14:13         ` Maxime Ripard
2017-12-19 13:38       ` Andre Przywara
2017-12-19 13:51         ` Mark Kettenis
2017-12-19 14:17           ` Andre Przywara
2017-12-20  9:31             ` Mark Kettenis
2017-12-19 14:20         ` Maxime Ripard
2017-12-19 14:27           ` Andre Przywara
2017-12-19 14:38             ` Jagan Teki
2017-12-19 14:41               ` Chen-Yu Tsai
2017-12-19 14:50                 ` Maxime Ripard
2017-12-19 14:41               ` Andre Przywara
2017-12-19 15:36             ` Maxime Ripard
2017-12-19 15:44               ` Tom Rini
2017-12-19 15:50               ` Jagan Teki
2017-12-20  2:02               ` André Przywara
2017-12-19 13:41       ` Mark Kettenis
2017-12-19 15:24         ` Maxime Ripard
2017-12-19 22:35           ` Mark Kettenis
2017-12-20  1:55           ` André Przywara
2017-12-20  7:15             ` Maxime Ripard
2017-12-20  7:42               ` Mark Kettenis
2017-12-20  9:20                 ` Maxime Ripard
2017-11-28 10:24 ` [U-Boot] [PATCH 14/14] env: sunxi: Enable FAT-based environment support by default Maxime Ripard
2017-12-05 10:30   ` Andre Przywara
2017-12-07 20:09 ` [U-Boot] [PATCH 00/14] env: Multiple env support and env transition for sunxi Tom Rini
2017-12-08  9:05   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5f21eb17308421d673659a8e74d609777f85b5a.1511864667.git-series.maxime.ripard@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.