From: "James Bottomley" <James.Bottomley@HansenPartnership.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: toke@toke.dk,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
users@linux.kernel.org, tools@linux.kernel.org,
Jens Axboe <axboe@kernel.dk>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [kernel.org users] b4: encouraging using the cover letter in merge commits?
Date: Sat, 19 Dec 2020 10:49:21 -0800 [thread overview]
Message-ID: <b6094139488f2b725eb6ef632afa04f349980949.camel@HansenPartnership.com> (raw)
In-Reply-To: <20201219114529.42058976@lwn.net>
On Sat, 2020-12-19 at 11:45 -0700, Jonathan Corbet wrote:
> On Sat, 19 Dec 2020 09:03:36 -0800
> "James Bottomley" <James.Bottomley@HansenPartnership.com> wrote:
>
> > I've got to say that creating a spurious merge for the cover letter
> > looks even more tortuous than creating an empty commit. What
> > advantages does this have over the existing link tag practice which
> > is the one that we now use instead of the empty commit?
>
> I do that too when I have a significant series with information in
> the cover that seems like it should be preserved; it's easy enough to
> do. like the merge commit because it clearly ties the cover letter
> with the series of patches it describes; an empty commit or link tag
> wouldn't do that.
I'm not that keen on justifying a discarded idea. The empty commit was
an original idea for preserving the cover letter which got discarded,
actually way before the link tag. It wouldn't preserve series
information.
However, the link tag does preserve the cover letter and all the series
information, why do you think it doesn't?
James
next prev parent reply other threads:[~2020-12-19 18:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 21:32 b4: encouraging using the cover letter in merge commits? Toke Høiland-Jørgensen
2020-12-18 22:09 ` Konstantin Ryabitsev
2020-12-19 12:29 ` Toke Høiland-Jørgensen
2020-12-18 22:38 ` [kernel.org users] " James Bottomley
2020-12-19 12:34 ` Toke Høiland-Jørgensen
2020-12-19 17:03 ` James Bottomley
2020-12-19 17:21 ` Jakub Kicinski
2020-12-19 17:32 ` James Bottomley
2020-12-21 19:05 ` Jason Gunthorpe
2020-12-21 21:13 ` Michal Kubeček
2020-12-21 21:30 ` Arnaldo Carvalho de Melo
2020-12-22 6:30 ` Leon Romanovsky
2020-12-22 8:14 ` Geert Uytterhoeven
2020-12-22 12:36 ` Leon Romanovsky
2021-01-05 13:38 ` Jason Gunthorpe
2020-12-19 18:45 ` Jonathan Corbet
2020-12-19 18:49 ` James Bottomley [this message]
2020-12-19 18:57 ` Jonathan Corbet
2020-12-19 19:03 ` James Bottomley
2020-12-19 20:48 ` Arnaldo Carvalho de Melo
2020-12-19 21:01 ` James Bottomley
2020-12-19 21:43 ` Arnaldo Carvalho de Melo
2020-12-19 21:57 ` James Bottomley
2020-12-19 22:17 ` Arnaldo Carvalho de Melo
2020-12-19 23:34 ` James Bottomley
2020-12-21 17:34 ` [tools] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6094139488f2b725eb6ef632afa04f349980949.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=acme@kernel.org \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=konstantin@linuxfoundation.org \
--cc=toke@toke.dk \
--cc=tools@linux.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.