From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58049C433EF for ; Mon, 27 Jun 2022 12:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240493AbiF0MWP (ORCPT ); Mon, 27 Jun 2022 08:22:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233276AbiF0MWN (ORCPT ); Mon, 27 Jun 2022 08:22:13 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25298BC22 for ; Mon, 27 Jun 2022 05:22:12 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id e28so7638332wra.0 for ; Mon, 27 Jun 2022 05:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=188VvDq1B6vx6sWxx4ceVbynV0wzhkvfQ94tlUBCWVo=; b=JWWBEC6UjGz31es5Orpifs2fmId+2PFWHpYPGqcUyEflB+3uOZHze9pg4t/TL3Ai4z ZxifaLGz+qaUA8iBaWRvlQptrX59LYqMUl2hPdenEnARk5NKOxdKJFI1EpG8xFJQT3Am dBOxj37Hgb2Z0Wl1inYBLUDvKEs6EkWHd5cXkO3PsfcieGjlEvL1LHOjIhwT3v7Ln9XA cr4qTjqks7uaMc6Val0kFxsl6S61zUT0dNK3b/zCs/yL+9IHVYJIBv9E+o+yegpTtC0b Cw13uLX61yOXRAVMIOnGgak/Vz7p4DI660bTgKvRQBtftZMc0zQhFng+eEI7CXYFA/cr aysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=188VvDq1B6vx6sWxx4ceVbynV0wzhkvfQ94tlUBCWVo=; b=675pXA/F7/HaXy89DKdZO4IvSFt3m3dyeQvgXzqgmd8r7V2Nt1M5Bp/j1f00EYpGfp RsU+k7Fo2yeNiZk9vVVel38v0olKw2WsdULkTQcfhZD4jhhRTKVf7ZGrCxq5UqlZMzGb txwiCsoo4MqF7HYTTIxj/p6M9XE6EkPCMnaAyXI3Det8araJHvLUq+SzZAqib2rOT9l1 fsVjYWWy6Q4RvHFkGTXacHwx8d6JfFbrntv+ymq6r5wdjMhDG43NwmKIQZ60MSmW9PVl U+kDqE/l6irOtvG8qpbYNyKRZAaRZas2ycBJOtMdQhbLIX0xtdIL7oV+Nj5eFiN/l5XK BK3g== X-Gm-Message-State: AJIora/mBt6X5l9zgp3VTNubBcC+TtaMM9dj5fEGNVCBpXY2h3OdwWcF KffZNui2RAscq+SLNQn44FC2OA== X-Google-Smtp-Source: AGRyM1uP9iNE+N88b9RoSyrLps3SkHLc2iB388m4oNY4BNDo4xDy3PzsZEiuqBl66tMHwbxuA1WY5Q== X-Received: by 2002:a05:6000:1147:b0:21b:93db:701a with SMTP id d7-20020a056000114700b0021b93db701amr11721409wrx.447.1656332530591; Mon, 27 Jun 2022 05:22:10 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:6f56:f3c6:ba4f:bf5c? ([2001:861:44c0:66c0:6f56:f3c6:ba4f:bf5c]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c501100b003975c7058bfsm13143413wmr.12.2022.06.27.05.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 05:22:10 -0700 (PDT) Message-ID: Date: Mon, 27 Jun 2022 14:22:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC Content-Language: en-US To: Geert Uytterhoeven , Liu Ying , Andrzej Hajda , Robert Foss , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sakari Ailus , Marek Vasut Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <42c542b53a1c8027b23a045045fbb7b34479913d.1656072500.git.geert+renesas@glider.be> From: Neil Armstrong Organization: Baylibre In-Reply-To: <42c542b53a1c8027b23a045045fbb7b34479913d.1656072500.git.geert+renesas@glider.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 24/06/2022 14:10, Geert Uytterhoeven wrote: > The various Freescale i.MX8 display bridges are only present on > Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent > asking the user about these drivers when configuring a kernel without > i.MX SoC support. > > Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for i.MX8qm") > Fixes: 3818715f62b42b5c ("drm/bridge: imx: Add LDB support for i.MX8qxp") > Fixes: 96988a526c97cfbe ("drm/bridge: imx: Add i.MX8qxp pixel link to DPI support") > Fixes: 1ec17c26bc06289d ("drm/bridge: imx: Add i.MX8qm/qxp display pixel link support") > Fixes: 93e163a9e0392aca ("drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support") > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Liu Ying > --- > v2: > - s/i.MX8MP/i.MX8/, > - Add Reviewed-by. > --- > drivers/gpu/drm/bridge/imx/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig > index 212a7b0e64fd8b5a..608f47f41bcd1c81 100644 > --- a/drivers/gpu/drm/bridge/imx/Kconfig > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > @@ -1,3 +1,5 @@ > +if ARCH_MXC || COMPILE_TEST > + > config DRM_IMX8QM_LDB > tristate "Freescale i.MX8QM LVDS display bridge" > depends on OF > @@ -41,3 +43,5 @@ config DRM_IMX8QXP_PIXEL_LINK_TO_DPI > help > Choose this to enable pixel link to display pixel interface(PXL2DPI) > found in Freescale i.MX8qxp processor. > + > +endif # ARCH_MXC || COMPILE_TEST I was wondering why those were added in drivers/gpu/drm/bridge/imx since they are specific to NXP SoCs, I think they should be moved in the right drm imx subsystem instead of this change. Neil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE64DC43334 for ; Mon, 27 Jun 2022 12:22:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EFC17112084; Mon, 27 Jun 2022 12:22:12 +0000 (UTC) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32204112084 for ; Mon, 27 Jun 2022 12:22:12 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id o16so12825807wra.4 for ; Mon, 27 Jun 2022 05:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=188VvDq1B6vx6sWxx4ceVbynV0wzhkvfQ94tlUBCWVo=; b=JWWBEC6UjGz31es5Orpifs2fmId+2PFWHpYPGqcUyEflB+3uOZHze9pg4t/TL3Ai4z ZxifaLGz+qaUA8iBaWRvlQptrX59LYqMUl2hPdenEnARk5NKOxdKJFI1EpG8xFJQT3Am dBOxj37Hgb2Z0Wl1inYBLUDvKEs6EkWHd5cXkO3PsfcieGjlEvL1LHOjIhwT3v7Ln9XA cr4qTjqks7uaMc6Val0kFxsl6S61zUT0dNK3b/zCs/yL+9IHVYJIBv9E+o+yegpTtC0b Cw13uLX61yOXRAVMIOnGgak/Vz7p4DI660bTgKvRQBtftZMc0zQhFng+eEI7CXYFA/cr aysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=188VvDq1B6vx6sWxx4ceVbynV0wzhkvfQ94tlUBCWVo=; b=SlvpXRcmWZxNaeVOInf7jwwTkKEmYO8ijsD1PBclDR4z/LCPWfUqvZB5EYbh9gNSuW IV80L9WB0qDq0XPF0UBEqxi1wlMLLYydxaYFN/s1Ild6Lq8nGdUVsDI4WQ8hamKDkN5c vwcOV+7jJrDTGERB4lMJYklyxzYgipQjDxOmUfuNeJazSRAZuqZFuQ67GZMdtw8Gch55 Vj5mbpAEFGkjTSwRzPSlSIYPvohkiKQi3QI+Rar4zeDFmVVGwUe2g7zs6rywCGVFvBDD ypCWN/bIYaBK/eUJDsy/aLdyEzNmNXV12d/ObVL4uiXJ1UaLI+qH/TJa/SQpLgwEwATf CTMA== X-Gm-Message-State: AJIora9tkY0e5mvlFR8CMlCGvjCRRIn2y7+Kop7ONUkiOqoOoSjR0zT4 FWnkWBEgXbV422F0Q06PynN21g== X-Google-Smtp-Source: AGRyM1uP9iNE+N88b9RoSyrLps3SkHLc2iB388m4oNY4BNDo4xDy3PzsZEiuqBl66tMHwbxuA1WY5Q== X-Received: by 2002:a05:6000:1147:b0:21b:93db:701a with SMTP id d7-20020a056000114700b0021b93db701amr11721409wrx.447.1656332530591; Mon, 27 Jun 2022 05:22:10 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:6f56:f3c6:ba4f:bf5c? ([2001:861:44c0:66c0:6f56:f3c6:ba4f:bf5c]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c501100b003975c7058bfsm13143413wmr.12.2022.06.27.05.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 05:22:10 -0700 (PDT) Message-ID: Date: Mon, 27 Jun 2022 14:22:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC Content-Language: en-US To: Geert Uytterhoeven , Liu Ying , Andrzej Hajda , Robert Foss , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sakari Ailus , Marek Vasut References: <42c542b53a1c8027b23a045045fbb7b34479913d.1656072500.git.geert+renesas@glider.be> From: Neil Armstrong Organization: Baylibre In-Reply-To: <42c542b53a1c8027b23a045045fbb7b34479913d.1656072500.git.geert+renesas@glider.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 24/06/2022 14:10, Geert Uytterhoeven wrote: > The various Freescale i.MX8 display bridges are only present on > Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent > asking the user about these drivers when configuring a kernel without > i.MX SoC support. > > Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for i.MX8qm") > Fixes: 3818715f62b42b5c ("drm/bridge: imx: Add LDB support for i.MX8qxp") > Fixes: 96988a526c97cfbe ("drm/bridge: imx: Add i.MX8qxp pixel link to DPI support") > Fixes: 1ec17c26bc06289d ("drm/bridge: imx: Add i.MX8qm/qxp display pixel link support") > Fixes: 93e163a9e0392aca ("drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support") > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Liu Ying > --- > v2: > - s/i.MX8MP/i.MX8/, > - Add Reviewed-by. > --- > drivers/gpu/drm/bridge/imx/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig > index 212a7b0e64fd8b5a..608f47f41bcd1c81 100644 > --- a/drivers/gpu/drm/bridge/imx/Kconfig > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > @@ -1,3 +1,5 @@ > +if ARCH_MXC || COMPILE_TEST > + > config DRM_IMX8QM_LDB > tristate "Freescale i.MX8QM LVDS display bridge" > depends on OF > @@ -41,3 +43,5 @@ config DRM_IMX8QXP_PIXEL_LINK_TO_DPI > help > Choose this to enable pixel link to display pixel interface(PXL2DPI) > found in Freescale i.MX8qxp processor. > + > +endif # ARCH_MXC || COMPILE_TEST I was wondering why those were added in drivers/gpu/drm/bridge/imx since they are specific to NXP SoCs, I think they should be moved in the right drm imx subsystem instead of this change. Neil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EF3AC433EF for ; Mon, 27 Jun 2022 12:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4MF2jFeNhz51bG9QOtMHq33DWgx3aWd0jX8J/b0lLKc=; b=0FL0FHNjmdZG2j o0L0jGIQkwpCxUEqKi69TJHDe9/wITmBLPu8tKNp6AQsuRj7cVrRIoU+VN/VO04/mO7wc29bC9ybI FiVG3TcuTZdWbgdothnkCujHTKxaHTPM+9AmepdeZpOOttXNaj9EpIYJZ6OPXrZK4V+L5FueTopW0 lvyAkbssoWgP62o6cCKua4KtgGdIRe9X56HUBPKqtw0DUUZNDgJFWlTZ1J7wy/X7vGLpW1bjf3T/h 8zs+XSWUWd7RiwyW47OPLc8YWE/1VVnO7ONLwkcvAaN805spJm8MZmLO8zToRAOPuLNFYkpexWQig sThTjPlSZFXPikGz31bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5nku-000pe7-Sd; Mon, 27 Jun 2022 12:22:17 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o5nkr-000pcr-Hx for linux-arm-kernel@lists.infradead.org; Mon, 27 Jun 2022 12:22:15 +0000 Received: by mail-wr1-x434.google.com with SMTP id v14so12807508wra.5 for ; Mon, 27 Jun 2022 05:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=188VvDq1B6vx6sWxx4ceVbynV0wzhkvfQ94tlUBCWVo=; b=JWWBEC6UjGz31es5Orpifs2fmId+2PFWHpYPGqcUyEflB+3uOZHze9pg4t/TL3Ai4z ZxifaLGz+qaUA8iBaWRvlQptrX59LYqMUl2hPdenEnARk5NKOxdKJFI1EpG8xFJQT3Am dBOxj37Hgb2Z0Wl1inYBLUDvKEs6EkWHd5cXkO3PsfcieGjlEvL1LHOjIhwT3v7Ln9XA cr4qTjqks7uaMc6Val0kFxsl6S61zUT0dNK3b/zCs/yL+9IHVYJIBv9E+o+yegpTtC0b Cw13uLX61yOXRAVMIOnGgak/Vz7p4DI660bTgKvRQBtftZMc0zQhFng+eEI7CXYFA/cr aysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=188VvDq1B6vx6sWxx4ceVbynV0wzhkvfQ94tlUBCWVo=; b=ECatWlaV+ig+/WkzRJsOnp4F+GJYqpDf74cvDvsmwX4Ukwb1O1s7Np7fG1FKSe6j8Z Rm4PnQ6jVTD1SUMuG8H+LEIS3ENLmK0I4+2tNxdg1rXnk9/A2erKJnNPBlrraH0JQi4E RB50d6b4+O99QudPY6q1hpJzgSNVwQaD7/+dkPeAP5sH3+cideAQgqPIprpty5qJ2doV U9SMn1ftUrvUh2qe2aGQsbu6PY19o8Aq7hQRuZ65Y705ZfL7lxUHnLz5bjmxov97r8H1 2VsRGFWUfg6Q/M33kEhGcVnsctzNcq74a3vtUFcwoWrldfqsbI7l5h1csu6UO9av4UEA zvbQ== X-Gm-Message-State: AJIora+XdB7OGjYzHB6dAE2Hz1L1XF1LahiBLYT5zUHMVV1699ouosDG i6fiU2255TNbwdBoEQteXUJsyA== X-Google-Smtp-Source: AGRyM1uP9iNE+N88b9RoSyrLps3SkHLc2iB388m4oNY4BNDo4xDy3PzsZEiuqBl66tMHwbxuA1WY5Q== X-Received: by 2002:a05:6000:1147:b0:21b:93db:701a with SMTP id d7-20020a056000114700b0021b93db701amr11721409wrx.447.1656332530591; Mon, 27 Jun 2022 05:22:10 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:6f56:f3c6:ba4f:bf5c? ([2001:861:44c0:66c0:6f56:f3c6:ba4f:bf5c]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c501100b003975c7058bfsm13143413wmr.12.2022.06.27.05.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jun 2022 05:22:10 -0700 (PDT) Message-ID: Date: Mon, 27 Jun 2022 14:22:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2] drm/bridge: imx: i.MX8 bridge drivers should depend on ARCH_MXC Content-Language: en-US To: Geert Uytterhoeven , Liu Ying , Andrzej Hajda , Robert Foss , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sakari Ailus , Marek Vasut Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <42c542b53a1c8027b23a045045fbb7b34479913d.1656072500.git.geert+renesas@glider.be> From: Neil Armstrong Organization: Baylibre In-Reply-To: <42c542b53a1c8027b23a045045fbb7b34479913d.1656072500.git.geert+renesas@glider.be> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_052213_643241_72B52125 X-CRM114-Status: GOOD ( 20.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 24/06/2022 14:10, Geert Uytterhoeven wrote: > The various Freescale i.MX8 display bridges are only present on > Freescale i.MX8 SoCs. Hence add a dependency on ARCH_MXC, to prevent > asking the user about these drivers when configuring a kernel without > i.MX SoC support. > > Fixes: e60c4354840b2fe8 ("drm/bridge: imx: Add LDB support for i.MX8qm") > Fixes: 3818715f62b42b5c ("drm/bridge: imx: Add LDB support for i.MX8qxp") > Fixes: 96988a526c97cfbe ("drm/bridge: imx: Add i.MX8qxp pixel link to DPI support") > Fixes: 1ec17c26bc06289d ("drm/bridge: imx: Add i.MX8qm/qxp display pixel link support") > Fixes: 93e163a9e0392aca ("drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support") > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Liu Ying > --- > v2: > - s/i.MX8MP/i.MX8/, > - Add Reviewed-by. > --- > drivers/gpu/drm/bridge/imx/Kconfig | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig > index 212a7b0e64fd8b5a..608f47f41bcd1c81 100644 > --- a/drivers/gpu/drm/bridge/imx/Kconfig > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > @@ -1,3 +1,5 @@ > +if ARCH_MXC || COMPILE_TEST > + > config DRM_IMX8QM_LDB > tristate "Freescale i.MX8QM LVDS display bridge" > depends on OF > @@ -41,3 +43,5 @@ config DRM_IMX8QXP_PIXEL_LINK_TO_DPI > help > Choose this to enable pixel link to display pixel interface(PXL2DPI) > found in Freescale i.MX8qxp processor. > + > +endif # ARCH_MXC || COMPILE_TEST I was wondering why those were added in drivers/gpu/drm/bridge/imx since they are specific to NXP SoCs, I think they should be moved in the right drm imx subsystem instead of this change. Neil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel