From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBE3EC32772 for ; Tue, 16 Aug 2022 09:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=du14Tdtqphcf/Mq6bbOmZww1cgFGrw3tLU0iBNIt0K4=; b=p6v1xewK76rJ70 HP7LC9V7kbal6iOsc0IQ8bCi4hODw4VHC+mqrwaXhOTajs3MLUEFTqaTONDwhsuE7zCFZodn7FTQd dk8F8nvYMNexG8XUHZkl291G1iSie+TFqbN9lPxVODkxpDfSRe0IikT1LXIw7tyQeaztBnFdVqiX8 5Z/4/vKr25t9VwxdlD+YkUa7qAl7PbD/iNXEFPMK8WOc5zo6zMGnoqjaUi5G2rfLYmX0d3vYAd9dg GVGjGTiCtvCS9LJGMvzs/ncsa7h+DZ7ZEzLeAIMAgJOSKB5ATMkBNjPJbJ30JKXnhioS3oySjVzsG Yt8bq/6HHoo5IW02alOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNt7r-000SFB-Mr; Tue, 16 Aug 2022 09:44:43 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNt7p-000SDV-AO for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2022 09:44:42 +0000 Received: by mail-lf1-x12c.google.com with SMTP id r17so14156434lfm.11 for ; Tue, 16 Aug 2022 02:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Enloy5lgKrMKVLbqE4UqCEXL8D9Wgy3KUpK/qyBoIrI=; b=bmhY0kYxRm0Pu1Cs0YlMSETk0hz7OlpKbOUt8eVnlNIeRbuboqVaSXl/78n+u1O29t RWkFw0mRgGs6O9xp37PVWEjfbpC9cvfDuPeJDbI1CWUKikDaalsk6P+uWh8uNsnn+f/P QIFsP8CfQuNuSIih2QvNTFRYGLDmv2wNF3ku4sXH+o83ZAkPRnbVk/wplO4egti048ZD ErxTSkVmZxvFPLxaqXZd1gC4KD0DYq32h2XL+NCU4wmEzS981G+5fm+K2KJHHNjFk5CC UzE9+Q6LCgzSP1ffDEM/NbheuzW8sp649Ns0J1nneXwCLJwPo+miQhcLwuRVAiQukuJU I7aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Enloy5lgKrMKVLbqE4UqCEXL8D9Wgy3KUpK/qyBoIrI=; b=KG+YvGp4h2D91uW4Gw5S+H9+fe2JSJawLVbovQeRlwfvlot/RBtVbhW2aVX/jTDZqu Sk/ws3SKgySPIPCRKd4apLg0F5a0GUDU1iC+t+GKVRClwPuVj289OFZIebC5FK9YMU++ 9gtAHEwyOwztuvVBNJViNz2gGz8GzdhWp0oe4Ix8JgyPRbo30mZ7xZbv/2fiWyHEBYuT o40WYJLTFjdrrDQvIhBlhIRaCHG+ULxdzofeMtgQsqIrdht+sf4HFJidM4bDnKd46nRS 8ORXlCS54nVfpJmsPhtB5odRB5Jr5y+tzS+ix+6fvJ+FO6iF3asofQku35FO2avOjUCS gezg== X-Gm-Message-State: ACgBeo3sdk5oUuBWUXqAK0h59jlihYcUmGhoBwnUO1eaJK50i7LZDPaf +2K/mcO4mdBQFnvlPTc+yVwjUg== X-Google-Smtp-Source: AA6agR54PZx7XS1rYcJtMRhTAqOXN6+VFqLfzj/NiD8GAFWFKJ+lry6TmRGXna2tZtdoMf6GdwYMxQ== X-Received: by 2002:ac2:44af:0:b0:48a:f361:fe1d with SMTP id c15-20020ac244af000000b0048af361fe1dmr7226313lfm.190.1660643079100; Tue, 16 Aug 2022 02:44:39 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id z12-20020a056512370c00b0048b08e25979sm1330665lfr.199.2022.08.16.02.44.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 02:44:38 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 12:44:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 0/6] i2c-imx-lpi2c: add IPG clock Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , Aisheng Dong , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Clark Wang References: <20220812043424.4078034-1-peng.fan@oss.nxp.com> <039566a7-5c65-b2d8-7b45-c616863cb292@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_024441_466489_65B69EE2 X-CRM114-Status: GOOD ( 10.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/08/2022 11:43, Peng Fan wrote: >> No. For such patch ABI break is also not allowed in that case. Just make the >> driver backwards compatible and both problems - non bisectability and ABI >> break - go away. > > One more point that I am not very clear about > "non bisectability and ABI break " > > ABI, I suppose you mean dt-binding, right? > The I2C bindings and dts update will go through different tree, I think. So > dtbs_check may fail considering the PR merge order. ABI break means breaking Application Binary Interface, so out of tree DTS conforming to old bindings stop working with new kernel. ABI is described by bindings and implemented by driver. You broke it in the driver. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE61CC28B2B for ; Tue, 16 Aug 2022 11:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232176AbiHPLUv (ORCPT ); Tue, 16 Aug 2022 07:20:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234715AbiHPLTz (ORCPT ); Tue, 16 Aug 2022 07:19:55 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4342E2C55 for ; Tue, 16 Aug 2022 02:44:40 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id v2so14179866lfi.6 for ; Tue, 16 Aug 2022 02:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Enloy5lgKrMKVLbqE4UqCEXL8D9Wgy3KUpK/qyBoIrI=; b=bmhY0kYxRm0Pu1Cs0YlMSETk0hz7OlpKbOUt8eVnlNIeRbuboqVaSXl/78n+u1O29t RWkFw0mRgGs6O9xp37PVWEjfbpC9cvfDuPeJDbI1CWUKikDaalsk6P+uWh8uNsnn+f/P QIFsP8CfQuNuSIih2QvNTFRYGLDmv2wNF3ku4sXH+o83ZAkPRnbVk/wplO4egti048ZD ErxTSkVmZxvFPLxaqXZd1gC4KD0DYq32h2XL+NCU4wmEzS981G+5fm+K2KJHHNjFk5CC UzE9+Q6LCgzSP1ffDEM/NbheuzW8sp649Ns0J1nneXwCLJwPo+miQhcLwuRVAiQukuJU I7aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Enloy5lgKrMKVLbqE4UqCEXL8D9Wgy3KUpK/qyBoIrI=; b=JNj/9a+Q+bucNnPuSUjhvh2fyPePrYDmCQAV3r8SMLcsZ0/QYIsDHkbQswP5i992cj y9nnfDUetn5evzzRnThtyA8v6OCHxp7uEYsI1kJk6hM0eronTmJwB23pro+VrQMaIrbc lLkwDQiFg0cfgUB9x49QbI8XPXi1uzY5aWrl6fFF74IVoFDFcwWHGO6dlwaEEcEsuD/r Bt4C2AAegKpvTIRK8fqwDY5YHhjXC9JxZHgZokruMk7EC5kGbv3dgzCpzcRNbzmd5O40 C6Le6V5Q5RXaPZZ/N36pIQ9HmDiwO/ry/V1T4qSXh3Kz47YqBg+cvDvcK08w7e/O0RE7 E3yQ== X-Gm-Message-State: ACgBeo0YXYJaJN5nPsmYjz6wB67WvsXvBzAFJ9alQX96xxhmdz0jYoli In25B33EXBm1ao8E/HxG54mW9Q== X-Google-Smtp-Source: AA6agR54PZx7XS1rYcJtMRhTAqOXN6+VFqLfzj/NiD8GAFWFKJ+lry6TmRGXna2tZtdoMf6GdwYMxQ== X-Received: by 2002:ac2:44af:0:b0:48a:f361:fe1d with SMTP id c15-20020ac244af000000b0048af361fe1dmr7226313lfm.190.1660643079100; Tue, 16 Aug 2022 02:44:39 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id z12-20020a056512370c00b0048b08e25979sm1330665lfr.199.2022.08.16.02.44.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 02:44:38 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 12:44:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 0/6] i2c-imx-lpi2c: add IPG clock Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , Aisheng Dong , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Clark Wang References: <20220812043424.4078034-1-peng.fan@oss.nxp.com> <039566a7-5c65-b2d8-7b45-c616863cb292@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/2022 11:43, Peng Fan wrote: >> No. For such patch ABI break is also not allowed in that case. Just make the >> driver backwards compatible and both problems - non bisectability and ABI >> break - go away. > > One more point that I am not very clear about > "non bisectability and ABI break " > > ABI, I suppose you mean dt-binding, right? > The I2C bindings and dts update will go through different tree, I think. So > dtbs_check may fail considering the PR merge order. ABI break means breaking Application Binary Interface, so out of tree DTS conforming to old bindings stop working with new kernel. ABI is described by bindings and implemented by driver. You broke it in the driver. Best regards, Krzysztof