From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28176C433DB for ; Thu, 21 Jan 2021 21:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E583423A54 for ; Thu, 21 Jan 2021 21:45:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727380AbhAUVpF (ORCPT ); Thu, 21 Jan 2021 16:45:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbhAUVm3 (ORCPT ); Thu, 21 Jan 2021 16:42:29 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 314E9C06174A; Thu, 21 Jan 2021 13:41:49 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id q8so4652567lfm.10; Thu, 21 Jan 2021 13:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OwuZCb9ewdwlU+R/2zHWpei3yNvd7dd0S6nSVQta5DI=; b=fBXm2YJcCsvdZxWSnDxe/6wr+lLyhhW/ocizS5IVOEGEsxlADb/3eud4ZWJ1MG8YXL 5NE9bDKTm8l2Z02uo7/iFyuCYTalmI4QI2Fdmb2Zmi78Myt1ipoJxjusnOIg7v/LvKK8 Aj8LVwX8RvzchjEWZcLU+xpsVW9/XeQF87sDfB5diveC5sPCzjrAnw0IPL1nupN5bLwK FDjBUaUCN6kRGaEpGD2ajy5c03UI2swJEVXdO8TpcchZTilYpwrSSSGho87p65ZEgoQn /Yst5iGJaHO3tT3BaNAnfHWD2wSwoKECXWphYhMOmJMaIKUldWVDbCiN6hs+HZRu//Ar rDBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OwuZCb9ewdwlU+R/2zHWpei3yNvd7dd0S6nSVQta5DI=; b=JefvMK/jpMuMNXDkJ2ZFBsn/Evf5QUZ75SmEOqghEbMRkSMyq2r4jBxPimnneaffZW fTz9m3ecM8NgXX91OC9uUv+wD52DvzciOUvb7b1Qqj6ktatCS9a93EkPRun56OCkXyVY P9aG9ZU07OIr8RQhi6Afob+pGu6aumUoTaVidUsmopuhM5I6NCHTljwt5BCIbrIFnYy3 BohFIwd3hNTsArYmezH7/B5e9w5Lj0fZB1P1Z+OtEIPeXVnfbVPZP+vy9s8+XqYfeA1D 4RkHqLmtOs9/pz5ZAjn9mphJx01lY05equI+bHxvWzePimJ+HLtVcgsQPBBbYA1qUZrx 67kQ== X-Gm-Message-State: AOAM532noOnO2P7/z5XtCVGvACd/NNJf8yIiMkYkPYJjmCAvCeR8QOUQ SFwt8hNQ7xoyC0KGtfS2Q5I= X-Google-Smtp-Source: ABdhPJwUBFzNUJ46w/nJOtGCGRLB+ZGcj7SVGuZbwv03crhNkdJ1EaxnAm5+WhSafvSKthj5QXdsZg== X-Received: by 2002:ac2:54ac:: with SMTP id w12mr629640lfk.514.1611265307783; Thu, 21 Jan 2021 13:41:47 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id g21sm75276lfb.263.2021.01.21.13.41.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 13:41:47 -0800 (PST) Subject: Re: [PATCH 03/13] opp: Keep track of currently programmed OPP To: Viresh Kumar , Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <96b57316a2a307a5cc5ff7302b3cd0084123a2ed.1611227342.git.viresh.kumar@linaro.org> From: Dmitry Osipenko Message-ID: Date: Fri, 22 Jan 2021 00:41:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <96b57316a2a307a5cc5ff7302b3cd0084123a2ed.1611227342.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 21.01.2021 14:17, Viresh Kumar пишет: > @@ -1074,15 +1091,18 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) > > if (!ret) { > ret = _set_opp_bw(opp_table, opp, dev, false); > - if (!ret) > + if (!ret) { > opp_table->enabled = true; > + dev_pm_opp_put(old_opp); > + > + /* Make sure current_opp doesn't get freed */ > + dev_pm_opp_get(opp); > + opp_table->current_opp = opp; > + } > } I'm a bit surprised that _set_opp_bw() isn't used similarly to _set_opp_voltage() in _generic_set_opp_regulator(). I'd expect the BW requirement to be raised before the clock rate goes UP. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CC8C433DB for ; Thu, 21 Jan 2021 21:43:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A9F923A56 for ; Thu, 21 Jan 2021 21:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A9F923A56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Oi17ylRGaABX/RUbATzQyJnuuIllp7llKw/QhjaGAW0=; b=goyd3JGpZOwlMNv43eF7akDUB cf16ydG40JNTQXOPpgbblVcotS5JIu6+8snzRSQt7FpWZpewA1APalprpFIQnUTVlwjIa+bps6zv1 9eHQF2LCVo+bUGiXOxq2TPEEcU3wvBIoFh4d7niTL8sBedsYSBwoq5pn/oPJ05feMBDdqiFfQRany wmhuEw49aFRXfKSzO1Jyn7sGUuB/eujbltfcwqySo4L7dnwtf8Pe9rXJiuElzYauZO4LEibp6ccLb hBdArnQIo2Wv5A17euIKegRsxebVCAIJtZdUZmCzhmgYEwEGd3AdZF846B7kt10TLAQqTPvOKFea8 BJPp3AvvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2hiB-0004WS-Pf; Thu, 21 Jan 2021 21:41:51 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2hi9-0004Vw-74 for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 21:41:49 +0000 Received: by mail-lf1-x136.google.com with SMTP id o10so4631154lfl.13 for ; Thu, 21 Jan 2021 13:41:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OwuZCb9ewdwlU+R/2zHWpei3yNvd7dd0S6nSVQta5DI=; b=fBXm2YJcCsvdZxWSnDxe/6wr+lLyhhW/ocizS5IVOEGEsxlADb/3eud4ZWJ1MG8YXL 5NE9bDKTm8l2Z02uo7/iFyuCYTalmI4QI2Fdmb2Zmi78Myt1ipoJxjusnOIg7v/LvKK8 Aj8LVwX8RvzchjEWZcLU+xpsVW9/XeQF87sDfB5diveC5sPCzjrAnw0IPL1nupN5bLwK FDjBUaUCN6kRGaEpGD2ajy5c03UI2swJEVXdO8TpcchZTilYpwrSSSGho87p65ZEgoQn /Yst5iGJaHO3tT3BaNAnfHWD2wSwoKECXWphYhMOmJMaIKUldWVDbCiN6hs+HZRu//Ar rDBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OwuZCb9ewdwlU+R/2zHWpei3yNvd7dd0S6nSVQta5DI=; b=GpEhTCs5t2gqX+rTJ5sjmz/04jN+679kE1zdR8mrl0kxeOWUzLL4fJZ8kbBX4c7oue 18kH8e9Y7lP0gQjSoxNxzTV6sfmVDjIaLrPluuBqfM9Fj/nMKOYD5oqaHcsrND60RpmC WFslJMftt64v8gJDQorkKd5HPj7kY2niI3OLdWqhIIVk8j5dwB4mFsdk42X9O068HXb2 LOopznlzwAi1/Zxu3GIroAdawfn0TCMNtDRp80vZHKPSMW2g/b7KT5Sspba8OfO0oyan OBnr90vbx+dzhlKAYYk/0C90YX6slsburtvyVoxYTn8xpmRbdkDyf+Ff5u8NpPMo7+Qb iHTw== X-Gm-Message-State: AOAM533C9/VHACjukyBUxm87SvWTVZ5quJrpa5UC5zzAFGKs/lpMP/sI NGc7lqJJC7iAOEpuTiPDSn7yPbAN+II= X-Google-Smtp-Source: ABdhPJwUBFzNUJ46w/nJOtGCGRLB+ZGcj7SVGuZbwv03crhNkdJ1EaxnAm5+WhSafvSKthj5QXdsZg== X-Received: by 2002:ac2:54ac:: with SMTP id w12mr629640lfk.514.1611265307783; Thu, 21 Jan 2021 13:41:47 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id g21sm75276lfb.263.2021.01.21.13.41.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 13:41:47 -0800 (PST) Subject: Re: [PATCH 03/13] opp: Keep track of currently programmed OPP To: Viresh Kumar , Viresh Kumar , Nishanth Menon , Stephen Boyd References: <96b57316a2a307a5cc5ff7302b3cd0084123a2ed.1611227342.git.viresh.kumar@linaro.org> From: Dmitry Osipenko Message-ID: Date: Fri, 22 Jan 2021 00:41:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <96b57316a2a307a5cc5ff7302b3cd0084123a2ed.1611227342.git.viresh.kumar@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_164149_261054_2DEF712C X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vincent Guittot , linux-pm@vger.kernel.org, Rafael Wysocki , linux-kernel@vger.kernel.org, Sibi Sankar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjEuMDEuMjAyMSAxNDoxNywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gQEAgLTEwNzQsMTUg KzEwOTEsMTggQEAgaW50IGRldl9wbV9vcHBfc2V0X3JhdGUoc3RydWN0IGRldmljZSAqZGV2LCB1 bnNpZ25lZCBsb25nIHRhcmdldF9mcmVxKQo+ICAKPiAgCWlmICghcmV0KSB7Cj4gIAkJcmV0ID0g X3NldF9vcHBfYncob3BwX3RhYmxlLCBvcHAsIGRldiwgZmFsc2UpOwo+IC0JCWlmICghcmV0KQo+ ICsJCWlmICghcmV0KSB7Cj4gIAkJCW9wcF90YWJsZS0+ZW5hYmxlZCA9IHRydWU7Cj4gKwkJCWRl dl9wbV9vcHBfcHV0KG9sZF9vcHApOwo+ICsKPiArCQkJLyogTWFrZSBzdXJlIGN1cnJlbnRfb3Bw IGRvZXNuJ3QgZ2V0IGZyZWVkICovCj4gKwkJCWRldl9wbV9vcHBfZ2V0KG9wcCk7Cj4gKwkJCW9w cF90YWJsZS0+Y3VycmVudF9vcHAgPSBvcHA7Cj4gKwkJfQo+ICAJfQoKSSdtIGEgYml0IHN1cnBy aXNlZCB0aGF0IF9zZXRfb3BwX2J3KCkgaXNuJ3QgdXNlZCBzaW1pbGFybHkgdG8KX3NldF9vcHBf dm9sdGFnZSgpIGluIF9nZW5lcmljX3NldF9vcHBfcmVndWxhdG9yKCkuCgpJJ2QgZXhwZWN0IHRo ZSBCVyByZXF1aXJlbWVudCB0byBiZSByYWlzZWQgYmVmb3JlIHRoZSBjbG9jayByYXRlIGdvZXMg VVAuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==