From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E482C433E0 for ; Tue, 2 Mar 2021 07:02:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB346614A7 for ; Tue, 2 Mar 2021 07:02:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB346614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGz2k-0005gF-I8 for qemu-devel@archiver.kernel.org; Tue, 02 Mar 2021 02:02:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGz0f-0004P7-Do for qemu-devel@nongnu.org; Tue, 02 Mar 2021 01:59:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23510) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lGz0d-0007yh-U4 for qemu-devel@nongnu.org; Tue, 02 Mar 2021 01:59:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614668395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hrI4HONUyMLzqEC9i7lAUw9esnasU6RSkjf3DgLTfC0=; b=gM67IDDVIEo4bQzAJn7hVixuAicKhKZH9eTo13elCRTIKQLbYYtPnyFbeNNn6aIvf1NDWi JEEkNB6NzS3MBk+mDjfLo4fB0ThPX3XD9aPpbDcrL1NHkrNOPfEMTcfpbHHbKyGjEMkx4P /TYOo2HE8Y5/kItw7X1NeTGH9fR8NJk= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-562-odxwLYOwPKG3y9L6OFKi_A-1; Tue, 02 Mar 2021 01:59:53 -0500 X-MC-Unique: odxwLYOwPKG3y9L6OFKi_A-1 Received: by mail-ej1-f72.google.com with SMTP id jo6so5925315ejb.13 for ; Mon, 01 Mar 2021 22:59:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hrI4HONUyMLzqEC9i7lAUw9esnasU6RSkjf3DgLTfC0=; b=VSuX0rtAS0oA9FAu29MtcL5XgLBkW4GsTSUY08f464bTz6H0Hs72Z8ehiCpVI+VpgN N/xtw7G6QNKjqThOfRE6Dz2h6PqXe93KWxrgAj/1DFJsgWn0HLwe10drCf194xBWdxec m9PG1L9AgbYmsiER14CQqJnoR2gch/JsUVQoo7ZQFfcmSRb439v2OVMSDQyhsQ0h5JED PT9cD1DxPLfvaWGCMUshD74tIvlAoRNz3wHVSLK0F3AQQFmwBwQXcrsnp5kqPHB8VezK 2BEOZWbWwEAdeUha4n7b9kSHbzF+a1XWgvWKIKe/05xJ1lW0zwI7HbG0kiUof8iYqusI PuAQ== X-Gm-Message-State: AOAM530unGHMtA7Bru16u94dX7eo2iTVlBacxf6404tEQOztg4/sO7ZL sPQbybjHlGWYnbo7qGMvaMtR6oj7yrP85WvPeSjPYCvN6lo4wLrTrlE89cDrUED5qI/j3lM2Ood RpTgu2+alVo98xJI= X-Received: by 2002:a17:906:128e:: with SMTP id k14mr19108954ejb.427.1614668391631; Mon, 01 Mar 2021 22:59:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEkbEeZSy2iRn2HITU7rP5LBWNuJCwc9HkbS3dh93BgCIlnKo+ywfZ+yp0+aynQc9wgeCeCw== X-Received: by 2002:a17:906:128e:: with SMTP id k14mr19108942ejb.427.1614668391481; Mon, 01 Mar 2021 22:59:51 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id r24sm10849329edw.11.2021.03.01.22.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Mar 2021 22:59:51 -0800 (PST) Subject: Re: [PATCH V3 09/10] cadence_gem: switch to use qemu_receive_packet() for loopback To: Jason Wang , qemu-devel@nongnu.org References: <20210302055500.51954-1-jasowang@redhat.com> <20210302055500.51954-11-jasowang@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Tue, 2 Mar 2021 07:59:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210302055500.51954-11-jasowang@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alxndr@bu.edu, qemu-security@nongnu.org, ppandit@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/2/21 6:54 AM, Jason Wang wrote: > From: Alexander Bulekov > > This patch switches to use qemu_receive_packet() which can detect > reentrancy and return early. > > Signed-off-by: Alexander Bulekov > --- > hw/net/cadence_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c > index 7a534691f1..6032395388 100644 > --- a/hw/net/cadence_gem.c > +++ b/hw/net/cadence_gem.c > @@ -1275,7 +1275,7 @@ static void gem_transmit(CadenceGEMState *s) > /* Send the packet somewhere */ > if (s->phy_loop || (s->regs[GEM_NWCTRL] & > GEM_NWCTRL_LOCALLOOP)) { > - gem_receive(qemu_get_queue(s->nic), s->tx_packet, > + qemu_receive_packet(qemu_get_queue(s->nic), s->tx_packet, > total_bytes); Indent now off, otherwise: Reviewed-by: Philippe Mathieu-Daudé > } else { > qemu_send_packet(qemu_get_queue(s->nic), s->tx_packet, >