From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xGhR=YN=lists.ozlabs.org=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3E464CA9EAD
	for <linuxppc-dev@archiver.kernel.org>; Sun, 20 Oct 2019 10:28:14 +0000 (UTC)
Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id A16CA218BA
	for <linuxppc-dev@archiver.kernel.org>; Sun, 20 Oct 2019 10:28:13 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="ZiUIFUHz"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A16CA218BA
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org
Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])
	by lists.ozlabs.org (Postfix) with ESMTP id 46wwvt5zjBzDqpp
	for <linuxppc-dev@archiver.kernel.org>; Sun, 20 Oct 2019 21:28:10 +1100 (AEDT)
Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 46wwsW5qP9zDqLl
 for <linuxppc-dev@lists.ozlabs.org>; Sun, 20 Oct 2019 21:26:07 +1100 (AEDT)
Authentication-Results: lists.ozlabs.org;
 dmarc=none (p=none dis=none) header.from=c-s.fr
Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key;
 unprotected) header.d=c-s.fr header.i=@c-s.fr header.b="ZiUIFUHz"; 
 dkim-atps=neutral
Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2])
 by bilbo.ozlabs.org (Postfix) with ESMTP id 46wwsV3l24z8swC
 for <linuxppc-dev@lists.ozlabs.org>; Sun, 20 Oct 2019 21:26:06 +1100 (AEDT)
Received: by ozlabs.org (Postfix)
 id 46wwsV23F2z9sP7; Sun, 20 Oct 2019 21:26:06 +1100 (AEDT)
Authentication-Results: ozlabs.org;
 spf=pass (sender SPF authorized) smtp.mailfrom=c-s.fr
 (client-ip=93.17.236.30; helo=pegase1.c-s.fr;
 envelope-from=christophe.leroy@c-s.fr; receiver=<UNKNOWN>)
Authentication-Results: ozlabs.org;
 dmarc=none (p=none dis=none) header.from=c-s.fr
Authentication-Results: ozlabs.org; dkim=pass (1024-bit key;
 unprotected) header.d=c-s.fr header.i=@c-s.fr header.b="ZiUIFUHz"; 
 dkim-atps=neutral
Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ozlabs.org (Postfix) with ESMTPS id 46wwsS4C0Rz9sNx
 for <linuxppc-dev@ozlabs.org>; Sun, 20 Oct 2019 21:26:01 +1100 (AEDT)
Received: from localhost (mailhub1-int [192.168.12.234])
 by localhost (Postfix) with ESMTP id 46wwsH4YtDz9txvP;
 Sun, 20 Oct 2019 12:25:55 +0200 (CEST)
Authentication-Results: localhost; dkim=pass
 reason="1024-bit key; insecure key"
 header.d=c-s.fr header.i=@c-s.fr header.b=ZiUIFUHz; dkim-adsp=pass;
 dkim-atps=neutral
X-Virus-Scanned: Debian amavisd-new at c-s.fr
Received: from pegase1.c-s.fr ([192.168.12.234])
 by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024)
 with ESMTP id OEtWxn8g5DW1; Sun, 20 Oct 2019 12:25:55 +0200 (CEST)
Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])
 by pegase1.c-s.fr (Postfix) with ESMTP id 46wwsH3Wl5z9v0DX;
 Sun, 20 Oct 2019 12:25:55 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail;
 t=1571567155; bh=CBGWSUvTTQ6v/xwD1tEuw1dPPmHh00ky9Qd+WeXNoZs=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To:From;
 b=ZiUIFUHzRyjZgGQZ6GXrhPXBwU2LWrKW7i5wrTLo0GCvExvBdABazM0IgrNRdAGAA
 ATz3919+l0WeMHeG3RM4xI6liuN7MO8o6m2p8lWySoaRYcfqgj/2NtIAb83DLUCcdb
 d45hv8ncFs9une/uZKzIUUjHzaYvjKvXkcZgD+Ec=
Received: from localhost (localhost [127.0.0.1])
 by messagerie.si.c-s.fr (Postfix) with ESMTP id 7D51D8B8A9;
 Sun, 20 Oct 2019 12:25:58 +0200 (CEST)
X-Virus-Scanned: amavisd-new at c-s.fr
Received: from messagerie.si.c-s.fr ([127.0.0.1])
 by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023)
 with ESMTP id 2YaREXtXbuvN; Sun, 20 Oct 2019 12:25:58 +0200 (CEST)
Received: from [192.168.4.90] (unknown [192.168.4.90])
 by messagerie.si.c-s.fr (Postfix) with ESMTP id 26FFB8B8A5;
 Sun, 20 Oct 2019 12:25:57 +0200 (CEST)
Subject: Re: passing NULL to clock_getres (VDSO): terminated by unexpected
 signal 11
To: Andreas Schwab <schwab@linux-m68k.org>,
 Thomas Gleixner <tglx@linutronix.de>
References: <0fc22a08-31d9-e4d1-557e-bf5b482a9a20__6444.28012180782$1571503753$gmane$org@c-s.fr>
 <87v9skcznp.fsf@igel.home> <ed65e4c6-2fe0-2f5c-f667-5a81b19eb073@c-s.fr>
 <87tv83zqt1.fsf@hase.home>
From: Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <b64c367b-d1e5-bf26-d452-145c0be6e30a@c-s.fr>
Date: Sun, 20 Oct 2019 12:25:57 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <87tv83zqt1.fsf@hase.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
X-BeenThere: linuxppc-dev@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev/>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>
Cc: Nathan Lynch <nathanl@linux.ibm.com>,
 "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
 Vincenzo Frascino <vincenzo.frascino@arm.com>
Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org
Sender: "Linuxppc-dev"
 <linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org>

Adding Thomas to the discussion as the commit is from him.

Le 20/10/2019 à 11:53, Andreas Schwab a écrit :
> On Okt 20 2019, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
> 
>> Le 19/10/2019 à 21:18, Andreas Schwab a écrit :
>>> On Okt 19 2019, Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>>>
>>>> Hi Nathan,
>>>>
>>>> While trying to switch powerpc VDSO to C version of gettimeofday(), I'm
>>>> getting the following kind of error with vdsotest:
>>>>
>>>> passing NULL to clock_getres (VDSO): terminated by unexpected signal 11
>>>>
>>>> Looking at commit a9446a906f52 ("lib/vdso/32: Remove inconsistent NULL
>>>> pointer checks"), it seems that signal 11 is expected when passing NULL
>>>> pointer.
>>>>
>>>> Any plan to fix vdsotest ?
>>>
>>> Passing NULL to clock_getres is valid, and required to return
>>> successfully if the clock id is valid.
>>>
>>
>> Do you mean the following commit is wrong ?
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/lib/vdso?id=a9446a906f52292c52ecbd5be78eaa4d8395756c
> 
> If it causes a valid call to clock_getres to fail, then yes.
> 
> Andreas.
>