From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 578D9C47094 for ; Thu, 10 Jun 2021 16:02:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 263876128A for ; Thu, 10 Jun 2021 16:02:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 263876128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3A57D82D6E; Thu, 10 Jun 2021 18:02:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="jJDCDYT/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 28CA082EAC; Thu, 10 Jun 2021 18:02:17 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on0627.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe06::627]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 918E482D6E for ; Thu, 10 Jun 2021 18:02:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U1VxBreI4D9sB6+bNQ7h8RdMzKV9pfqBj8IanG0mmwILnRJatQPNUKbl0U67d4NoXVOlOm89iNACNNSDWh+deHTWrEU2zF/ybKYIBqBBefTn+iKr27hbKIbda0yZ3r8Ev58KkDkN4IjI7aCNkCYQkfXuxCWc0KxRnqu1/b5Xj1R6xtwDT5qDD/F1n71/FwKsTQ9wpHAP7iPxCjEVvC2Yh6c3VUrbOI8XHo6tXd47vSMyf0RBtI9BhCiCcL7nBO21kmoGAZ3U9oNl3ts2OXM2jyDEscPxIbAzsmVZI05IOrMiRtQPuESNahW8c3oUM7oW6MGwHylwnPqOEhPwbjwqWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XdkervfgmrH16nD60wrpzcfwXefSGlmtQH7mUtJNZZg=; b=mbT2GOpJHpV6Rpjk3F3TE89jL0oRePuYxXIC4aJ/AesNMoHS1YWFvWplTZWZQ4vylx79hfPfwGgAQnaczfArw+zmJmfwnccx/tixeBKgwdoHCdAB4EA320bkoJvef86iNFmgA8yQLHILwB5J4ynmUIJC1I23PiIOgRCchcYcnptinjw5dd2QIDTUby82pnQ24TNorXpP0QJ7Qn7N42SRZiGIn7qkUu1rQ9EGIIjtJMGmD2wHnMi/37E6dJ/hq3ql4ogxJO4B4pHX8uRIdkLa536yO2SCz4wYAPK2WL97E7BP80ogmky8q/Up5vRv3cievUc9lovKyUDbmv2Q7pG76Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XdkervfgmrH16nD60wrpzcfwXefSGlmtQH7mUtJNZZg=; b=jJDCDYT/vHHqbg72XAh2l2ezxVfvadxFfBn9KK93x+Z/N8PS47wE/nGhRibdjbmUD4Q5bwj2qN5Ep36LSpWnkj4Sz44WMoJlrndKZ5WEfti+7uKyxJ/cnJKYlSUZPxdae+g3BsluMOt+/eD1a/NAmMssROIsKZNIKzCCwFz7zGU= Authentication-Results: mxic.com.tw; dkim=none (message not signed) header.d=none;mxic.com.tw; dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB8PR03MB6027.eurprd03.prod.outlook.com (2603:10a6:10:ec::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Thu, 10 Jun 2021 16:02:10 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::40d5:3554:c709:6b1b]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::40d5:3554:c709:6b1b%5]) with mapi id 15.20.4219.022; Thu, 10 Jun 2021 16:02:10 +0000 Subject: Re: [PATCH v5 1/2] clk: zynq: Add clock wizard driver To: Zhengxun Li Cc: u-boot@lists.denx.de, Michal Simek , lukma@denx.de, zhengxunli@mxic.com.tw References: <20210604170600.5567-1-zhengxunli.mxic@gmail.com> <20210604170600.5567-2-zhengxunli.mxic@gmail.com> From: Sean Anderson Message-ID: Date: Thu, 10 Jun 2021 12:02:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [50.195.82.171] X-ClientProxiedBy: MN2PR01CA0011.prod.exchangelabs.com (2603:10b6:208:10c::24) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [172.27.1.65] (50.195.82.171) by MN2PR01CA0011.prod.exchangelabs.com (2603:10b6:208:10c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Thu, 10 Jun 2021 16:02:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73ede818-5237-48d4-d10e-08d92c291aae X-MS-TrafficTypeDiagnostic: DB8PR03MB6027: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:913; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8NcoueluGYW2VXNVAbtO8+bxHaO7gtCCZnC89+1LKhffvcIwbORMuQy9z2anEo4PSRRzycIUFmpCktb90CQR+npgGwWxGfnb0VCY6FRX7jedUxNu+Pus/11S42VvWf1tqNfJ3zH4nwiJLoWudZyBVJRONtiFIzf8eWt00zfx+q59x0SULWb0GFI0Hz0sCnJshohEqiTBOBomyF9uNs3RdNw+oN/UQLoi9M591XgU9vDIVxX40ESIlFmk+/QWWsFT7MjzQSlKvYlcO6Rea3LW822EqQ/yMew01wCXfgTlMDctgKTyhU3MmU/473zgNAG5GIRXQOC5Mzc7v7VrHd8FNns1h+m9p8HJF7IjNpcxNKIvucsMxRAXS6a3zkVAUVqseQI+ATTNIg3kl5PSfRhzWSZVejsk5DlwWmhZUjDCioLL8PuHwtyyo+qoJ0kL1yBYi2ec3AonRDLFU8pOj/NztO5FKS3d72jxqs2UtoT7avlXEzdUUEDQ7EwYD+RyadlY3PtBA3JoqXT+a5DD2rbUGax2kvSACseBc6wBh1UOQIVWFjX77uOtmezyJli5m9rSVCHHBsExzrO3XFkcYwpdEmuq9wUobCVcbckag8b0TXV9H9yql7wB4Kiewtym+/c8SwhdBf6eatta/po6CrIg2coPhOb0cgHSevze1SvV5zhfoVfLXTr0dCMND1goIGqr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(366004)(396003)(376002)(136003)(39850400004)(316002)(66556008)(16576012)(6486002)(66946007)(66476007)(956004)(52116002)(8936002)(83380400001)(8676002)(478600001)(53546011)(16526019)(86362001)(186003)(38100700002)(38350700002)(6666004)(44832011)(31686004)(6916009)(31696002)(2906002)(5660300002)(2616005)(26005)(4326008)(36756003)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aldpT2JwTng4YUMwR25VVmdDRVpNZ2pIQXppa1E3dkRnZGI0U2dqNzNsRmY2?= =?utf-8?B?dEp5VC9FM0tHeEgrTUtXak5IdVlTSWg2QmR6b2hYL3c5N1plRnRvRDFzYk41?= =?utf-8?B?MnNnT2dHdk9Bb3RaLzZYVWZYLzhoeENRQWtjM1F1MHN0NWJJbGhOOXpvS0Zt?= =?utf-8?B?QzByc2dVNUtQcjRwS2RkSjB1ek5Hek9GZ2tBbDc1SEI5VlZQR0N1cGRoK3Zp?= =?utf-8?B?YjA3YXpFNHhTUXBxNGJETzdOdUk0ekI2d2hzSVJaTXQ0dENXaDA1TUtramNr?= =?utf-8?B?RDgzRGpPNDZQV2VpOG1FcXAzc0FLS1NoMHRMQm1pY21oZUFjaytTSjVSWDgv?= =?utf-8?B?QUhOOXlFWHlLNzRoa0ljM240Z3RhV2xoM0ROaU9YYS9mODFMWmpoYVBheUV0?= =?utf-8?B?V0RTMVVPQmZXTTRIaGpSZDVPMG9nVzhBbVdQekFLVG55U0dZaWxmVzFzMFAx?= =?utf-8?B?b1RmZ0Q3VkozdTJ4UnFCT3U2cFdtZFk5M0l3L1Q4ZXhxWlczaWR4WndJTUdq?= =?utf-8?B?T3AvY1FzM3pHU3J2dTJrQ0VFZm1odmQwbTZvSWxJVXlxa1pJQVVkMWlCVlV2?= =?utf-8?B?bTlnMkQ0ZExkUDlDR2hOdHR3WVhpK3plSHljbkdQM2RqSzNjMkpzSWZGT0Zv?= =?utf-8?B?aVB1WmxDeGJKVUZWeFZ0dlM5VmNzTnVsdHBRYnRIaXAxL3BkVTRQZ041U3Jh?= =?utf-8?B?VTU2eFlsRU83SFdMQlJLZGovUmFMdUFHTEMrK0Z6dXVDT0JPUDNFck5DRnNw?= =?utf-8?B?Z2pNcVVhazVqRGM2c1EyM0NpeEcybkN2aWl4dGc4bllYSTc4REFjUUJwOTNH?= =?utf-8?B?TUMyMU1RTkN1MHFzOU10YnlCYjFqeGZkazQxZG5oazlaaHJTeHZHcGtiQ1pq?= =?utf-8?B?QndxS0FSRGVFdmwwVUN5NkVRc0puM2NBM1h5UFRBUjE1dVZJU3R6NzFvMUxY?= =?utf-8?B?RXNXYlkra0RxUDBJZlYvV3NxK092Mm41eDJBL2JKek1aOVpQaTlTYlJNT05T?= =?utf-8?B?MzNFYXcyUFJqWCtBYktxZjlweGVtRnlVQzIrM1BGNlk0NFpuMTlJRTZxTFcr?= =?utf-8?B?cTFBenVkRFhBVm5mSXViZ0dxNHBQSHBQSG8wdGcwMzdyL3Z6OXVjSVM1Nm95?= =?utf-8?B?aVR3YVhpWVQyYnJrMEJBRHpLRktjeFRYSmpYZmVuaHFrWUZMZ1ZlOENOM0Z4?= =?utf-8?B?L2NWWm53eTBOQTlaMjNXOWRkUlhjNmNIc0hhZlhwVStBV2pQSXJtTXA4RzZD?= =?utf-8?B?cGF2VXZ5TnkzYVJMSTRQQmlkZmNVM1FJMkE2YUlsWTRvdzdiYWF5cjJ3ZzI2?= =?utf-8?B?cTYrWXI0YWlVR3RnUzFQQjhHZXE3ekdGUVpBLzB0aFo3TGprbmtOcDRUMTYv?= =?utf-8?B?MkF4blpRYUFXM2VkZm4vZThGWm9PbWlWMFR6WDFTN1liMzFmaTJpdGZOdGxo?= =?utf-8?B?RVFLd2s0TTJ5Z0Mybi9JY2h1dXUvaUZ4NWtVR2VUaSs5SVNyWjM0M3BJdlN5?= =?utf-8?B?UW1mcFA3NSs0WnFZWDUrWGE0ZDNWN3hTNGJZU2hDLzhuRllsQlc1cjZvL1Bz?= =?utf-8?B?WkpZd3FQK3lyOThmWCt6YlpUSEoyYU43d05DeVRjeCtUQmNZSUQ2dUJWdkxL?= =?utf-8?B?VXVIcjhxZXZBVDBlK2ljdTNXcFBSaHFJN0lBM0Z3czd5MWFKUGJkSlZmRnZa?= =?utf-8?B?QzkyYlg2UHBvT2lCU1BWRmp3YkNzOTJsMmxuNStuam1SV3kvaDJUWGx3Z0Jj?= =?utf-8?Q?KwA/Ptko+Z08mHFJ9aJLjcEF80mnijiXAqQo2dX?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73ede818-5237-48d4-d10e-08d92c291aae X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2021 16:02:10.4620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YwrCpo72bDnt/HurjtcnoWPBzSZgzHTVVqmdZV+TdxqSRV6h6AhW/0KSEARsgeyVNA5KyXfrKSBuAB1Li9x4HQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB6027 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 6/10/21 6:44 AM, Zhengxun Li wrote: > Hi, > > Sean Anderson 於 2021年6月4日 週五 下午2:22寫道： >> >> >> >> On 6/4/21 1:05 PM, Zhengxun wrote: >>> The Clocking Wizard IP supports clock circuits customized >>> to your clocking requirements. The wizard support for >>> dynamically reconfiguring the clocking primitives for >>> Multiply, Divide, Phase Shift/Offset, or Duty Cycle. >>> >>> Limited by U-Boot clk uclass without set_phase API, this >>> patch only provides set_rate to modify the frequency. >>> >>> Signed-off-by: Zhengxun >>> --- >>> drivers/clk/Kconfig | 9 ++ >>> drivers/clk/Makefile | 1 + >>> drivers/clk/clk-xlnx-clock-wizard.c | 186 ++++++++++++++++++++++++++++ >>> 3 files changed, 196 insertions(+) >>> create mode 100644 drivers/clk/clk-xlnx-clock-wizard.c >>> >>> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig >>> index 40a5a5dd88..59922fc88e 100644 >>> --- a/drivers/clk/Kconfig >>> +++ b/drivers/clk/Kconfig >>> @@ -128,6 +128,15 @@ config CLK_ZYNQ >>> This clock driver adds support for clock related settings for >>> Zynq platform. >>> >>> +config CLK_XLNX_CLKWZRD >>> + bool "Xilinx Clocking Wizard" >>> + depends on CLK >>> + help >>> + Support for the Xilinx Clocking Wizard IP core clock generator. >>> + Adds support for clocking wizard and compatible. >>> + This driver supports the Xilinx clocking wizard programmable clock >>> + synthesizer. >> >> Please modify this description in accordance with my comments from last revision. > > Oops, I misunderstood your information and thought I needed to add the > dts binding > to tell how to use the clock wizard. So in this state, I need to add a > comment here or > create another comment to describe the clock wizard? The current description states the same thing three times. It should state this once. In addition, it should note any quirks of the driver or device. For example, it might be prudent to note that this is a soft device, or that you don't support setting the phase. For some good examples, see drivers/clk/at91/Kconfig. --Sean > >>> + >>> config CLK_ZYNQMP >>> bool "Enable clock driver support for ZynqMP" >>> depends on ARCH_ZYNQMP >>> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile >>> index 645709b855..4fcc33953a 100644 >>> --- a/drivers/clk/Makefile >>> +++ b/drivers/clk/Makefile >>> @@ -43,6 +43,7 @@ obj-$(CONFIG_CLK_UNIPHIER) += uniphier/ >>> obj-$(CONFIG_CLK_VEXPRESS_OSC) += clk_vexpress_osc.o >>> obj-$(CONFIG_CLK_ZYNQ) += clk_zynq.o >>> obj-$(CONFIG_CLK_ZYNQMP) += clk_zynqmp.o >>> +obj-$(CONFIG_CLK_XLNX_CLKWZRD) += clk-xlnx-clock-wizard.o >>> obj-$(CONFIG_ICS8N3QV01) += ics8n3qv01.o >>> obj-$(CONFIG_MACH_PIC32) += clk_pic32.o >>> obj-$(CONFIG_SANDBOX) += clk_sandbox.o >>> diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c >>> new file mode 100644 >>> index 0000000000..70ee3af107 >>> --- /dev/null >>> +++ b/drivers/clk/clk-xlnx-clock-wizard.c >>> @@ -0,0 +1,186 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Xilinx 'Clocking Wizard' driver >>> + * >>> + * Copyright (c) 2021 Macronix Inc. >>> + * >>> + * Author: Zhengxun Li >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#include >>> + >>> +#define SRR 0x0 >>> + >>> +#define SR 0x4 >>> +#define SR_LOCKED BIT(0) >>> + >>> +#define CCR(x) (0x200 + ((x) * 4)) >>> + >>> +#define FBOUT_CFG CCR(0) >>> +#define FBOUT_DIV(x) (x) >>> +#define FBOUT_DIV_MASK GENMASK(7, 0) >>> +#define FBOUT_GET_DIV(x) FIELD_GET(FBOUT_DIV_MASK, x) >>> +#define FBOUT_MUL(x) ((x) << 8) >>> +#define FBOUT_MUL_MASK GENMASK(15, 8) >>> +#define FBOUT_GET_MUL(x) FIELD_GET(FBOUT_MUL_MASK, x) >>> +#define FBOUT_FRAC(x) ((x) << 16) >>> +#define FBOUT_FRAC_MASK GENMASK(25, 16) >>> +#define FBOUT_GET_FRAC(x) FIELD_GET(FBOUT_FRAC_MASK, x) >>> +#define FBOUT_FRAC_EN BIT(26) >>> + >>> +#define FBOUT_PHASE CCR(1) >>> + >>> +#define OUT_CFG(x) CCR(2 + ((x) * 3)) >>> +#define OUT_DIV(x) (x) >>> +#define OUT_DIV_MASK GENMASK(7, 0) >>> +#define OUT_GET_DIV(x) FIELD_GET(OUT_DIV_MASK, x) >>> +#define OUT_FRAC(x) ((x) << 8) >>> +#define OUT_GET_MASK GENMASK(17, 8) >>> +#define OUT_GET_FRAC(x) FIELD_GET(OUT_GET_MASK, x) >>> +#define OUT_FRAC_EN BIT(18) >>> + >>> +#define OUT_PHASE(x) CCR(3 + ((x) * 3)) >>> +#define OUT_DUTY(x) CCR(4 + ((x) * 3)) >>> + >>> +#define CTRL CCR(23) >>> +#define CTRL_SEN BIT(2) >>> +#define CTRL_SADDR BIT(1) >>> +#define CTRL_LOAD BIT(0) >>> + >>> +/** >>> + * struct clkwzrd - Clock wizard private data structure >>> + * >>> + * @base: memory base >>> + * @vco_clk: voltage-controlled oscillator frequency >>> + * >>> + */ >>> +struct clkwzd { >>> + void *base; >>> + u64 vco_clk; >>> +}; >>> + >>> +struct clkwzd_plat { >>> + fdt_addr_t addr; >>> +}; >>> + >>> +static int clk_wzrd_enable(struct clk *clk) >>> +{ >>> + struct clkwzd *priv = dev_get_priv(clk->dev); >>> + int ret; >>> + u32 val; >>> + >>> + ret = readl_poll_sleep_timeout(priv->base + SR, val, val & SR_LOCKED, >>> + 1, 100); >>> + if (!ret) { >>> + writel(CTRL_SEN | CTRL_SADDR | CTRL_LOAD, priv->base + CTRL); >>> + writel(CTRL_SADDR, priv->base + CTRL); >>> + ret = readl_poll_sleep_timeout(priv->base + SR, val, >>> + val & SR_LOCKED, 1, 100); >>> + } >>> + >>> + return ret; >>> +} >>> + >>> +static unsigned long clk_wzrd_set_rate(struct clk *clk, ulong rate) >>> +{ >>> + struct clkwzd *priv = dev_get_priv(clk->dev); >>> + u64 div; >>> + u32 cfg; >>> + >>> + /* Get output clock divide value */ >>> + div = DIV_ROUND_DOWN_ULL(priv->vco_clk * 1000, rate); >>> + if (div < 1000 || div > 255999) >>> + return -EINVAL; >>> + >>> + cfg = OUT_DIV((u32)div / 1000); >>> + >>> + writel(cfg, priv->base + OUT_CFG(clk->id)); >>> + >>> + return 0; >>> +} >>> + >>> +static struct clk_ops clk_wzrd_ops = { >>> + .enable = clk_wzrd_enable, >>> + .set_rate = clk_wzrd_set_rate, >>> +}; >>> + >>> +static int clk_wzrd_probe(struct udevice *dev) >>> +{ >>> + struct clkwzd_plat *plat = dev_get_plat(dev); >>> + struct clkwzd *priv = dev_get_priv(dev); >>> + struct clk clk_in1; >>> + u64 clock, vco_clk; >>> + u32 cfg; >>> + int ret; >>> + >>> + priv->base = (void *)plat->addr; >>> + >>> + ret = clk_get_by_name(dev, "clk_in1", &clk_in1); >>> + if (ret < 0) { >>> + dev_err(dev, "failed to get clock\n"); >>> + return ret; >>> + } >>> + >>> + clock = clk_get_rate(&clk_in1); >>> + if (IS_ERR_VALUE(clock)) { >>> + dev_err(dev, "failed to get rate\n"); >>> + return clock; >>> + } >>> + >>> + ret = clk_enable(&clk_in1); >>> + if (ret) { >>> + dev_err(dev, "failed to enable clock\n"); >>> + clk_free(&clk_in1); >>> + return ret; >>> + } >>> + >>> + /* Read clock configuration registers */ >>> + cfg = readl(priv->base + FBOUT_CFG); >>> + >>> + /* Recalculate VCO rate */ >>> + if (cfg & FBOUT_FRAC_EN) >>> + vco_clk = DIV_ROUND_DOWN_ULL(clock * >>> + ((FBOUT_GET_MUL(cfg) * 1000) + >>> + FBOUT_GET_FRAC(cfg)), >>> + 1000); >>> + else >>> + vco_clk = clock * FBOUT_GET_MUL(cfg); >>> + >>> + priv->vco_clk = DIV_ROUND_DOWN_ULL(vco_clk, FBOUT_GET_DIV(cfg)); >>> + >>> + return 0; >>> +} >>> + >>> +static int clk_wzrd_of_to_plat(struct udevice *dev) >>> +{ >>> + struct clkwzd_plat *plat = dev_get_plat(dev); >>> + >>> + plat->addr = dev_read_addr(dev); >>> + if (plat->addr == FDT_ADDR_T_NONE) >>> + return -EINVAL; >>> + >>> + return 0; >>> +} >>> + >>> +static const struct udevice_id clk_wzrd_ids[] = { >>> + { .compatible = "xlnx,clocking-wizard" }, >>> + { /* sentinel */ } >>> +}; >>> + >>> +U_BOOT_DRIVER(clk_wzrd) = { >>> + .name = "zynq-clk-wizard", >>> + .id = UCLASS_CLK, >>> + .of_match = clk_wzrd_ids, >>> + .ops = &clk_wzrd_ops, >>> + .probe = clk_wzrd_probe, >>> + .of_to_plat = clk_wzrd_of_to_plat, >>> + .priv_auto = sizeof(struct clkwzd), >>> + .plat_auto = sizeof(struct clkwzd_plat), >>> +}; >>> >> >> With that fixed, >> >> Reviewed-by: Sean Anderson > > Thanks, > Zhengxun >