From: yangerkun <yangerkun@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: <sfr@canb.auug.org.au>, <jack@suse.cz>, <viro@zeniv.linux.org.uk>,
<gregkh@linuxfoundation.org>, <linux-fsdevel@vger.kernel.org>,
<linux-mm@kvack.org>, <yukuai3@huawei.com>
Subject: Re: [PATCH] ramfs: fix mount source show for ramfs
Date: Mon, 13 Sep 2021 09:10:53 +0800 [thread overview]
Message-ID: <b66aa49b-8289-be25-6126-92e6ce1c50ab@huawei.com> (raw)
In-Reply-To: <b82b7472-be64-4681-98a2-9d16736e3edd@huawei.com>
在 2021/9/9 16:37, yangerkun 写道:
>
>
> 在 2021/9/9 6:39, Andrew Morton 写道:
>> On Wed, 8 Sep 2021 16:56:25 +0800 yangerkun <yangerkun@huawei.com> wrote:
>>
>>> 在 2021/8/11 20:28, yangerkun 写道:
>>>> ramfs_parse_param does not parse key "source", and will convert
>>>> -ENOPARAM to 0. This will skip vfs_parse_fs_param_source in
>>>> vfs_parse_fs_param, which lead always "none" mount source for ramfs.
>>>> Fix
>>>> it by parse "source" in ramfs_parse_param.
>>>>
>>>> Signed-off-by: yangerkun <yangerkun@huawei.com>
>>>> ---
>>>> fs/ramfs/inode.c | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c
>>>> index 65e7e56005b8..0d7f5f655fd8 100644
>>>> --- a/fs/ramfs/inode.c
>>>> +++ b/fs/ramfs/inode.c
>>>> @@ -202,6 +202,10 @@ static int ramfs_parse_param(struct fs_context
>>>> *fc, struct fs_parameter *param)
>>>> struct ramfs_fs_info *fsi = fc->s_fs_info;
>>>> int opt;
>>>> + opt = vfs_parse_fs_param_source(fc, param);
>>>> + if (opt != -ENOPARAM)
>>>> + return opt;
>>>> +
>>>> opt = fs_parse(fc, ramfs_fs_parameters, param, &result);
>>>> if (opt < 0) {
>>>> /*
>>>>
>>
>> (top-posting repaired)
>>
>>> Hi, this patch seems still leave in linux-next, should we pull it to
>>> mainline?
>>
>> I was hoping for a comment from Al?
>
> Hi, Al,
>
> Can you help to review this patch...
Hi, Al,
Sorry for the noise again, can you help to give some comments for this
patch.
>
> Thanks,
> Kun.
>
>> .
>>
> .
next prev parent reply other threads:[~2021-09-13 1:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 12:28 [PATCH] ramfs: fix mount source show for ramfs yangerkun
2021-09-08 8:56 ` yangerkun
2021-09-08 22:39 ` Andrew Morton
2021-09-09 8:37 ` yangerkun
2021-09-13 1:10 ` yangerkun [this message]
2021-09-18 7:08 ` yangerkun
2021-09-23 6:07 ` yangerkun
2021-09-24 4:35 ` Al Viro
2021-09-24 7:53 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b66aa49b-8289-be25-6126-92e6ce1c50ab@huawei.com \
--to=yangerkun@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.