From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 00/26] DPDK PMD for OCTEONTX NW device Date: Tue, 5 Sep 2017 18:43:37 +0100 Message-ID: References: <20170831145436.5397-1-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: santosh.shukla@caviumnetworks.com To: Jerin Jacob , dev@dpdk.org Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F3CD429D6 for ; Tue, 5 Sep 2017 19:43:40 +0200 (CEST) In-Reply-To: <20170831145436.5397-1-jerin.jacob@caviumnetworks.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/31/2017 3:54 PM, Jerin Jacob wrote: > This patch set provides the initial version of DPDK PMD for the > integrated NIC device found in Cavium OCTEONTX SoC(CN83xx) family. > > Introduction to OCTEONTX ARM processors can be found > here: http://www.cavium.com/OCTEON-TX_ARM_Processors.html > > OCTEONTX SoC family has two types of NIC controllers, > 1) nicvf HW, Which is more like traditional NIC(no NPU HW accelerators) > http://dpdk.org/doc/guides/nics/thunderx.html > > 2) NIC controller, based on NPU like HW accelerated coprocessors, like > HW assisted mempool manager, HW assisted packet scheduler, etc > > This driver adds support for the second type device and which will be > used as HW implementation driver ethdev-eventdev Rx adapter [1] > > Implemented features and PMD documentation added > in doc/guides/nics/features/octeontx.ini and doc/guides/nics/octeontx.rst > respectively in this patch set. > > This driver has the dependency on: > - IOVA infrastructure [2]. > - Dynamically configure mempool handle (ie.. --mbuf-pool-ops eal arg) [3]. > - Infrastructure to support octeontx HW mempool manager [4]. > - Cavium Octeontx external mempool driver [5] > Git source repo for all above dependency patches located at [6]. Hi Jerin, At first glance PMD looks good to me, but currently there are many dependencies and I am not able to apply the set. I will wait a little more for dependent patches to settle down and will re-visit this again. > > The series has three check patch issues: > 1) 1 Error on Complex Macro (which I believe it cannot be fixed) # Patch 2 > 2) 1 Error on spacing while using gcc inline assembly(it is false positive) # patch 2 > 3) Added Co-authored-by: signature to reflect the patch authorship status instead > of "Signed-off-by". It can be changed or the contributing guide can be > updated based on the community feedback in v2. > > [1] http://dpdk.org/dev/patchwork/patch/24176/ Are these APIs used in this patchset, I looked for them but not able to find ... > [2] http://dpdk.org/ml/archives/dev/2017-August/072871.html > [3] http://dpdk.org/ml/archives/dev/2017-August/072910.html > [4] http://dpdk.org/ml/archives/dev/2017-August/072892.html > [5] http://dpdk.org/ml/archives/dev/2017-August/073898.html > [6] https://github.com/sshukla82/dpdk > branch: mempool-v2 > > Jerin Jacob (26): > net/octeontx: add build infrastructure > net/octeontx/base: add octeontx io operations > event/octeontx: introduce specialized mbox message copy > net/octeontx/base: add base BGX operations > net/octeontx/base: add remaining BGX operations > net/octeontx/base: probe PKI and PKO PCIe VF devices > net/octeontx/base: add base PKI operations > net/octeontx/base: add remaining PKI operations > net/octeontx/base: add base PKO operations > net/octeontx/base: add remaining PKO operations > net/octeontx: add eth device probe and remove > net/octeontx: create ethdev ports > net/octeontx: add device configure > net/octeontx: add device info > net/octeontx: add link update > net/octeontx: add promiscuous mode ops > net/octeontx: add basic stats support > net/octeontx: add MAC addr set op > net/octeontx: add Rx queue setup and release ops > net/octeontx: add Tx queue start and stop > net/octeontx: add Tx queue setup and release ops > net/octeontx: add packet transmit burst function > net/octeontx: add packet receive burst function > net/octeontx: add packet type parsing support > net/octeontx: add start and stop support > doc: add octeontx ethdev driver documentation <...>