From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03DD0C433EF for ; Thu, 14 Jul 2022 12:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238404AbiGNMZV (ORCPT ); Thu, 14 Jul 2022 08:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbiGNMZU (ORCPT ); Thu, 14 Jul 2022 08:25:20 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 767DACC8 for ; Thu, 14 Jul 2022 05:25:19 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id bp17so2538433lfb.3 for ; Thu, 14 Jul 2022 05:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UAISHAEdFVrlD0jxKyM5zQLMrlcB/02LXtemSFlb+NA=; b=lZ4oPLkoM0XsCmrt2j2WvAGHL1dQG/d3o57V/EVGyuoIlE2nhCF7MQl928MJVH0Jco B1uGn+wlRSpHrdqwqT1YXoqQbuxsnaxfhxMwVzP+/LCIQkCLUAVEPGhIrmsp5Uvlf2VS Rer7OiIZaWVdhutyp72kufBp5jIxSn7EGHoDvjRG+wJFOUE/YmW/wI/7WUTKxrKzehjN mHATs9OZp3/JyUGouFPMx14VyCBtX9VbQfXcdkEYVQoKqTIW3WzK2Hq8wtRwT8SrV1FG PTi0Fwv/CqLR8G7G0mNrtIB2up9Hl1I7tDTKYsS/7zkjdM5B4Y/tou7OLR7Z9hVEvLgv 1xbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UAISHAEdFVrlD0jxKyM5zQLMrlcB/02LXtemSFlb+NA=; b=fh7Aa0GB/kZW38HTgF3tf0mW3iAMkp4hQTYwcHPJQYvaTI05BlhUl4Va2/GeG1CrfU ww20tAKd6E6kycwEfMjzXjqEH/Y5nfpEUDGiUWHATJeoi8TLSvivO5deC/v/W8Y+r+Mb 47qUOSvyOxOPAMFJtqyc92rcMvNniJcf679uSoFkTHCl7pNuc2VbJRXAFnXEOfS6WHiW 9gG38YnxV2Xp49BhiegaT2i95iosVkjImDRXo4yEmxvANTCT+Qth4CmVRkWqYD8JVwp+ kd93aPLaWMT1d3tVstLeTmXSQVcAupD5Q9rbAWc1v00jE99FhYPwt7GbKlbgzAnwXBKy z9tg== X-Gm-Message-State: AJIora+Hqsq6YA76gXIZ/WueBZjr8Rr4jKkO+lWBNkh+n1TLE4Wia073 rqh4LUxAPny3w20tVlYAZgh5yA== X-Google-Smtp-Source: AGRyM1tgVAG2WbRC05BYv5gYDhp3L3f7Xdrc/NVH4u3GitjcJDD4Nji3mEnw/+wi1a18EfPoBWHSSA== X-Received: by 2002:a05:6512:398e:b0:481:154b:a92 with SMTP id j14-20020a056512398e00b00481154b0a92mr5535358lfu.110.1657801517877; Thu, 14 Jul 2022 05:25:17 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id w1-20020a05651c118100b002554dce4048sm262276ljo.53.2022.07.14.05.25.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 05:25:15 -0700 (PDT) Message-ID: Date: Thu, 14 Jul 2022 14:25:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/2] pinctrl: nuvoton: add NPCM8XX pinctrl and GPIO driver Content-Language: en-US To: Tomer Maimon , avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, j.neuschaefer@gmx.net, zhengbin13@huawei.com Cc: openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220714122322.63663-1-tmaimon77@gmail.com> <20220714122322.63663-3-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220714122322.63663-3-tmaimon77@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 14/07/2022 14:23, Tomer Maimon wrote: > Add pinctrl and GPIO controller driver support to Arbel BMC NPCM8XX SoC. > > Arbel BMC NPCM8XX pinctrl driver based on Poleg NPCM7XX, except the > pin mux mapping difference the NPCM8XX GPIO supports adjust debounce > period time. > > Signed-off-by: Tomer Maimon > + > +static int npcm8xx_pinctrl_probe(struct platform_device *pdev) > +{ > + struct npcm8xx_pinctrl *pctrl; > + int ret; > + > + pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); > + if (!pctrl) > + return -ENOMEM; > + > + pctrl->dev = &pdev->dev; > + dev_set_drvdata(&pdev->dev, pctrl); > + > + pctrl->gcr_regmap = > + syscon_regmap_lookup_by_phandle(pctrl->dev->of_node, "nuvoton,sysgcr"); > + if (IS_ERR(pctrl->gcr_regmap)) > + return dev_err_probe(pctrl->dev, PTR_ERR(pctrl->gcr_regmap), "Failed to find nuvoton,sysgcr property\n"); Please wrap your code according to Linux coding style - @80. Best regards, Krzysztof