From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled Date: Thu, 17 Jan 2019 20:53:32 +0800 Message-ID: References: <1547724045-2726-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <1547724045-2726-6-git-send-email-makita.toshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1547724045-2726-6-git-send-email-makita.toshiaki@lab.ntt.co.jp> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Toshiaki Makita , "David S. Miller" , "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, Jesper Dangaard Brouer , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org Ck9uIDIwMTkvMS8xNyDkuIvljYg3OjIwLCBUb3NoaWFraSBNYWtpdGEgd3JvdGU6Cj4gQ29tbWl0 IDhkY2M1YjBhYjBlYyAoInZpcnRpb19uZXQ6IGZpeCBuZG9feGRwX3htaXQgY3Jhc2ggdG93YXJk cyBkZXYgbm90Cj4gcmVhZHkgZm9yIFhEUCIpIHRyaWVkIHRvIGF2b2lkIGFjY2VzcyB0byB1bmV4 cGVjdGVkIHNxIHdoaWxlIFhEUCBpcwo+IGRpc2FibGVkLCBidXQgd2FzIG5vdCBjb21wbGV0ZS4K Pgo+IFRoZXJlIHdhcyBhIHNtYWxsIHdpbmRvdyB3aGljaCBjYXVzZXMgb3V0IG9mIGJvdW5kcyBz cSBhY2Nlc3MgaW4KPiB2aXJ0bmV0X3hkcF94bWl0KCkgd2hpbGUgZGlzYWJsaW5nIFhEUC4KPgo+ IEFuIGV4YW1wbGUgY2FzZSBvZgo+ICAgLSBjdXJyX3F1ZXVlX3BhaXJzID0gNiAoMiBmb3IgU0tC IGFuZCA0IGZvciBYRFApCj4gICAtIG9ubGluZV9jcHVfbnVtID0geGRwX3F1ZXVlX3BhcmlzID0g NAo+IHdoZW4gWERQIGlzIGVuYWJsZWQ6Cj4KPiBDUFUgMCAgICAgICAgICAgICAgICAgICAgICAg ICBDUFUgMQo+IChEaXNhYmxpbmcgWERQKSAgICAgICAgICAgICAgIChQcm9jZXNzaW5nIHJlZGly ZWN0ZWQgWERQIGZyYW1lcykKPgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2aXJ0 bmV0X3hkcF94bWl0KCkKPiB2aXJ0bmV0X3hkcF9zZXQoKQo+ICAgX3ZpcnRuZXRfc2V0X3F1ZXVl cygpCj4gICAgc2V0IGN1cnJfcXVldWVfcGFpcnMgKDIpCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjaGVjayBpZiBycS0+eGRwX3Byb2cgaXMgbm90IE5VTEwKPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHZpcnRuZXRfeGRwX3NxKHZpKQo+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHFwID0gY3Vycl9xdWV1ZV9wYWlycyAtCj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB4ZHBfcXVldWVfcGFpcnMgKwo+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc21wX3Byb2Nlc3Nvcl9pZCgpCj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgPSAyIC0gNCArIDEgPSAtMQo+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNxID0gJnZpLT5zcVtxcF0gLy8gb3V0IG9mIGJvdW5kcyBh Y2Nlc3MKPiAgICBzZXQgeGRwX3F1ZXVlX3BhaXJzICgwKQo+ICAgIHJxLT54ZHBfcHJvZyA9IE5V TEwKPgo+IEJhc2ljYWxseSB3ZSBzaG91bGQgbm90IGNoYW5nZSBjdXJyX3F1ZXVlX3BhaXJzIGFu ZCB4ZHBfcXVldWVfcGFpcnMKPiB3aGlsZSBzb21lb25lIGNhbiByZWFkIHRoZSB2YWx1ZXMuIFRo dXMsIHdoZW4gZGlzYWJsaW5nIFhEUCwgYXNzaWduIE5VTEwKPiB0byBycS0+eGRwX3Byb2cgZmly c3QsIGFuZCB3YWl0IGZvciBSQ1UgZ3JhY2UgcGVyaW9kLCB0aGVuIGNoYW5nZQo+IHh4eF9xdWV1 ZV9wYWlycy4KPiBOb3RlIHRoYXQgd2UgbmVlZCB0byBrZWVwIHRoZSBjdXJyZW50IG9yZGVyIHdo ZW4gZW5hYmxpbmcgWERQIHRob3VnaC4KPgo+IEZpeGVzOiAxODZiM2M5OThjNTAgKCJ2aXJ0aW8t bmV0OiBzdXBwb3J0IFhEUF9SRURJUkVDVCIpCj4gU2lnbmVkLW9mZi1ieTogVG9zaGlha2kgTWFr aXRhIDxtYWtpdGEudG9zaGlha2lAbGFiLm50dC5jby5qcD4KCgpJIHdvbmRlciB3aGV0aGVyIG9y IG5vdCB3ZSBjb3VsZCBzaW1wbHkgZG86CgoKaWYgKHByb2cpIHsKCiDCoMKgwqAgcmN1X2Fzc2ln bl9wb2ludGVyKCkKCiDCoMKgwqAgc3luY2hyb25pemVfbmV0KCkKCn0KCnNldCBxdWV1ZXMKCmlm ICghcHJvZykgewoKIMKgwqDCoCByY3VfYXNzaWduX3BvaW50ZXIoKQoKfQoKVGhhbmtzCgoKPiAt LS0KPiAgIGRyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyB8IDMyICsrKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgNyBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMgYi9kcml2 ZXJzL25ldC92aXJ0aW9fbmV0LmMKPiBpbmRleCAyMDRlZWRmLi5hZTkzZjBlIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYwo+ICsrKyBiL2RyaXZlcnMvbmV0L3ZpcnRpb19u ZXQuYwo+IEBAIC0yNDI0LDE0ICsyNDI0LDE2IEBAIHN0YXRpYyBpbnQgdmlydG5ldF94ZHBfc2V0 KHN0cnVjdCBuZXRfZGV2aWNlICpkZXYsIHN0cnVjdCBicGZfcHJvZyAqcHJvZywKPiAgIAkJfQo+ ICAgCX0KPiAgIAo+IC0JZXJyID0gX3ZpcnRuZXRfc2V0X3F1ZXVlcyh2aSwgY3Vycl9xcCArIHhk cF9xcCk7Cj4gLQlpZiAoZXJyKQo+IC0JCWdvdG8gZXJyOwo+IC0JbmV0aWZfc2V0X3JlYWxfbnVt X3J4X3F1ZXVlcyhkZXYsIGN1cnJfcXAgKyB4ZHBfcXApOwo+IC0JdmktPnhkcF9xdWV1ZV9wYWly cyA9IHhkcF9xcDsKPiArCW9sZF9wcm9nID0gcnRubF9kZXJlZmVyZW5jZSh2aS0+cnFbMF0ueGRw X3Byb2cpOwo+ICsJaWYgKCFvbGRfcHJvZyAmJiBwcm9nKSB7Cj4gKwkJZXJyID0gX3ZpcnRuZXRf c2V0X3F1ZXVlcyh2aSwgY3Vycl9xcCArIHhkcF9xcCk7Cj4gKwkJaWYgKGVycikKPiArCQkJZ290 byBlcnJfbmV3X3Byb2c7Cj4gKwkJbmV0aWZfc2V0X3JlYWxfbnVtX3J4X3F1ZXVlcyhkZXYsIGN1 cnJfcXAgKyB4ZHBfcXApOwo+ICsJCXZpLT54ZHBfcXVldWVfcGFpcnMgPSB4ZHBfcXA7Cj4gKwl9 Cj4gICAKPiAgIAlmb3IgKGkgPSAwOyBpIDwgdmktPm1heF9xdWV1ZV9wYWlyczsgaSsrKSB7Cj4g LQkJb2xkX3Byb2cgPSBydG5sX2RlcmVmZXJlbmNlKHZpLT5ycVtpXS54ZHBfcHJvZyk7Cj4gICAJ CXJjdV9hc3NpZ25fcG9pbnRlcih2aS0+cnFbaV0ueGRwX3Byb2csIHByb2cpOwo+ICAgCQlpZiAo aSA9PSAwKSB7Cj4gICAJCQlpZiAoIW9sZF9wcm9nKQo+IEBAIC0yNDM5LDYgKzI0NDEsMTggQEAg c3RhdGljIGludCB2aXJ0bmV0X3hkcF9zZXQoc3RydWN0IG5ldF9kZXZpY2UgKmRldiwgc3RydWN0 IGJwZl9wcm9nICpwcm9nLAo+ICAgCQkJaWYgKCFwcm9nKQo+ICAgCQkJCXZpcnRuZXRfcmVzdG9y ZV9ndWVzdF9vZmZsb2Fkcyh2aSk7Cj4gICAJCX0KPiArCX0KPiArCj4gKwlpZiAob2xkX3Byb2cg JiYgIXByb2cpIHsKPiArCQlzeW5jaHJvbml6ZV9uZXQoKTsKPiArCQllcnIgPSBfdmlydG5ldF9z ZXRfcXVldWVzKHZpLCBjdXJyX3FwICsgeGRwX3FwKTsKPiArCQlpZiAoZXJyKQo+ICsJCQlnb3Rv IGVycl9vbGRfcHJvZzsKPiArCQluZXRpZl9zZXRfcmVhbF9udW1fcnhfcXVldWVzKGRldiwgY3Vy cl9xcCArIHhkcF9xcCk7Cj4gKwkJdmktPnhkcF9xdWV1ZV9wYWlycyA9IHhkcF9xcDsKPiArCX0K PiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgdmktPm1heF9xdWV1ZV9wYWlyczsgaSsrKSB7Cj4gICAJ CWlmIChvbGRfcHJvZykKPiAgIAkJCWJwZl9wcm9nX3B1dChvbGRfcHJvZyk7Cj4gICAJCWlmIChu ZXRpZl9ydW5uaW5nKGRldikpIHsKPiBAQCAtMjQ1MCw3ICsyNDY0LDExIEBAIHN0YXRpYyBpbnQg dmlydG5ldF94ZHBfc2V0KHN0cnVjdCBuZXRfZGV2aWNlICpkZXYsIHN0cnVjdCBicGZfcHJvZyAq cHJvZywKPiAgIAo+ICAgCXJldHVybiAwOwo+ICAgCj4gLWVycjoKPiArZXJyX29sZF9wcm9nOgo+ ICsJdmlydG5ldF9jbGVhcl9ndWVzdF9vZmZsb2Fkcyh2aSk7Cj4gKwlmb3IgKGkgPSAwOyBpIDwg dmktPm1heF9xdWV1ZV9wYWlyczsgaSsrKQo+ICsJCXJjdV9hc3NpZ25fcG9pbnRlcih2aS0+cnFb aV0ueGRwX3Byb2csIG9sZF9wcm9nKTsKPiArZXJyX25ld19wcm9nOgo+ICAgCWlmIChuZXRpZl9y dW5uaW5nKGRldikpIHsKPiAgIAkJZm9yIChpID0gMDsgaSA8IHZpLT5tYXhfcXVldWVfcGFpcnM7 IGkrKykgewo+ICAgCQkJdmlydG5ldF9uYXBpX2VuYWJsZSh2aS0+cnFbaV0udnEsICZ2aS0+cnFb aV0ubmFwaSk7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f ClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1m b3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9s aXN0aW5mby92aXJ0dWFsaXphdGlvbg==