From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC996C2BB41 for ; Tue, 16 Aug 2022 09:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8bUv/eAKvYnjr+mT4Lesv8Z+nba1uvb0/4zITW4lQV8=; b=xqRamHpP7WJn0o MbhGrh2Ua0a4PXaPjDEADX9S+JC35fjoE8/i8OruMtTFfn0ucQ60GMgV3U7Dz1m04Ey8AkyhAfURf ZvUuhhzfSrhDsjpT2CDXkRrpTMDNY4obthYX45F0AYKaYwVOURHDz77rsoJIqv+5nulp95B9UKrdp QsIskz31udPWAGKTCWrJ7ajfzdkVo1jLBl3MRE4l6Qff+xIOpBAOCg/q/wlPIxrZvgwcDHbGWnMtj QaeNbp1ic6jlXC4KSfPBvSVNchBTx21oPM2ryDtE2yQIZV/HWfijJ4y9yMf2WTmfr/IY9CbT3nYOL ICjyH+0/IfPvwoAdlL5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNsnQ-000Evt-7I; Tue, 16 Aug 2022 09:23:36 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNsnN-000EmT-Cu for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2022 09:23:34 +0000 Received: by mail-lf1-x135.google.com with SMTP id w5so14070021lfq.5 for ; Tue, 16 Aug 2022 02:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=xqmZkTjqkBszJr4LKjJt2ehtVUvSW3sFkYgqkkGWDf4=; b=yj+1nFMppjyZXIpFnjKZvFDRpcKZwm+a4RWh+1tgO9xkQqZ5ouieOYtGDdckwPCLkD uFNRzJohXUEtJkdoEMQud0/N66NTYI0UV0uWL9W2sOWN2DPcWtt6PVdBw5MjNIDJIYgz 7z1qS3BhvROOXNwNVdMCiNBn+hCwboOkqh+EliX/jOaVubo4IIFegvDhncPRP9id2YSy zJ2KMbORQuM3hcHWwWAxXLHMYeN11+ZOS0NSe132Auln0y3rEuRGL4zv++iOnJSGhjZc kbibfmoOvPb7P4Gyx7pJH4QHOwiW9cdScaGQsSqohEUl4AfB3xEzQnP61EQFQQFRh6Y2 8OPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=xqmZkTjqkBszJr4LKjJt2ehtVUvSW3sFkYgqkkGWDf4=; b=P+qBDLXVTIViMDhPPN465q5hU9DwMeesD+9oGxnADeom9lVOTNbA+wvjgS1ap5vm0f SSq9rEZ6RXGEOhJaDSJOyat7MvyF0b2IRXt5iLFKgzcdNe3PuNRAhiLhy5uyRQKqKzRb Tbhe5ABJvkR6Q1xm+6G9cjCKoVe3GhQf9wyrxgYrmE88DVxTVyj5NV/+RvkwJuxYjmD7 c4rg9wcFRFvFFMc/jGh6tMP5iIA7P3wXxPsQX4KXkE4fDJz8EvdZytbxjTlioGKMCKej NIvK3G3RRmAfdl11n8zNQOmLf/VAoiWoa2XE9XuTek72WZ+k9WTeKls8M52GAmMGuLd2 j9Tw== X-Gm-Message-State: ACgBeo3HrRNceRNXUppuWvip0zfvsz1tiibTamA/MdS3nMNW2XSFbwq4 p8MlmqUKTiiiG+fxu5Mul0mOMg== X-Google-Smtp-Source: AA6agR5+nNwI8d3IuOAHqLUOx1QI0JR8HQgP2AKO07DOADBkCQC3TdTrDgt0+LLhBk+z2F6rApxi6Q== X-Received: by 2002:a19:5e02:0:b0:48b:1870:dc4 with SMTP id s2-20020a195e02000000b0048b18700dc4mr7462376lfb.4.1660641809597; Tue, 16 Aug 2022 02:23:29 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id x25-20020a056512131900b0048a0e948c34sm1325631lfu.195.2022.08.16.02.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 02:23:29 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 12:23:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them Content-Language: en-US From: Krzysztof Kozlowski To: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Linus Walleij Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> In-Reply-To: <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_022333_522844_F3E088A3 X-CRM114-Status: GOOD ( 10.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/07/2022 11:32, Krzysztof Kozlowski wrote: > On 27/07/2022 03:33, Saravana Kannan wrote: >> As soon as a gpio is registered, it should be usable by a consumer. So, >> do all the initialization before registering the gpios. Without this >> change, a consumer can request a GPIO IRQ and have the gpio to IRQ >> mapping fail. >> >> Signed-off-by: Saravana Kannan > > Looks good. > > Linus, > It's too late for me to pick it up, so make you could grab it directly? > > Reviewed-by: Krzysztof Kozlowski > > Otherwise it will wait for merge window to finish. Applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C28CC2BB41 for ; Tue, 16 Aug 2022 10:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234732AbiHPKdq (ORCPT ); Tue, 16 Aug 2022 06:33:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234757AbiHPKdV (ORCPT ); Tue, 16 Aug 2022 06:33:21 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A5FB58B68 for ; Tue, 16 Aug 2022 02:23:31 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id o2so14089700lfb.1 for ; Tue, 16 Aug 2022 02:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=xqmZkTjqkBszJr4LKjJt2ehtVUvSW3sFkYgqkkGWDf4=; b=yj+1nFMppjyZXIpFnjKZvFDRpcKZwm+a4RWh+1tgO9xkQqZ5ouieOYtGDdckwPCLkD uFNRzJohXUEtJkdoEMQud0/N66NTYI0UV0uWL9W2sOWN2DPcWtt6PVdBw5MjNIDJIYgz 7z1qS3BhvROOXNwNVdMCiNBn+hCwboOkqh+EliX/jOaVubo4IIFegvDhncPRP9id2YSy zJ2KMbORQuM3hcHWwWAxXLHMYeN11+ZOS0NSe132Auln0y3rEuRGL4zv++iOnJSGhjZc kbibfmoOvPb7P4Gyx7pJH4QHOwiW9cdScaGQsSqohEUl4AfB3xEzQnP61EQFQQFRh6Y2 8OPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=xqmZkTjqkBszJr4LKjJt2ehtVUvSW3sFkYgqkkGWDf4=; b=paSyIcmwpEQGhSLBycvbWzDavFu/zuL/L+osN6yQRzF11TvMUPVGAF6P/O4S72L11b fBwvaMkuXCUPpsyjp/Ya/WnXgjz50tNDfEz7Ad120yqilW+gvs2FeqoSng327U5DUv1+ zKxmH7TFAmSI/THJkcucpFx6tFkKQzqYvioh9ymT2uRTYCRTA3Pwc1u0vFT+I5R5DXOn xB+F5UEbHxpq+iR37uTGhDGRrTWyfqTIfz+PKWwOcPmrf8mzq4fNOAk4wMKjbWlnEEBj two76/6bR56g9Py+8HiNRfBfkV8XOTTdd2zMsKydIBSEIFrJf4hMrr3X8ILleWH72ibS eItQ== X-Gm-Message-State: ACgBeo0mVdhOnYAAv7RSD3ONpngAFarMLmikrTzv33xJfd3bBniiDesI Rdc00l/B0eB5U2w8h5hXTrJYDw== X-Google-Smtp-Source: AA6agR5+nNwI8d3IuOAHqLUOx1QI0JR8HQgP2AKO07DOADBkCQC3TdTrDgt0+LLhBk+z2F6rApxi6Q== X-Received: by 2002:a19:5e02:0:b0:48b:1870:dc4 with SMTP id s2-20020a195e02000000b0048b18700dc4mr7462376lfb.4.1660641809597; Tue, 16 Aug 2022 02:23:29 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id x25-20020a056512131900b0048a0e948c34sm1325631lfu.195.2022.08.16.02.23.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 02:23:29 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 12:23:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them Content-Language: en-US From: Krzysztof Kozlowski To: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Linus Walleij Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220727013349.3056826-1-saravanak@google.com> <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> In-Reply-To: <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 28/07/2022 11:32, Krzysztof Kozlowski wrote: > On 27/07/2022 03:33, Saravana Kannan wrote: >> As soon as a gpio is registered, it should be usable by a consumer. So, >> do all the initialization before registering the gpios. Without this >> change, a consumer can request a GPIO IRQ and have the gpio to IRQ >> mapping fail. >> >> Signed-off-by: Saravana Kannan > > Looks good. > > Linus, > It's too late for me to pick it up, so make you could grab it directly? > > Reviewed-by: Krzysztof Kozlowski > > Otherwise it will wait for merge window to finish. Applied. Best regards, Krzysztof