From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8F1C2D0DB for ; Tue, 28 Jan 2020 19:28:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EF552467E for ; Tue, 28 Jan 2020 19:28:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726192AbgA1T2Q (ORCPT ); Tue, 28 Jan 2020 14:28:16 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:2324 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726162AbgA1T2Q (ORCPT ); Tue, 28 Jan 2020 14:28:16 -0500 Received: from lhreml705-cah.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id DCEEB7FA2427FC51A8A0; Tue, 28 Jan 2020 19:28:12 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by lhreml705-cah.china.huawei.com (10.201.108.46) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 28 Jan 2020 19:28:12 +0000 Received: from [127.0.0.1] (10.210.167.110) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 28 Jan 2020 19:28:11 +0000 Subject: Re: [PATCH RFC 2/2] soc: Add a basic ACPI generic driver To: "Rafael J. Wysocki" CC: Olof Johansson , "Rafael J. Wysocki" , Len Brown , Jeremy Linton , "Arnd Bergmann" , Linux Kernel Mailing List , ACPI Devel Maling List , Hanjun Guo , "Greg Kroah-Hartman" References: <1580210059-199540-1-git-send-email-john.garry@huawei.com> <1580210059-199540-3-git-send-email-john.garry@huawei.com> <4c6462e3-e368-bd9f-260f-e8351c85bcc2@huawei.com> From: John Garry Message-ID: Date: Tue, 28 Jan 2020 19:28:11 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.210.167.110] X-ClientProxiedBy: lhreml712-chm.china.huawei.com (10.201.108.63) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org >>>> >>>> Signed-off-by: John Garry >>>> --- >>>> drivers/soc/Makefile | 1 + >>>> drivers/soc/acpi_generic.c | 102 +++++++++++++++++++++++++++++++++++++ >>>> 2 files changed, 103 insertions(+) >>>> create mode 100644 drivers/soc/acpi_generic.c >>>> >>>> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile >>>> index 8b49d782a1ab..2a59a30a22cd 100644 >>>> --- a/drivers/soc/Makefile >>>> +++ b/drivers/soc/Makefile >>>> @@ -3,6 +3,7 @@ >>>> # Makefile for the Linux Kernel SOC specific device drivers. >>>> # >>>> >>>> +obj-$(CONFIG_ACPI_PPTT) += acpi_generic.o >>>> obj-$(CONFIG_ARCH_ACTIONS) += actions/ >>>> obj-$(CONFIG_SOC_ASPEED) += aspeed/ >>>> obj-$(CONFIG_ARCH_AT91) += atmel/ >>> >>> Based on everything I've seen so far, this should go under drivers/acpi instead. >> >> soc drivers seem to live in drivers/soc (non-arm32, anyway), so I >> decided on this location. But drivers/acpi would also seem reasonable now. > Hi Rafael, > Any reasons for not putting it into drivers/acpi/pptt.c specifically? > . I don't think so. One thing is that the code does a one-time scan of the PPTT to find all processor package nodes with ID structures to register the soc devices - so we would need some new call from from acpi_init() for that. Thanks, John