Re: [PATCH] io_uring: undeprecate epoll_ctl support

[Pavel Begunkov <asml.silence@gmail.com>]

On 5/1/23 19:52, Ben Noordhuis wrote:
> Libuv recently started using it so there is at least one consumer now.

It was rather deprecated because io_uring controlling epoll is a bad
idea and should never be used. One reason is that it means libuv still
uses epoll but not io_uring, and so the use of io_uring wouldn't seem
to make much sense. You're welcome to prove me wrong on that, why libuv
decided to use a deprecated API in the first place?
Sorry, but the warning is going to stay and libuv should revert the use
of epol_ctl requests.


> Link: https://github.com/libuv/libuv/pull/3979
> ---
>   io_uring/epoll.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/io_uring/epoll.c b/io_uring/epoll.c
> index 9aa74d2c80bc..89bff2068a19 100644
> --- a/io_uring/epoll.c
> +++ b/io_uring/epoll.c
> @@ -25,10 +25,6 @@ int io_epoll_ctl_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
>   {
>   	struct io_epoll *epoll = io_kiocb_to_cmd(req, struct io_epoll);
>   
> -	pr_warn_once("%s: epoll_ctl support in io_uring is deprecated and will "
> -		     "be removed in a future Linux kernel version.\n",
> -		     current->comm);
> -
>   	if (sqe->buf_index || sqe->splice_fd_in)
>   		return -EINVAL;
>   

-- 
Pavel Begunkov