From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABDBC433E6 for ; Tue, 9 Mar 2021 15:48:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C94FE652BC for ; Tue, 9 Mar 2021 15:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbhCIPsH (ORCPT ); Tue, 9 Mar 2021 10:48:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231239AbhCIPrq (ORCPT ); Tue, 9 Mar 2021 10:47:46 -0500 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AB1FC06174A; Tue, 9 Mar 2021 07:47:46 -0800 (PST) Received: by mail-pl1-x634.google.com with SMTP id w7so3284014pll.8; Tue, 09 Mar 2021 07:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SdbWLauHZPc6u4Mx3ysIBEeU7QGCIx7AKGpPTrmJ2E8=; b=dgeqe78ksFCHm0AeSIQvZRcc2aFaU8fG+MkkEGnfiD27B0RiMcutVkm4UOxJ7aaPAt EyoEa+megMMCmPYPH6xXnE4dqeqOkpdfp3OaA6dnxaFvjzGUbv+vDJ7w/8LSktscmLNy 8cy9FrgaeuAt0LTNZQ4bL8RX3AC2Gj2DUcl6aJaZKp7tdzzNcdy+4AlFVgCqfutp2gQ0 rNxmg6+Iat1pVHFZvMs/Hm77fUGfSBoUr0l5lNSNYrp7ZJYka7Vgz2XwROZx9lDAT9D8 FcBfEpxpDrf9Gp0Oowur60Sn6yyKOLQg/ERnmeKcTkqUV5HCTsdMM5jIEBWFN4GCpd4M 9L7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SdbWLauHZPc6u4Mx3ysIBEeU7QGCIx7AKGpPTrmJ2E8=; b=uc8W6qDjLGpPwx2jQ0Yy99KMiBiSSMophcUFuzGRVkBtDKU8wELlmkFAbUiJUkjEDa z34g72eSWRSRm0I9pm6/OZ8wy8obrGrfiZJSDBT1HzuPcznuUJMeoim1nDjOIjo9kV/J TPbPxhD9bq2dBlE8Pr62CixcdOiPW3kimj6euZnbkefjTua2obu2yVoG3vPLxWARVF3c y67zMGZvvFvRMqCZ1F+Bwt+wZm7Hb23uBLtW3H/J0EFEyYyzmVab55iqoUFDKciA+vg/ nMVg027TLKypuMNTqCaNfj0GC+IW7gfgYMXaE5f9QWE3bFoWPO5hP5ymz1OSgBuamtxm CsrA== X-Gm-Message-State: AOAM531eZgQYPVVIAbndSB8JIb47sQ34BamjBivP00dejX2gjivFBqxo d0To6jbFecUcZ4K+X8bFcBw= X-Google-Smtp-Source: ABdhPJzCQ9iSADJ6pw37Q4ShFb6QS8konk8Lyxo/7WHyubZZ3LpshUbzYh0qlp0OooUCrjN6N9lATA== X-Received: by 2002:a17:90b:4b87:: with SMTP id lr7mr5007612pjb.5.1615304865772; Tue, 09 Mar 2021 07:47:45 -0800 (PST) Received: from [172.30.1.19] ([14.32.163.5]) by smtp.gmail.com with ESMTPSA id w18sm3280866pjh.19.2021.03.09.07.47.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 07:47:43 -0800 (PST) Subject: Re: [PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target To: Dong Aisheng , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, abel.vesa@nxp.com References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-5-git-send-email-aisheng.dong@nxp.com> From: Chanwoo Choi Message-ID: Date: Wed, 10 Mar 2021 00:47:39 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1615294733-22761-5-git-send-email-aisheng.dong@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21. 3. 9. 오후 9:58, Dong Aisheng wrote: > It's unnecessary to set the same freq again and run notifier calls. > > Signed-off-by: Dong Aisheng > --- > drivers/devfreq/devfreq.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index bf3047896e41..6e80bf70e7b3 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -358,6 +358,9 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, > else > cur_freq = devfreq->previous_freq; > > + if (new_freq == cur_freq) > + return 0; > + > freqs.old = cur_freq; > freqs.new = new_freq; > devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE); > @@ -374,7 +377,7 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq, > * and DEVFREQ_POSTCHANGE because for showing the correct frequency > * change order of between devfreq device and passive devfreq device. > */ > - if (trace_devfreq_frequency_enabled() && new_freq != cur_freq) > + if (trace_devfreq_frequency_enabled()) > trace_devfreq_frequency(devfreq, new_freq, cur_freq); > > freqs.new = new_freq; > I'd like you to squash patch4 with patch6 because actually patch6 is too minor clean-up. I think it is possible. -- Best Regards, Samsung Electronics Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F51C433DB for ; Tue, 9 Mar 2021 15:49:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49B776523F for ; Tue, 9 Mar 2021 15:49:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49B776523F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OXperrd0dLXp423/0DIkfc7zpIA5w/eN3rnabDpXCWQ=; b=IoMCo22FryGhX8zzMHKRSha37 aX5qO3Jr9nUMpPOocaCBX5AEGbutK3RxxpifKCx89BkorblbIIyGcctiYJ+YyfXasR9+arMYdobch v3BDJEAxTs/hsSjQI3Lgdy2YouO44hKkYJrteWQRqy80bRPGpxgCUbV0AiNhCi2jn4GVx7OatQDE0 Cr3ceUrynJu8S3HkU+UGtv6yfbieBnhSDvVDPEX3AaVMYw0xI9ZK6gqqz+cpfZOK+RLZwiuuHxmk9 xDC2QMa0ZYYINkAh22SB9AL7FKm9lANy0QNSFegRWaCxmRqVS/VKUI44x8XdGOdEDn6BFiBNRcod9 5R68KAoTg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJeaO-004zfU-1j; Tue, 09 Mar 2021 15:47:52 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJeaJ-004zeS-8R for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 15:47:50 +0000 Received: by mail-pl1-x634.google.com with SMTP id a8so259877plp.13 for ; Tue, 09 Mar 2021 07:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SdbWLauHZPc6u4Mx3ysIBEeU7QGCIx7AKGpPTrmJ2E8=; b=dgeqe78ksFCHm0AeSIQvZRcc2aFaU8fG+MkkEGnfiD27B0RiMcutVkm4UOxJ7aaPAt EyoEa+megMMCmPYPH6xXnE4dqeqOkpdfp3OaA6dnxaFvjzGUbv+vDJ7w/8LSktscmLNy 8cy9FrgaeuAt0LTNZQ4bL8RX3AC2Gj2DUcl6aJaZKp7tdzzNcdy+4AlFVgCqfutp2gQ0 rNxmg6+Iat1pVHFZvMs/Hm77fUGfSBoUr0l5lNSNYrp7ZJYka7Vgz2XwROZx9lDAT9D8 FcBfEpxpDrf9Gp0Oowur60Sn6yyKOLQg/ERnmeKcTkqUV5HCTsdMM5jIEBWFN4GCpd4M 9L7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SdbWLauHZPc6u4Mx3ysIBEeU7QGCIx7AKGpPTrmJ2E8=; b=Zt4CyblOlJ/5MVZxD/AopzMCgEQAKLNDTni+N5Ek7e/jfTduvhdUbp3ZYRXAlk8pOv JlYp0aZ1vqFUxqPMH6iIawicBEEwnVOPhznCKTdmdh19dVOPvYI1t6BbFe6MDkY1qKo+ IMQEoOkUzyL+eTE+31qjKIy2h5jWv+UOpXjjLPzUeQ3IVr07Q8Y8Bq/0+DjMXvvZObMy Ta5DdtqF8DkkSsbbhDBfBPw9uCUls1M0KvCBOoc6P5nxuYxZSIZV9A+ULPn7NRj1+yAe vxK6tTgYyg8Br+rxak9Y/yjg5xpOCmm2ocqoK7VZYFezhF3G8mB7XxiAqcshC+lSa/uc 0YgQ== X-Gm-Message-State: AOAM532xaZ9Y0ZWGPLn7Fajl8QdGoQ8QECPeMDxXXkC+TuIeM745UX4V Pnf4fKvcGxxGxNuVt0g0EOo= X-Google-Smtp-Source: ABdhPJzCQ9iSADJ6pw37Q4ShFb6QS8konk8Lyxo/7WHyubZZ3LpshUbzYh0qlp0OooUCrjN6N9lATA== X-Received: by 2002:a17:90b:4b87:: with SMTP id lr7mr5007612pjb.5.1615304865772; Tue, 09 Mar 2021 07:47:45 -0800 (PST) Received: from [172.30.1.19] ([14.32.163.5]) by smtp.gmail.com with ESMTPSA id w18sm3280866pjh.19.2021.03.09.07.47.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 07:47:43 -0800 (PST) Subject: Re: [PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target To: Dong Aisheng , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, abel.vesa@nxp.com References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com> <1615294733-22761-5-git-send-email-aisheng.dong@nxp.com> From: Chanwoo Choi Message-ID: Date: Wed, 10 Mar 2021 00:47:39 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1615294733-22761-5-git-send-email-aisheng.dong@nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_154747_373457_E669FFF5 X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjEuIDMuIDkuIOyYpO2bhCA5OjU4LCBEb25nIEFpc2hlbmcgd3JvdGU6Cj4gSXQncyB1bm5l Y2Vzc2FyeSB0byBzZXQgdGhlIHNhbWUgZnJlcSBhZ2FpbiBhbmQgcnVuIG5vdGlmaWVyIGNhbGxz Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IERvbmcgQWlzaGVuZyA8YWlzaGVuZy5kb25nQG54cC5jb20+ Cj4gLS0tCj4gICBkcml2ZXJzL2RldmZyZXEvZGV2ZnJlcS5jIHwgNSArKysrLQo+ICAgMSBmaWxl IGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2RldmZyZXEvZGV2ZnJlcS5jIGIvZHJpdmVycy9kZXZmcmVxL2RldmZyZXEuYwo+ IGluZGV4IGJmMzA0Nzg5NmU0MS4uNmU4MGJmNzBlN2IzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv ZGV2ZnJlcS9kZXZmcmVxLmMKPiArKysgYi9kcml2ZXJzL2RldmZyZXEvZGV2ZnJlcS5jCj4gQEAg LTM1OCw2ICszNTgsOSBAQCBzdGF0aWMgaW50IGRldmZyZXFfc2V0X3RhcmdldChzdHJ1Y3QgZGV2 ZnJlcSAqZGV2ZnJlcSwgdW5zaWduZWQgbG9uZyBuZXdfZnJlcSwKPiAgIAllbHNlCj4gICAJCWN1 cl9mcmVxID0gZGV2ZnJlcS0+cHJldmlvdXNfZnJlcTsKPiAgIAo+ICsJaWYgKG5ld19mcmVxID09 IGN1cl9mcmVxKQo+ICsJCXJldHVybiAwOwo+ICsKPiAgIAlmcmVxcy5vbGQgPSBjdXJfZnJlcTsK PiAgIAlmcmVxcy5uZXcgPSBuZXdfZnJlcTsKPiAgIAlkZXZmcmVxX25vdGlmeV90cmFuc2l0aW9u KGRldmZyZXEsICZmcmVxcywgREVWRlJFUV9QUkVDSEFOR0UpOwo+IEBAIC0zNzQsNyArMzc3LDcg QEAgc3RhdGljIGludCBkZXZmcmVxX3NldF90YXJnZXQoc3RydWN0IGRldmZyZXEgKmRldmZyZXEs IHVuc2lnbmVkIGxvbmcgbmV3X2ZyZXEsCj4gICAJICogYW5kIERFVkZSRVFfUE9TVENIQU5HRSBi ZWNhdXNlIGZvciBzaG93aW5nIHRoZSBjb3JyZWN0IGZyZXF1ZW5jeQo+ICAgCSAqIGNoYW5nZSBv cmRlciBvZiBiZXR3ZWVuIGRldmZyZXEgZGV2aWNlIGFuZCBwYXNzaXZlIGRldmZyZXEgZGV2aWNl Lgo+ICAgCSAqLwo+IC0JaWYgKHRyYWNlX2RldmZyZXFfZnJlcXVlbmN5X2VuYWJsZWQoKSAmJiBu ZXdfZnJlcSAhPSBjdXJfZnJlcSkKPiArCWlmICh0cmFjZV9kZXZmcmVxX2ZyZXF1ZW5jeV9lbmFi bGVkKCkpCj4gICAJCXRyYWNlX2RldmZyZXFfZnJlcXVlbmN5KGRldmZyZXEsIG5ld19mcmVxLCBj dXJfZnJlcSk7Cj4gICAKPiAgIAlmcmVxcy5uZXcgPSBuZXdfZnJlcTsKPiAKCkknZCBsaWtlIHlv dSB0byBzcXVhc2ggcGF0Y2g0IHdpdGggcGF0Y2g2IGJlY2F1c2UgYWN0dWFsbHkgcGF0Y2g2Cmlz IHRvbyBtaW5vciBjbGVhbi11cC4gSSB0aGluayBpdCBpcyBwb3NzaWJsZS4KCi0tIApCZXN0IFJl Z2FyZHMsClNhbXN1bmcgRWxlY3Ryb25pY3MKQ2hhbndvbyBDaG9pCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==