From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281CBC433DB for ; Sat, 27 Mar 2021 18:38:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF147619A9 for ; Sat, 27 Mar 2021 18:38:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF147619A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQDpX-0000Dq-0L for qemu-devel@archiver.kernel.org; Sat, 27 Mar 2021 14:38:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQDoD-0007fz-6e; Sat, 27 Mar 2021 14:37:18 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:37495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQDo5-0006NE-9R; Sat, 27 Mar 2021 14:37:14 -0400 Received: by mail-wr1-x42c.google.com with SMTP id x16so8759168wrn.4; Sat, 27 Mar 2021 11:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QxNO4XDvkT9FMi+UP4pSAZyqhg7ONEmD8dffWxx44Os=; b=qsybwEIIGMudad86HfngMyud+3zjsSVubmpSz+96TZfAS/BXE4+0I0SYss82dpkBwE ERHuJ2uHG8FJ1+wQhgXdky9R/XwF9z8Eh8LrXmLy6SIUDX6gfujG9NmyAxpbgkO6vN03 FJzVDNw3nzyZWgMtijwb8F8Lujsj1ZOi9ion1iuvSSMKU6tvjvcGP0VIym1u681cJs8e rM7LtU0au0Q1La2IiBGNgKUIvh3pVfsBD0XyYpddTWVx1+ReDmQt7Znh/KkZlCgfClDk 73recon9vIfjXGeKxvnSOiVrURWBUqDDwxPtzZsAHrbEEY88HAC9hlCjQ6Hss919Azax bXAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QxNO4XDvkT9FMi+UP4pSAZyqhg7ONEmD8dffWxx44Os=; b=PtoUQ7aE6xwBjbEsEa94j7dRr+eEqObJ7Z17UUpYVxlzDEzyjJHn9FItPKXTf3cJ3Z Wx6iQFhetWt8P3emUgmKj3mviE9d5ILpLrJEuN0m/Os5HffSTp7PyeowSmaz17Cmglk8 CQ+yiQ0QNbeEZXodwYz/wcq7Vut2LCDWb4t6alnmK/uNd0LAKblxC3KK6LlLGpyGNqZB 8BPkUdJIPnsbm6stQ3iQrpRF/VDBFy7GFx+5IysWGJPX65RO+KJKd2By4imDQb1203bK kMWa7JznxUmZok5uTqYK4ffqSsy91bsDwuire89Qsqvoem/5OhAtTr2KsczWjvL8XEUd KN7g== X-Gm-Message-State: AOAM532rA44Z6L9umFkuQhHkZ+IqJeFHkcraKDDNf5ZQbKGhUeOZIOJh 2KHokGACOC032T+ug4E9oYK3zWqTHHxtBw== X-Google-Smtp-Source: ABdhPJyrH1jhcJ/OAvTPDlVlBw1H1OW4v9+RhuYbUA5uUYeevkpuYaSdSJWmMjHCa45uuPucnqAzCA== X-Received: by 2002:adf:b30f:: with SMTP id j15mr20677270wrd.132.1616870226743; Sat, 27 Mar 2021 11:37:06 -0700 (PDT) Received: from [192.168.1.36] (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id c131sm17876991wma.37.2021.03.27.11.37.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Mar 2021 11:37:06 -0700 (PDT) Subject: Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Thomas Huth , qemu-devel@nongnu.org References: <20210327082804.2259480-1-thuth@redhat.com> <39afc328-73bc-2168-52a7-44914a87a799@amsat.org> Message-ID: Date: Sat, 27 Mar 2021 19:37:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <39afc328-73bc-2168-52a7-44914a87a799@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/27/21 7:35 PM, Philippe Mathieu-Daudé wrote: > On 3/27/21 7:19 PM, Thomas Huth wrote: >> On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote: >>> Hi Thomas, >>> >>> 6 more candidates? >> >> No, since those use TYPE_SYS_BUS_DEVICE and thus require hw/sysbus.h. > > Ah indeed, this line matches your patch changes: > > $ git grep -l '#include "hw/sysbus.h"' hw \ > | xargs git grep -L sysbus_ \ > | xargs git grep -L 'SysBusDevice\s\+\w' \ > | xargs grep -L SYS_BUS_DEVICE I missed the 'git' while copy/pasting, I meant: | xargs git grep -L SYS_BUS_DEVICE > > Reviewed-by: Philippe Mathieu-Daudé >