All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, "Denis V . Lunev" <den@openvz.org>,
	Alberto Garcia <berto@igalia.com>
Subject: [Qemu-devel] [PATCH 23/31] qcow2: Update zero_single_l2() to support L2 slices
Date: Thu, 12 Oct 2017 16:05:37 +0300	[thread overview]
Message-ID: <b6f4aa2c89b444aa4efee96acbe0ddde209b8079.1507813391.git.berto@igalia.com> (raw)
In-Reply-To: <cover.1507813391.git.berto@igalia.com>
In-Reply-To: <cover.1507813391.git.berto@igalia.com>

zero_single_l2() limits the number of clusters to be zeroed to the
amount that fits inside an L2 table. Since we'll be loading L2 slices
instead of full tables we need to update that limit.

Apart from that, this function doesn't need any additional changes, so
this patch simply updates the variable name from l2_table to l2_slice.

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 block/qcow2-cluster.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 536077079b..9909c06c24 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -1741,33 +1741,33 @@ fail:
 
 /*
  * This zeroes as many clusters of nb_clusters as possible at once (i.e.
- * all clusters in the same L2 table) and returns the number of zeroed
+ * all clusters in the same L2 slice) and returns the number of zeroed
  * clusters.
  */
 static int zero_single_l2(BlockDriverState *bs, uint64_t offset,
                           uint64_t nb_clusters, int flags)
 {
     BDRVQcow2State *s = bs->opaque;
-    uint64_t *l2_table;
+    uint64_t *l2_slice;
     int l2_index;
     int ret;
     int i;
     bool unmap = !!(flags & BDRV_REQ_MAY_UNMAP);
 
-    ret = get_cluster_table(bs, offset, &l2_table, &l2_index);
+    ret = get_cluster_table(bs, offset, &l2_slice, &l2_index);
     if (ret < 0) {
         return ret;
     }
 
-    /* Limit nb_clusters to one L2 table */
-    nb_clusters = MIN(nb_clusters, s->l2_size - l2_index);
+    /* Limit nb_clusters to one L2 slice */
+    nb_clusters = MIN(nb_clusters, s->l2_slice_size - l2_index);
     assert(nb_clusters <= INT_MAX);
 
     for (i = 0; i < nb_clusters; i++) {
         uint64_t old_offset;
         QCow2ClusterType cluster_type;
 
-        old_offset = be64_to_cpu(l2_table[l2_index + i]);
+        old_offset = be64_to_cpu(l2_slice[l2_index + i]);
 
         /*
          * Minimize L2 changes if the cluster already reads back as
@@ -1779,16 +1779,16 @@ static int zero_single_l2(BlockDriverState *bs, uint64_t offset,
             continue;
         }
 
-        qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_table);
+        qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
         if (cluster_type == QCOW2_CLUSTER_COMPRESSED || unmap) {
-            l2_table[l2_index + i] = cpu_to_be64(QCOW_OFLAG_ZERO);
+            l2_slice[l2_index + i] = cpu_to_be64(QCOW_OFLAG_ZERO);
             qcow2_free_any_clusters(bs, old_offset, 1, QCOW2_DISCARD_REQUEST);
         } else {
-            l2_table[l2_index + i] |= cpu_to_be64(QCOW_OFLAG_ZERO);
+            l2_slice[l2_index + i] |= cpu_to_be64(QCOW_OFLAG_ZERO);
         }
     }
 
-    qcow2_cache_put(s->l2_table_cache, (void **) &l2_table);
+    qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
 
     return nb_clusters;
 }
-- 
2.11.0

  parent reply	other threads:[~2017-10-12 13:11 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 13:05 [Qemu-devel] [PATCH 00/31] Allow configuring the qcow2 L2 cache entry size Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 01/31] qcow2: Fix documentation of get_cluster_table() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 02/31] qcow2: Add table size field to Qcow2Cache Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 03/31] qcow2: Remove BDS parameter from qcow2_cache_get_table_addr() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 04/31] qcow2: Remove BDS parameter from qcow2_cache_get_table_idx() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 05/31] qcow2: Remove BDS parameter from qcow2_cache_table_release() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 06/31] qcow2: Remove BDS parameter from qcow2_cache_entry_mark_dirty() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 07/31] qcow2: Remove BDS parameter from qcow2_cache_put() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 08/31] qcow2: Remove BDS parameter from qcow2_cache_destroy() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 09/31] qcow2: Remove BDS parameter from qcow2_cache_clean_unused() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 10/31] qcow2: Remove BDS parameter from qcow2_cache_discard() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 11/31] qcow2: Remove BDS parameter from qcow2_cache_is_table_offset() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 12/31] qcow2: Add offset_to_l1_index() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 13/31] qcow2: Add l2_slice_size field to BDRVQcow2State Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 14/31] qcow2: Add offset_to_l2_slice_index() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 15/31] qcow2: Update l2_load() to support L2 slices Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 16/31] qcow2: Update l2_allocate() " Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 17/31] qcow2: Update get_cluster_table() " Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 18/31] qcow2: Update qcow2_get_cluster_offset() " Alberto Garcia
2017-10-13 12:52   ` Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 19/31] qcow2: Update qcow2_alloc_cluster_link_l2() " Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 20/31] qcow2: Update handle_copied() " Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 21/31] qcow2: Update handle_alloc() " Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 22/31] qcow2: Update discard_single_l2() " Alberto Garcia
2017-10-12 13:05 ` Alberto Garcia [this message]
2017-10-12 13:05 ` [Qemu-devel] [PATCH 24/31] qcow2: Update qcow2_update_snapshot_refcount() " Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 25/31] qcow2: Update expand_zero_clusters_in_l1() " Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 26/31] qcow2: Update qcow2_truncate() " Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 27/31] qcow2: Rename l2_table in qcow2_alloc_compressed_cluster_offset() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 28/31] qcow2: Rename l2_table in count_contiguous_clusters() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 29/31] qcow2: Rename l2_table in count_contiguous_clusters_unallocated() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 30/31] qcow2: Rename l2_table in count_cow_clusters() Alberto Garcia
2017-10-12 13:05 ` [Qemu-devel] [PATCH 31/31] qcow2: Allow configuring the L2 slice size Alberto Garcia
2017-10-12 13:42 ` [Qemu-devel] [PATCH 00/31] Allow configuring the qcow2 L2 cache entry size no-reply
2017-10-12 14:02 ` no-reply
2017-10-12 14:11   ` Eric Blake
2017-10-12 16:44     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6f4aa2c89b444aa4efee96acbe0ddde209b8079.1507813391.git.berto@igalia.com \
    --to=berto@igalia.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.