From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D49C282C3 for ; Wed, 23 Jan 2019 01:39:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9873D21726 for ; Wed, 23 Jan 2019 01:39:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfAWBj1 (ORCPT ); Tue, 22 Jan 2019 20:39:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:40532 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726885AbfAWBj0 (ORCPT ); Tue, 22 Jan 2019 20:39:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5D9E2ABCB; Wed, 23 Jan 2019 01:39:25 +0000 (UTC) Subject: Re: [PATCH] bcache: never writeback a discard operation To: Daniel Axtens , Sasha Levin Cc: "Guilherme G . Piccoli" , Michael Lyle , Kent Overstreet , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-bcache@vger.kernel.org References: <20190118051825.18196-1-dja@axtens.net> <20190122155556.478CB217D6@mail.kernel.org> <87womwp71z.fsf@linkitivity.dja.id.au> From: Coly Li Openpgp: preference=signencrypt Organization: SUSE Labs Message-ID: Date: Wed, 23 Jan 2019 09:39:15 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <87womwp71z.fsf@linkitivity.dja.id.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org 在 2019/1/23 上午8:10, Daniel Axtens 写道: > Hi Sasha, > >> This commit has been processed because it contains a "Fixes:" tag, >> fixing commit: 72c270612bd3 bcache: Write out full stripes. > > I added that fixes tag because that was the commit that added the > code. However, I noticed that one of the bug reports mentions that the > problem only arising after v4.8. [1] I don't quite know what to make of > this: perhaps it is a consequence of another change enabling the broken > path. Maybe someone on one of the lists will have an idea. > >From code logic, bcache should not have a discard bio in cache device, otherwise it is a bug. Therefore no matter whether the issue happens before v4.8 kernel, I'd like to have the fix in. >> v4.4.171: Build failed! Errors: >> drivers/md/bcache/writeback.h:71:6: error: implicit declaration of function ‘bio_op’; did you mean ‘bio_rw’? [-Werror=implicit-function-declaration] >> drivers/md/bcache/writeback.h:71:21: error: ‘REQ_OP_DISCARD’ undeclared (first use in this function); did you mean ‘REQ_DISCARD’? >> >> v3.18.132: Build failed! Errors: >> drivers/md/bcache/writeback.h:71:6: error: implicit declaration of function ‘bio_op’; did you mean ‘bio_rw’? [-Werror=implicit-function-declaration] >> drivers/md/bcache/writeback.h:71:21: error: ‘REQ_OP_DISCARD’ undeclared (first use in this function); did you mean ‘REQ_DISCARD’? >> >> >> How should we proceed with this patch? > > The patch seems reasonably easy to backport. Compile-tested only, and > only against v4.4.171. I don't have idea whether stable kernels accept rebased patches, for SUSE kernel I will do back port for all necessary kernel versions. -- Coly Li From mboxrd@z Thu Jan 1 00:00:00 1970 From: Coly Li Subject: Re: [PATCH] bcache: never writeback a discard operation Date: Wed, 23 Jan 2019 09:39:15 +0800 Message-ID: References: <20190118051825.18196-1-dja@axtens.net> <20190122155556.478CB217D6@mail.kernel.org> <87womwp71z.fsf@linkitivity.dja.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87womwp71z.fsf@linkitivity.dja.id.au> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Daniel Axtens , Sasha Levin Cc: Michael Lyle , Kent Overstreet , "Guilherme G . Piccoli" , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org List-Id: linux-bcache@vger.kernel.org 5ZyoIDIwMTkvMS8yMyDkuIrljYg4OjEwLCBEYW5pZWwgQXh0ZW5zIOWGmemBkzoKPiBIaSBTYXNo YSwKPiAKPj4gVGhpcyBjb21taXQgaGFzIGJlZW4gcHJvY2Vzc2VkIGJlY2F1c2UgaXQgY29udGFp bnMgYSAiRml4ZXM6IiB0YWcsCj4+IGZpeGluZyBjb21taXQ6IDcyYzI3MDYxMmJkMyBiY2FjaGU6 IFdyaXRlIG91dCBmdWxsIHN0cmlwZXMuCj4gCj4gSSBhZGRlZCB0aGF0IGZpeGVzIHRhZyBiZWNh dXNlIHRoYXQgd2FzIHRoZSBjb21taXQgdGhhdCBhZGRlZCB0aGUKPiBjb2RlLiBIb3dldmVyLCBJ IG5vdGljZWQgdGhhdCBvbmUgb2YgdGhlIGJ1ZyByZXBvcnRzIG1lbnRpb25zIHRoYXQgdGhlCj4g cHJvYmxlbSBvbmx5IGFyaXNpbmcgYWZ0ZXIgdjQuOC4gWzFdIEkgZG9uJ3QgcXVpdGUga25vdyB3 aGF0IHRvIG1ha2Ugb2YKPiB0aGlzOiBwZXJoYXBzIGl0IGlzIGEgY29uc2VxdWVuY2Ugb2YgYW5v dGhlciBjaGFuZ2UgZW5hYmxpbmcgdGhlIGJyb2tlbgo+IHBhdGguIE1heWJlIHNvbWVvbmUgb24g b25lIG9mIHRoZSBsaXN0cyB3aWxsIGhhdmUgYW4gaWRlYS4KPiAKCj5Gcm9tIGNvZGUgbG9naWMs IGJjYWNoZSBzaG91bGQgbm90IGhhdmUgYSBkaXNjYXJkIGJpbyBpbiBjYWNoZSBkZXZpY2UsCm90 aGVyd2lzZSBpdCBpcyBhIGJ1Zy4gVGhlcmVmb3JlIG5vIG1hdHRlciB3aGV0aGVyIHRoZSBpc3N1 ZSBoYXBwZW5zCmJlZm9yZSB2NC44IGtlcm5lbCwgSSdkIGxpa2UgdG8gaGF2ZSB0aGUgZml4IGlu LgoKPj4gdjQuNC4xNzE6IEJ1aWxkIGZhaWxlZCEgRXJyb3JzOgo+PiAgICAgZHJpdmVycy9tZC9i Y2FjaGUvd3JpdGViYWNrLmg6NzE6NjogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1 bmN0aW9uIOKAmGJpb19vcOKAmTsgZGlkIHlvdSBtZWFuIOKAmGJpb19yd+KAmT8gWy1XZXJyb3I9 aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4+ICAgICBkcml2ZXJzL21kL2JjYWNoZS93 cml0ZWJhY2suaDo3MToyMTogZXJyb3I6IOKAmFJFUV9PUF9ESVNDQVJE4oCZIHVuZGVjbGFyZWQg KGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKTsgZGlkIHlvdSBtZWFuIOKAmFJFUV9ESVNDQVJE 4oCZPwo+Pgo+PiB2My4xOC4xMzI6IEJ1aWxkIGZhaWxlZCEgRXJyb3JzOgo+PiAgICAgZHJpdmVy cy9tZC9iY2FjaGUvd3JpdGViYWNrLmg6NzE6NjogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9u IG9mIGZ1bmN0aW9uIOKAmGJpb19vcOKAmTsgZGlkIHlvdSBtZWFuIOKAmGJpb19yd+KAmT8gWy1X ZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4+ICAgICBkcml2ZXJzL21kL2Jj YWNoZS93cml0ZWJhY2suaDo3MToyMTogZXJyb3I6IOKAmFJFUV9PUF9ESVNDQVJE4oCZIHVuZGVj bGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKTsgZGlkIHlvdSBtZWFuIOKAmFJFUV9E SVNDQVJE4oCZPwo+Pgo+Pgo+PiBIb3cgc2hvdWxkIHdlIHByb2NlZWQgd2l0aCB0aGlzIHBhdGNo Pwo+IAo+IFRoZSBwYXRjaCBzZWVtcyByZWFzb25hYmx5IGVhc3kgdG8gYmFja3BvcnQuIENvbXBp bGUtdGVzdGVkIG9ubHksIGFuZAo+IG9ubHkgYWdhaW5zdCB2NC40LjE3MS4KCkkgZG9uJ3QgaGF2 ZSBpZGVhIHdoZXRoZXIgc3RhYmxlIGtlcm5lbHMgYWNjZXB0IHJlYmFzZWQgcGF0Y2hlcywgZm9y ClNVU0Uga2VybmVsIEkgd2lsbCBkbyBiYWNrIHBvcnQgZm9yIGFsbCBuZWNlc3Nhcnkga2VybmVs IHZlcnNpb25zLgoKLS0gCgpDb2x5IExpCgotLQpkbS1kZXZlbCBtYWlsaW5nIGxpc3QKZG0tZGV2 ZWxAcmVkaGF0LmNvbQpodHRwczovL3d3dy5yZWRoYXQuY29tL21haWxtYW4vbGlzdGluZm8vZG0t ZGV2ZWw=