All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: selftests/vm madv_populate.c test
Date: Fri, 17 Sep 2021 16:45:48 -0600	[thread overview]
Message-ID: <b703a326-66f7-bf35-58ee-f60e504ea5ef@linuxfoundation.org> (raw)

Hi David,

I am running into the following warning when try to build this test:

madv_populate.c:334:2: warning: #warning "missing MADV_POPULATE_READ or MADV_POPULATE_WRITE definition" [-Wcpp]
   334 | #warning "missing MADV_POPULATE_READ or MADV_POPULATE_WRITE definition"
       |  ^~~~~~~


I see that the following handling is in place. However there is no
other information to explain why the check is necessary.

#if defined(MADV_POPULATE_READ) && defined(MADV_POPULATE_WRITE)

#else /* defined(MADV_POPULATE_READ) && defined(MADV_POPULATE_WRITE) */

#warning "missing MADV_POPULATE_READ or MADV_POPULATE_WRITE definition"

I do see these defined in:

include/uapi/asm-generic/mman-common.h:#define MADV_POPULATE_READ       22
include/uapi/asm-generic/mman-common.h:#define MADV_POPULATE_WRITE      23

Is this the case of missing include from madv_populate.c?

thanks,
-- Shuah

             reply	other threads:[~2021-09-17 22:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 22:45 Shuah Khan [this message]
2021-09-18  7:41 ` selftests/vm madv_populate.c test David Hildenbrand
2021-10-15 15:45   ` Shuah Khan
2021-10-15 15:47     ` David Hildenbrand
2021-10-15 16:06       ` David Hildenbrand
2021-10-15 16:15         ` David Hildenbrand
2021-10-15 16:19           ` David Hildenbrand
2021-10-15 16:25             ` Shuah Khan
2021-10-15 16:28               ` David Hildenbrand
2021-10-15 16:34                 ` David Hildenbrand
2021-10-15 16:40                   ` Shuah Khan
2021-10-15 16:46                     ` David Hildenbrand
2021-10-15 16:21       ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b703a326-66f7-bf35-58ee-f60e504ea5ef@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.