From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FD1DC38145 for ; Tue, 6 Sep 2022 05:27:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D2AE84A0A; Tue, 6 Sep 2022 07:27:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="hn/qCbRb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D093084A0E; Tue, 6 Sep 2022 07:27:14 +0200 (CEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2075.outbound.protection.outlook.com [40.107.105.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 076BA849BD for ; Tue, 6 Sep 2022 07:27:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VdM9NNJKfM2LHyv2b5gzSn+AnEW0WqfX8eylKhbCmlToxSX3D98PZxA/vA/sPSJZ1qaf31S8VOWoKuB7w3shXYlYzHviMpIDENHlF47TqzvfuLtCOCttnE2ixsX+QvFBF+9kw3/vRdn0QFfNS9+o03/aInWX2f1m9oCfvbPFViX1Ub3xrpH+lTRgn2R0v3ahBpp78o6JXspuDTs+XdmmbOsSbqJwf4mA0FFfWFbygPy2Zn1/cTjkl8dN/V8JlVEl9L8j72oF5dnDOCpCijNFW3zl8xyo/XlexViMRWiX0Hlv+LLw06yYxoor6DeEQlrtg/VgAgupHA2nq7P78OO3VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t6p4+Wdi5XbFouMqSP+Cd1nnu8BFQXOp6cq3pgN6Juc=; b=iJ16EQyKghsll7YaJ+bvKnd8WMtEuYXsDigmXKtjbDtF8FwhXfHqR0uzrd/H3yWybXyfDgfoCYl30JPRdagRblsgRs1bZqpW6oGCtvCW6NZlHUaM9PH31fYeje22vwH6Q/hhwOsArfgHbhA8iQXO619FSJoU3BvGusI61lsYuB7xxyFpQFtqV5PgcbTBxJEP0JQdG7LGM0VnegI+hJZP4F0O2hUl7CL5EbyISVYCqOlFIeucbXCRa4a7J02gPONaxJAK/E4wrvYwqA8DSeXsUN3cLIRzXxBq0v9hlftOhlJ49aaSabXtCz9lWzbDBv6da+LECHNS+K+cZoCVRYww3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t6p4+Wdi5XbFouMqSP+Cd1nnu8BFQXOp6cq3pgN6Juc=; b=hn/qCbRbcbu7KHbHTSEz3u89si9dW1UOyEp5wZIj5p2H4PXmjgbgtvWUwuEnzJwgREJGS4BY0ZUJi0t9bTMwnRgFMb9FLrPkjv5wvmMk48y1TzGfONTAb9063y9Jk1LTQ63Z5deRzPaf7syh/3tfO11BMtMEKBqFBZt5UEWYhvc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM6PR04MB6358.eurprd04.prod.outlook.com (2603:10a6:20b:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 05:27:03 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2d22:3315:6f9b:82c7]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::2d22:3315:6f9b:82c7%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 05:27:03 +0000 Message-ID: Date: Tue, 6 Sep 2022 13:26:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [PATCH v2 1/4] board: freescale: p1_p2_rdb_pc: Add workaround for board reset reboot loop Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Tom Rini , u-boot@lists.denx.de References: <20220501122314.32626-1-pali@kernel.org> <20220801133146.11481-1-pali@kernel.org> <20220821103004.y75mrkb3l23jc6um@pali> <20220831120456.qimijikbcepvb7g2@pali> From: Peng Fan In-Reply-To: <20220831120456.qimijikbcepvb7g2@pali> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR03CA0112.apcprd03.prod.outlook.com (2603:1096:4:91::16) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42338a86-0088-433f-90b6-08da8fc86e73 X-MS-TrafficTypeDiagnostic: AM6PR04MB6358:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ciRJN9PDsxgg7v/7SEq+DAg0wmRjOAQT5SprrprG6HsSE1r3u4sonH9O7kek8GHm2Y7ouT9kcD2TeB4YpxufV5iajWDfbY1jobI8SZ05qQtLyTuXV8WQxmgod4ngb6orBdb5Vs/8VE8seedG7W+CcwhM+DIGDZLBMjpqPCET4aDmyJ989Oe+GlUzOkyr7GSJP7SULMnDqVvDSDbney1iFKSPWlf0A2Ad6jDqDDDOSAkKJmSn/O2BfkBZSXuB9XcQ3cVPqdD4SKCymTVnwikgRLrOkoXy1QWL5TzvMUPAeYsrXgMrCANxLX15Nj22WRtmoVD12kLQY7YKFVP48jImVEs3iQjMMcIy9E29ZTrphUSCketKeyLNZxAqoveg0SP2zv4YwkTqtPKZyEBELrjr7zKktwy4m/wvz1pHi4UBsEa+jWCj79J1Y1+KmdoqouBfyrOCX6LybsUq4mxNppDzibUFJOZcmM5slOr5qq0Vph5F0tYebKnQoosQvu5pGIclUZ/vPlX9SHUY8G2wVszxQWtg8N5WNU3n6OkH5NWz5QVDAtRLaQwv+TXBFgqNi6IKPdJj15jkACmWWFWF+yBxp2uJg6ZppwjrhoRvsnmcSUVWN8B4DIiiVrvUgIVnrG8YmuyJw3tSNpCUyUgb6hrV0BhGY4yBncLHikIseJl/SZPwC7PomtUGeCOG26bXx/0OMfsK/oqoFOp+4vN/Z3OVZDuJ3ExKptovZaX1mRShE2RZrrml20UBNzdJYazHi4AbeivmEiSfel+lQxcbkUIHacRGwpNImM0YPOOewmG4ytaJpHAE7FDAKwN1BbPuTu6s8Iq3ZGD5ncqecj0dvIp21D7dsXRdldGudY3A2yWo0zI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(39860400002)(376002)(346002)(136003)(396003)(2906002)(110136005)(83380400001)(4001150100001)(38350700002)(38100700002)(8676002)(66946007)(66476007)(316002)(66556008)(5660300002)(44832011)(186003)(8936002)(66574015)(53546011)(52116002)(26005)(6512007)(2616005)(478600001)(6506007)(6486002)(6666004)(41300700001)(31696002)(86362001)(966005)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cThXN2FqaG1TT0pnUHF4KzNCSzhVU2hCWm0xM2FaNzhjeC9OL1ZoMEJTbVRq?= =?utf-8?B?eUZFUUJtQXNjWmxwQWxiZXRNM2ZjNm5WYUV5SWRST2FhckxTTEsrSFFHM0Rq?= =?utf-8?B?eFpoRVJpWmVKOVFrVmhDYUp4U1BDdXpnQXZnZ0lhUkVXSy93Q1pyL1NMOUJz?= =?utf-8?B?QmZqZk5wb1Z4aXJjK0lRVmJLU2NCdWsrUHBlUHo3REFUZ3dBVkdVMzZDQUJW?= =?utf-8?B?SnJ6TW5WbWluVHB6NUUrK0cxWmJ5d1hVN3phWGN4SnVvb1FhZWtxbTBXcnNL?= =?utf-8?B?blpXVWMrY1lpcVVKWVg0S2c3Z3orQSs4VkFudUUrUXgzSTJiWGlJRFE3VDh1?= =?utf-8?B?S3JlaEdka0lEbE1vemVrNVgveHlNdFNZUlhUT2NoWWZWTmo2bTRad0lpMlF0?= =?utf-8?B?cnM4SUx1bitkRkQzMHRuQjlzUlhtODFpbkllVGo2NFpjUmJ4ZmE5RUR0NnJu?= =?utf-8?B?Q1RWL3ZFNkh2VUhCV2tWNCtRTFJtLy9YV2lRalIwTFRtREVHY0UvYWxGcE9W?= =?utf-8?B?V29sZ0tkb2owZk1OWDI3RVVldjJTVVZtcitrcmpqbzc3b1RqcWdiTDVSVHBP?= =?utf-8?B?V09lNlRmV1VvcEdKZXFid0I4MXNyT3RoV1YwTFhKS3VEbG5wYWtYNEZHL2dX?= =?utf-8?B?eUhqdEJWS0F4Q3BUNVNFaU9WQjMwK0ZKdGxSNmpoM0FJTjJIWXJMZDVxRFQ0?= =?utf-8?B?c0R4MmhxdTBhbXAxQ0tiTjQyVHZNemIyRXBYQ2tTRjBLcDRjck1EbGdKSXdq?= =?utf-8?B?K2pRc0QrQWFoNFpiQ0hpRnowNWF0U1BSMGkwa0JKbjlUTGdxd0JKSVArU1p6?= =?utf-8?B?NDVOdkZQZU91SlZLemJFaHVDUCt0eEkwOVRTcVY0NVVaanNGbU5LZ2ZnS2RX?= =?utf-8?B?aWM3MUFCc2xvQndic2tuaStIRi9zS3FGZWwwN1laUTltMGdXd2FlTEdhaXNn?= =?utf-8?B?TmNWVDYzTUEzM0Q3SmkwaTVnUVV3OFBPYmhRd3VvWTB1bU1Ka0dERVk1ZGxh?= =?utf-8?B?bUdQV3VaR0IvdWNYR3FiSmk2OWJMa1FXZDcweHphRHhwZkc2N1BHUWFCbGZS?= =?utf-8?B?RHRJbThobFVvc0w4V2x0andsNTU5QVNlV2NVYjVFTFhqMnRZeDhzd3I5RXAx?= =?utf-8?B?bEpRM25PSzhJMENlSmt2NXdsYkl1SVVsMnJTTDRlbTd5RldVUHpPRVJRT0w0?= =?utf-8?B?M2V2UlpFR01rRDE5Q0RjeDhLMUxEbXM3aGMzTStjT05MQkY5eFN1R29UMVVr?= =?utf-8?B?ZTI4UUkrT1ExZE9yM2hhdUJ4aHlSOCtZOXFlNFVWSFhTRmw3Ni9kT1VtamEv?= =?utf-8?B?UmhyQTZBY3hBZ2tFWTh4MmJRTkNINzlOeFlHSkFVOUpZT3dLMU5Bd1AvdU1Z?= =?utf-8?B?aXlhVGlUOXU3UWN3YUljMW13QmVqamlKZ0I5STVBWDhjVXR3VWVoWWtCU2Zh?= =?utf-8?B?VE9zR0dSM2x6ODY0c25SMUhhRzgxN0ZPd1Z4MTRwb1NJQ25RY3JtbXFwSDdl?= =?utf-8?B?WU5DQWViYWdtdktuUk8vQnFQY3lPdE1ZRjY3OXhZd2tlZ3A2aUhzek4wRldz?= =?utf-8?B?dFRUaUNVRVp2N0NzdGJFdU5tNFF1dE5tbHNDWTM5aEVGU1pPT0hrSXNyS1ha?= =?utf-8?B?ZmE1VnNYdm9MTVZDTHVoT0thMUV0a04wT29TbnNUM0hIdDV5eWc1dGRnMXBE?= =?utf-8?B?UVN1K2NHZlhucGtRUEpoeU42bm1Ra095S212cm9pQjkzR0J1Ni82REJaS0xD?= =?utf-8?B?RzdBc0VGL1lSZkkyUklQYlRYRVhsbXhjWll0NXlYcTlJR3IxeGRKMTd6OFpt?= =?utf-8?B?Kzh5WUpvOUJiSEtVMEVxSktKcVFnVmhrUUtwNW5hcEE3SklTTzJac0ZDYjdi?= =?utf-8?B?cEVPNVpnbWN5NURETjBRM2JDRDZIc0F4M3Y5eEI1d3BKOWRlOEc1WmN2Smsx?= =?utf-8?B?bVZGMjRhNXZxZkRUdzVnOWd4M2hGUDNRM1dqd3h1Nmk3RlpJc3FXUWdzc1lF?= =?utf-8?B?cS9oanNQaDQ4VTF2a0dnVGZIQXJlVE5qMkZpL1Z6cWJHZzl2TzJwUDJqMkx6?= =?utf-8?B?M0JibXJWZGZMbVVacWN2Q3UyeGJsbVpTWDIyYXVkS1VlR3YrU1gwajlvYzZx?= =?utf-8?Q?KDf2R1VZ5PkB/Y/I7xzjQHiQf?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42338a86-0088-433f-90b6-08da8fc86e73 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 05:27:03.7988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LkAe0oDFVgUPucqwRLqU02Qys3hEEVGZe4EI+AfYjWOZgScjDscb/E7NMJyjIXTcbv6hfLZDpEqEFJR3L/hdUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6358 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/31/2022 8:04 PM, Pali Rohár wrote: > PING???? In tag: https://source.denx.de/u-boot/custodians/u-boot-fsl-qoriq/-/tags/fsl-qoriq-2022-9-6 Waiting CI results. Regards, Peng. > > On Sunday 21 August 2022 12:30:04 Pali Rohár wrote: >> PING???? I have not received any response for these patches. >> Why you are ignoring me? >> >> You have already merged commit "board: freescale: p1_p2_rdb_pc: >> Implement board_reset()" from v1 of this patch series >> https://source.denx.de/u-boot/u-boot/-/commit/20fb58fc5a1c83ee0085b2e9f7ecda8b761a5592 >> without applying reset workaround commit from v1 (also available in v2) >> which effectively broke reset support in U-Boot. >> >> Why you are continuing breaking P1/P2 boards? >> >> Patches for this are already waiting on the list. >> >> On Monday 01 August 2022 15:31:43 Pali Rohár wrote: >>> CPLD's system reset register on P1/P2 RDB boards is not autocleared after >>> flipping it. If this register is set to one in 100ms after reset starts >>> then CPLD triggers another CPU reset. >>> >>> This means that trying to reset board via CPLD system reset register cause >>> reboot loop. To prevent this reboot loop, the only workaround is to try to >>> clear CPLD's system reset register as early as possible. U-Boot is already >>> doing it in its board_early_init_f() function, which seems to be enough as >>> register is cleared prior CPLD triggers another reset. >>> >>> But board_early_init_f() is not called from SPL and therefore usage of SPL >>> can cause reboot loop. >>> >>> To prevent reboot loop when using SPL, call board_early_init_f() function >>> in SPL too. For accessing CPLD memory space it is needed to have CPLD entry >>> in TLB. >>> >>> With this change it is possible to trigger board reset via CPLD's system >>> reset register on P2020 RDB board. >>> >>> Signed-off-by: Pali Rohár >>> --- >>> Changes in v2: >>> * Resend patch >>> * Update comment about watchdog >>> --- >>> board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c | 13 +++++++++++++ >>> board/freescale/p1_p2_rdb_pc/spl.c | 6 ++++++ >>> board/freescale/p1_p2_rdb_pc/tlb.c | 2 +- >>> 3 files changed, 20 insertions(+), 1 deletion(-) >>> >>> diff --git a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c >>> index 343059c09c36..84e1d65cdb1f 100644 >>> --- a/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c >>> +++ b/board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c >>> @@ -97,6 +97,19 @@ void board_cpld_init(void) >>> out_8(&cpld_data->status_led, CPLD_STATUS_LED); >>> out_8(&cpld_data->fxo_led, CPLD_FXO_LED); >>> out_8(&cpld_data->fxs_led, CPLD_FXS_LED); >>> + >>> + /* >>> + * CPLD's system reset register on P1/P2 RDB boards is not autocleared >>> + * after flipping it. If this register is set to one then CPLD triggers >>> + * reset of CPU in few ms. >>> + * >>> + * CPLD does not trigger reset of CPU for 100ms after the last reset. >>> + * >>> + * This means that trying to reset board via CPLD system reset register >>> + * cause reboot loop. To prevent this reboot loop, the only workaround >>> + * is to try to clear CPLD's system reset register as early as possible >>> + * and it has to be done in 100ms since the last start of reset. >>> + */ >>> out_8(&cpld_data->system_rst, CPLD_SYS_RST); >>> } >>> >>> diff --git a/board/freescale/p1_p2_rdb_pc/spl.c b/board/freescale/p1_p2_rdb_pc/spl.c >>> index 22156f2824ec..def28665960d 100644 >>> --- a/board/freescale/p1_p2_rdb_pc/spl.c >>> +++ b/board/freescale/p1_p2_rdb_pc/spl.c >>> @@ -31,6 +31,12 @@ void board_init_f(ulong bootflag) >>> u32 plat_ratio, bus_clk; >>> ccsr_gur_t *gur = (void *)CONFIG_SYS_MPC85xx_GUTS_ADDR; >>> >>> + /* >>> + * Call board_early_init_f() as early as possible as it workarounds >>> + * reboot loop due to broken CPLD state machine for reset line. >>> + */ >>> + board_early_init_f(); >>> + >>> console_init_f(); >>> >>> /* Set pmuxcr to allow both i2c1 and i2c2 */ >>> diff --git a/board/freescale/p1_p2_rdb_pc/tlb.c b/board/freescale/p1_p2_rdb_pc/tlb.c >>> index 13f3a1edf68d..2d431d6d0d90 100644 >>> --- a/board/freescale/p1_p2_rdb_pc/tlb.c >>> +++ b/board/freescale/p1_p2_rdb_pc/tlb.c >>> @@ -61,11 +61,11 @@ struct fsl_e_tlb_entry tlb_table[] = { >>> MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G, >>> 0, 5, BOOKE_PAGESZ_1M, 1), >>> #endif >>> +#endif /* not SPL */ >>> >>> SET_TLB_ENTRY(1, CONFIG_SYS_CPLD_BASE, CONFIG_SYS_CPLD_BASE_PHYS, >>> MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G, >>> 0, 6, BOOKE_PAGESZ_1M, 1), >>> -#endif /* not SPL */ >>> >>> #ifdef CONFIG_SYS_NAND_BASE >>> /* *I*G - NAND */ >>> -- >>> 2.20.1 >>>