All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Stiffler <j-stiffler@ti.com>
To: Denys Dmytriyenko <denys@ti.com>, <meta-arago@arago-project.org>
Subject: Re: [EXTERNAL] [thud/master][PATCH v2] rng-tools: remove duplicate initscript and wait for module load
Date: Mon, 9 Sep 2019 10:16:33 -0400	[thread overview]
Message-ID: <b709573c-141f-0bb2-a9cf-78da52e67498@ti.com> (raw)
In-Reply-To: <1567617940-18452-1-git-send-email-denys@ti.com>

Denys,

Can you backport this to ti2019.03?


Thanks,

Jake

On 9/4/2019 1:25 PM, Denys Dmytriyenko wrote:
> Since Arago still has a mix of SysVinit iniscripts and systemd unit files, it
> enables both of the DISTRO_FEATURES, resulting in some duplication. It appears
> that rngd currently has a problem handling signals when forked in daemon mode.
> Hence, drop SysVinit initscript in favor of systemd service, as the latter one
> starts rngd in foreground. Also, add udev dependency rule on omap_rng module.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
> v2 - since dropping initscript, disable corresponding update-rc.d processing
>
>   .../recipes-support/rng-tools/rng-tools/rngd.rules        |  1 +
>   .../recipes-support/rng-tools/rng-tools_%.bbappend        | 15 +++++++++++++++
>   2 files changed, 16 insertions(+)
>   create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
>   create mode 100644 meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
>
> diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> new file mode 100644
> index 0000000..a21c99b
> --- /dev/null
> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools/rngd.rules
> @@ -0,0 +1 @@
> +ACTION=="add", SUBSYSTEM=="module", KERNEL=="omap_rng", TAG+="systemd", ENV{SYSTEMD_WANTS}+="rngd.service"
> diff --git a/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
> new file mode 100644
> index 0000000..2a7810f
> --- /dev/null
> +++ b/meta-arago-distro/recipes-support/rng-tools/rng-tools_%.bbappend
> @@ -0,0 +1,15 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +PR_append = ".arago0"
> +
> +SRC_URI += "file://rngd.rules"
> +
> +do_install_append() {
> +	# remove duplicate initscript
> +	rm -f ${D}${sysconfdir}/init.d/rng-tools
> +
> +	install -d ${D}${sysconfdir}/udev/rules.d/
> +	install -m0644 ${WORKDIR}/rngd.rules ${D}${sysconfdir}/udev/rules.d/
> +}
> +
> +INHIBIT_UPDATERCD_BBCLASS = "1"


      reply	other threads:[~2019-09-09 14:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 17:25 [thud/master][PATCH v2] rng-tools: remove duplicate initscript and wait for module load Denys Dmytriyenko
2019-09-09 14:16 ` Jacob Stiffler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b709573c-141f-0bb2-a9cf-78da52e67498@ti.com \
    --to=j-stiffler@ti.com \
    --cc=denys@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.