From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755191AbdHYIyA (ORCPT ); Fri, 25 Aug 2017 04:54:00 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52593 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755029AbdHYIx6 (ORCPT ); Fri, 25 Aug 2017 04:53:58 -0400 Subject: Re: [PATCH v2 18/20] perf tools: Add support for the SPF perf event To: Anshuman Khandual , paulmck@linux.vnet.ibm.com, peterz@infradead.org, akpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, Thomas Gleixner , Ingo Molnar , hpa@zytor.com, Will Deacon Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, haren@linux.vnet.ibm.com, npiggin@gmail.com, bsingharora@gmail.com, Tim Chen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org References: <1503007519-26777-1-git-send-email-ldufour@linux.vnet.ibm.com> <1503007519-26777-19-git-send-email-ldufour@linux.vnet.ibm.com> <6df385f1-7e7e-516f-525e-900af9bd5a01@linux.vnet.ibm.com> From: Laurent Dufour Date: Fri, 25 Aug 2017 10:53:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6df385f1-7e7e-516f-525e-900af9bd5a01@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17082508-0012-0000-0000-0000057241BD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17082508-0013-0000-0000-000018EA3DE8 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-25_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708250131 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/08/2017 10:48, Anshuman Khandual wrote: > On 08/18/2017 03:35 AM, Laurent Dufour wrote: >> Add support for the new speculative faults event. >> >> Signed-off-by: Laurent Dufour >> --- >> tools/include/uapi/linux/perf_event.h | 1 + >> tools/perf/util/evsel.c | 1 + >> tools/perf/util/parse-events.c | 4 ++++ >> tools/perf/util/parse-events.l | 1 + >> tools/perf/util/python.c | 1 + >> 5 files changed, 8 insertions(+) >> >> diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h >> index b1c0b187acfe..3043ec0988e9 100644 >> --- a/tools/include/uapi/linux/perf_event.h >> +++ b/tools/include/uapi/linux/perf_event.h >> @@ -111,6 +111,7 @@ enum perf_sw_ids { >> PERF_COUNT_SW_EMULATION_FAULTS = 8, >> PERF_COUNT_SW_DUMMY = 9, >> PERF_COUNT_SW_BPF_OUTPUT = 10, >> + PERF_COUNT_SW_SPF_DONE = 11, > > Right, just one event for the success case. 'DONE' is redundant, only > 'SPF' should be fine IMHO. > Fair enough, I'll rename it PERF_COUNT_SW_SPF. Thanks, Laurent. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id BB1816810B7 for ; Fri, 25 Aug 2017 04:53:59 -0400 (EDT) Received: by mail-pg0-f72.google.com with SMTP id q68so8630207pgq.11 for ; Fri, 25 Aug 2017 01:53:59 -0700 (PDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id f30si4568727plf.557.2017.08.25.01.53.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Aug 2017 01:53:58 -0700 (PDT) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v7P8n4Wu079110 for ; Fri, 25 Aug 2017 04:53:58 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2cjb0acgua-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 25 Aug 2017 04:53:58 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Aug 2017 09:53:55 +0100 Subject: Re: [PATCH v2 18/20] perf tools: Add support for the SPF perf event References: <1503007519-26777-1-git-send-email-ldufour@linux.vnet.ibm.com> <1503007519-26777-19-git-send-email-ldufour@linux.vnet.ibm.com> <6df385f1-7e7e-516f-525e-900af9bd5a01@linux.vnet.ibm.com> From: Laurent Dufour Date: Fri, 25 Aug 2017 10:53:47 +0200 MIME-Version: 1.0 In-Reply-To: <6df385f1-7e7e-516f-525e-900af9bd5a01@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Sender: owner-linux-mm@kvack.org List-ID: To: Anshuman Khandual , paulmck@linux.vnet.ibm.com, peterz@infradead.org, akpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, Thomas Gleixner , Ingo Molnar , hpa@zytor.com, Will Deacon Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, haren@linux.vnet.ibm.com, npiggin@gmail.com, bsingharora@gmail.com, Tim Chen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org On 21/08/2017 10:48, Anshuman Khandual wrote: > On 08/18/2017 03:35 AM, Laurent Dufour wrote: >> Add support for the new speculative faults event. >> >> Signed-off-by: Laurent Dufour >> --- >> tools/include/uapi/linux/perf_event.h | 1 + >> tools/perf/util/evsel.c | 1 + >> tools/perf/util/parse-events.c | 4 ++++ >> tools/perf/util/parse-events.l | 1 + >> tools/perf/util/python.c | 1 + >> 5 files changed, 8 insertions(+) >> >> diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h >> index b1c0b187acfe..3043ec0988e9 100644 >> --- a/tools/include/uapi/linux/perf_event.h >> +++ b/tools/include/uapi/linux/perf_event.h >> @@ -111,6 +111,7 @@ enum perf_sw_ids { >> PERF_COUNT_SW_EMULATION_FAULTS = 8, >> PERF_COUNT_SW_DUMMY = 9, >> PERF_COUNT_SW_BPF_OUTPUT = 10, >> + PERF_COUNT_SW_SPF_DONE = 11, > > Right, just one event for the success case. 'DONE' is redundant, only > 'SPF' should be fine IMHO. > Fair enough, I'll rename it PERF_COUNT_SW_SPF. Thanks, Laurent. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org