From: David Ahern <dsahern@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next 3/3] rdma: Add an option to rename IB device interface
Date: Mon, 29 Oct 2018 11:07:06 -0600 [thread overview]
Message-ID: <b7151495-d8ab-209b-a86e-575fc2f4ed53@gmail.com> (raw)
In-Reply-To: <20181029103046.GQ3974@mtr-leonro.mtl.com>
On 10/29/18 4:30 AM, Leon Romanovsky wrote:
>
> Sorry for being slow in response, I was on vacation.
> ----------
>
> This print is intended to warn about missing "new name" and it is not
> checked by rd_exec_require_dev()
>
> To emphasize it:
>
> diff --git a/rdma/dev.c b/rdma/dev.c
> index 760b7fb3..468ae686 100644
> --- a/rdma/dev.c
> +++ b/rdma/dev.c
> @@ -246,6 +246,7 @@ static int dev_set_name(struct rd *rd)
> uint32_t seq;
>
> if (rd_no_arg(rd)) {
> + pr_err("hello world\n");
> pr_err("Please provide device new name.\n");
> return -EINVAL;
> }
>
> Produces the following output:
> [leonro@server iproute2]$ ./rdma/rdma dev set mlx5_0 name
> hello world
> Please provide device new name.
>
> So how will we progress from here? Should I respin?
ok, thanks for the explanation.
Steve mentioned an update to the man page is needed as well. Please do
that in the respin.
Thanks,
next prev parent reply other threads:[~2018-10-29 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 11:51 [PATCH iproute2-next 0/3] rdma: IB device rename Leon Romanovsky
2018-10-18 11:51 ` [PATCH iproute2-next 1/3] rdma: Update kernel include file to support IB device renaming Leon Romanovsky
2018-10-18 11:51 ` [PATCH iproute2-next 2/3] rdma: Introduce command execution helper with required device name Leon Romanovsky
2018-10-18 11:51 ` [PATCH iproute2-next 3/3] rdma: Add an option to rename IB device interface Leon Romanovsky
2018-10-21 16:02 ` David Ahern
2018-10-29 10:30 ` Leon Romanovsky
2018-10-29 17:07 ` David Ahern [this message]
2018-10-29 17:34 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7151495-d8ab-209b-a86e-575fc2f4ed53@gmail.com \
--to=dsahern@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.