From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tan, Jianfeng" Subject: Re: [PATCH v3 1/5] eal: bring forward multi-process channel init Date: Fri, 20 Apr 2018 22:08:25 +0800 Message-ID: References: <1520177405-59091-1-git-send-email-jianfeng.tan@intel.com> <1524156618-81402-1-git-send-email-jianfeng.tan@intel.com> <1524156618-81402-2-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: thomas@monjalon.net To: "Burakov, Anatoly" , dev@dpdk.org Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5CAD48DA4 for ; Fri, 20 Apr 2018 16:08:30 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/20/2018 4:16 PM, Burakov, Anatoly wrote: > On 19-Apr-18 5:50 PM, Jianfeng Tan wrote: >> Adjust the init sequence: put mp channel init before bus scan >> so that we can init the vdev bus through mp channel in the >> secondary process before the bus scan. >> >> Signed-off-by: Jianfeng Tan >> Reviewed-by: Qi Zhang >> --- > > Hi Jianfeng, > > Just a general question. I can't recall if we've discussed this > internally, I don't think we once discussed this. > but does this new IPC-based vdev bus scan trigger any memory allocations? No, we don't. > So far bus scans were well-behaved and didn't do that. > I think it's due to that even in the master branch implementation, bus scan is ahead of memory init. So we don't use any rte_malloc in bus scan. Thanks, Jianfeng